[PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg

[PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg

[Ni, Ray]

Ray Ni (2):
  PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout
  MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout

 MdeModulePkg/MdeModulePkg.dec                               | 4 ----
 PcAtChipsetPkg/PcAtChipsetPkg.dec                           | 6 +++++-
 .../PcatRealTimeClockRuntimeDxe.inf                         | 5 ++---
 3 files changed, 7 insertions(+), 8 deletions(-)

-- 
2.21.0.windows.1

[PATCH 1/2] PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout

[Ni, Ray]

PcdRealTimeClockUpdateTimeout is now defined in MdeModulePkg.dec.
This is the only reason that causes PcAtChipsetPkg depends on
MdeModulePkg.
Move the PCD from MdeModulePkg.dec to PcAtChipsetPkg.dec removes
such dependency.

Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
---
 PcAtChipsetPkg/PcAtChipsetPkg.dec                           | 6 +++++-
 .../PcatRealTimeClockRuntimeDxe.inf                         | 5 ++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dec b/PcAtChipsetPkg/PcAtChipsetPkg.dec
index d99d91496b..aad53b07c8 100644
--- a/PcAtChipsetPkg/PcAtChipsetPkg.dec
+++ b/PcAtChipsetPkg/PcAtChipsetPkg.dec
@@ -4,7 +4,7 @@
 # This package is designed to public interfaces and implementation which follows
 # PcAt defacto standard.
 #
-# Copyright (c) 2009 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
 # Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -138,5 +138,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule]
   # @Prompt RTC Target Register address
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcTargetRegister|0x71|UINT8|0x0000001F
 
+  ## RTC Update Timeout Value(microsecond).
+  # @Prompt RTC Update Timeout Value.
+  gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UINT32|0x00000020
+
 [UserExtensions.TianoCore."ExtraFiles"]
   PcAtChipsetPkgExtra.uni
diff --git a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
index 9a0948be70..c73ee98105 100644
--- a/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
+++ b/PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcatRealTimeClockRuntimeDxe.inf
@@ -4,7 +4,7 @@
 # This driver provides GetTime, SetTime, GetWakeupTime, SetWakeupTime services to Runtime Service Table.
 # It will install a tagging protocol with gEfiRealTimeClockArchProtocolGuid.
 #
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
 # Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -33,7 +33,6 @@ [Sources]
 
 [Packages]
   MdePkg/MdePkg.dec
-  MdeModulePkg/MdeModulePkg.dec
   PcAtChipsetPkg/PcAtChipsetPkg.dec
 
 [LibraryClasses]
@@ -68,7 +67,7 @@ [FixedPcd]
   gPcAtChipsetPkgTokenSpaceGuid.PcdInitialValueRtcRegisterD     ## CONSUMES
 
 [Pcd]
-  gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout  ## CONSUMES
+  gPcAtChipsetPkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout   ## CONSUMES
   gPcAtChipsetPkgTokenSpaceGuid.PcdMinimalValidYear             ## CONSUMES
   gPcAtChipsetPkgTokenSpaceGuid.PcdMaximalValidYear             ## CONSUMES
   gPcAtChipsetPkgTokenSpaceGuid.PcdRtcIndexRegister             ## CONSUMES
-- 
2.21.0.windows.1

[PATCH 2/2] MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout

[Ni, Ray]

The PCD is moved to PcAtChipsetPkg so remove it from
MdeModulePkg.
Signed-off-by: Ray Ni <ray.ni@intel.com>
Cc: Hao A Wu <hao.a.wu@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
---
 MdeModulePkg/MdeModulePkg.dec | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 19935c88fa..17beb45235 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1128,10 +1128,6 @@ [PcdsFixedAtBuild, PcdsPatchableInModule]
   # @Prompt Maximum number of PEI performance log entries.
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxPeiPerformanceLogEntries16|0|UINT16|0x00010035
 
-  ## RTC Update Timeout Value(microsecond).
-  # @Prompt RTC Update Timeout Value.
-  gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout|100000|UINT32|0x00010034
-
   ## Indicates the 16550 serial port registers are in MMIO space, or in I/O space. Default is I/O space.<BR><BR>
   #   TRUE  - 16550 serial port registers are in MMIO space.<BR>
   #   FALSE - 16550 serial port registers are in I/O space.<BR>
-- 
2.21.0.windows.1

Re: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg

[Zeng, Star]

Both XXXPkg.uni need to be updated as the PCD movement.
With that, Reviewed-by: Star Zeng <star.zeng@intel.com>

Thanks,
Star

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Wednesday, August 28, 2019 7:27 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout
> from MdeModulePkg to PcAtChipsetPkg
> 
> 
> Ray Ni (2):
>   PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout
>   MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout
> 
>  MdeModulePkg/MdeModulePkg.dec                               | 4 ----
>  PcAtChipsetPkg/PcAtChipsetPkg.dec                           | 6 +++++-
>  .../PcatRealTimeClockRuntimeDxe.inf                         | 5 ++---
>  3 files changed, 7 insertions(+), 8 deletions(-)
> 
> --
> 2.21.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg

[Wu, Hao A]

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zeng, Star
> Sent: Wednesday, August 28, 2019 8:48 AM
> To: devel@edk2.groups.io; Ni, Ray
> Cc: Zeng, Star
> Subject: Re: [edk2-devel] [PATCH 0/2] move
> PcdRealTimeClockUpdateTimeout from MdeModulePkg to PcAtChipsetPkg
> 
> Both XXXPkg.uni need to be updated as the PCD movement.


Agree.


> With that, Reviewed-by: Star Zeng <star.zeng@intel.com>


Found that the PCD was introduced by commit f8ea30263c. At that time, the
PcatRealTimeClockRuntimeDxe driver was still in MdeModulePkg. Then commit
345e5a6556 moved the driver to PcAtChipsetPkg but forgot to move the PCD.

With Star's comment addressed, for the series:
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>

Also, please help to hold the patch after the upcoming stable tag, thanks.

Best Regards,
Hao Wu


> 
> Thanks,
> Star
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Ni,
> > Ray
> > Sent: Wednesday, August 28, 2019 7:27 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH 0/2] move PcdRealTimeClockUpdateTimeout
> > from MdeModulePkg to PcAtChipsetPkg
> >
> >
> > Ray Ni (2):
> >   PcAtChipsetPkg: add PcdRealTimeClockUpdateTimeout
> >   MdeModulePkg: Remove PcdRealTimeClockUpdateTimeout
> >
> >  MdeModulePkg/MdeModulePkg.dec                               | 4 ----
> >  PcAtChipsetPkg/PcAtChipsetPkg.dec                           | 6 +++++-
> >  .../PcatRealTimeClockRuntimeDxe.inf                         | 5 ++---
> >  3 files changed, 7 insertions(+), 8 deletions(-)
> >
> > --
> > 2.21.0.windows.1
> >
> >
> >
> 
> 
>