public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Bob Feng" <bob.c.feng@intel.com>
To: devel@edk2.groups.io
Cc: Bob Feng <bob.c.feng@intel.com>,
	Liming Gao <liming.gao@intel.com>,
	Steven Shi <steven.shi@intel.com>
Subject: [Patch][edk2-stable201908] BaseTools: fix an incremental build issue.
Date: Wed, 28 Aug 2019 16:52:09 +0800	[thread overview]
Message-ID: <20190828085209.25316-1-bob.c.feng@intel.com> (raw)

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2137

This patch is going to fix a regression issue of incremental
build which was introduced by the commit 94459080c.
The changing on INF file will not trigger module rebuild.

Signed-off-by: Bob Feng <bob.c.feng@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Cc: Steven Shi <steven.shi@intel.com>
---
 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
index 2cd0d3859e..f610365f6d 100755
--- a/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
+++ b/BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
@@ -1764,16 +1764,12 @@ class ModuleAutoGen(AutoGen):
             for f in self.AutoGenDepSet:
                 FileSet.add (f.Path)
 
             if os.path.exists (self.TimeStampPath):
                 os.remove (self.TimeStampPath)
-            with tempfile.NamedTemporaryFile('w+', dir=os.path.dirname(self.TimeStampPath), delete=False) as tf:
-                for f in FileSet:
-                    tf.write(f)
-                    tf.write("\n")
-                tempname = tf.name
-            SaveFileOnChange(self.TimeStampPath, tempname, False)
+
+            SaveFileOnChange(self.TimeStampPath, "\n".join(FileSet), False)
 
         # Ignore generating makefile when it is a binary module
         if self.IsBinaryModule:
             return
 
-- 
2.20.1.windows.1


             reply	other threads:[~2019-08-28  8:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  8:52 Bob Feng [this message]
2019-08-28 15:26 ` [Patch][edk2-stable201908] BaseTools: fix an incremental build issue Liming Gao
2019-08-28 15:56   ` Michael D Kinney
2019-08-28 16:10     ` Liming Gao
2019-08-28 17:31       ` Michael D Kinney
2019-08-28 18:06         ` [edk2-devel] " Michael D Kinney
2019-08-28 18:40         ` Michael D Kinney
2019-08-29  3:16           ` Bob Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190828085209.25316-1-bob.c.feng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox