From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Laszlo Ersek <lersek@redhat.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Andrew Fish <afish@apple.com>,
Baptiste Gerondeau <baptiste.gerondeau@linaro.org>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)
Date: Wed, 28 Aug 2019 10:24:00 +0100 [thread overview]
Message-ID: <20190828092400.GH29255@bivouac.eciton.net> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C91E513@SHSMSX104.ccr.corp.intel.com>
On Wed, Aug 28, 2019 at 01:40:22AM +0000, Wu, Hao A wrote:
> Per my understanding to the analysis from Leif, Laszlo and Mike, the patch
> will depend on the precedence of the below rules:
>
> * [LibraryClasses.common.$(MODULE_TYPE)]
> * [LibraryClasses.$(Arch)]
>
> So for now, we should wait for the final call on the above open, right?
Well, it is a bugfix regardless. But if the BaseTools behaviour is
restored to what it was before 9 August, the current state has no
observable side effects. And since we are in a hard freeze, I think
this fix should wait until after the tag.
Best Regards,
Leif
next prev parent reply other threads:[~2019-08-28 9:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 12:43 [PATCH 1/1] MdeModulePkg: fix !x86 builds (more) Leif Lindholm
2019-08-27 19:26 ` Laszlo Ersek
2019-08-27 20:59 ` Leif Lindholm
2019-08-27 21:26 ` [edk2-devel] " Michael D Kinney
2019-08-28 1:10 ` Bob Feng
2019-08-28 1:40 ` Wu, Hao A
2019-08-28 5:24 ` Michael D Kinney
2019-08-28 5:43 ` Wu, Hao A
2019-08-28 9:24 ` Leif Lindholm [this message]
2019-08-27 21:00 ` [edk2-devel] " Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190828092400.GH29255@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox