From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=rSwrFXYJ; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Wed, 28 Aug 2019 02:24:05 -0700 Received: by mail-wm1-f67.google.com with SMTP id p13so1829320wmh.1 for ; Wed, 28 Aug 2019 02:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HPNQDUicBQCcgI6KzADFYYKb46T/EOrKkEPubG7h57o=; b=rSwrFXYJEAr1E64HB/ijiaxRpDzbQvr76VAVe5LydpFXMoOFFkd4a7fSyRayjmD8SH BpRGDMAY8fq9b0XSiNDOsj02x1Ff+ZSwWq7kd9z5fqmI+E2M7nu+v8ZnsYD+t4Jpm01q p6l8Nb8nS3sFI7rxjTSEVsTd2aSnlkEqugv7Q7w2z8rrDZwCnrMlAO3R+UdJQYB3ag1E ZuZupu6fAw3YSYhaQ/yoAUbrPKD9IvKS2nicFDHtjT3WXco+xpW4JC0ixvVVhpNNEO/6 ykvQQfa64xCSnQdWOr1Fu/WluivFYRjvBv4n5y4xR0Pf7561e9CQi6UqeKkPH9R+lQzt vATw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HPNQDUicBQCcgI6KzADFYYKb46T/EOrKkEPubG7h57o=; b=cT2mXHR7I1q5xrSmMidRaAuBAahwEpA4nFAeE85uahBTLoZHpE5Vn7F7BQm17HZiHz Y6jjFdQIt7PF0p/MZ0nlzhGWrYGND8XVQc1DK1u+FfMr7zJLi667oeuUvuLPqBW+ecyV N5TpoOnWKo/lWyhl4IEm2EpDphpc0ao5Zezzx57npBA96+8q55FWvV/VRxJDlq52BtTD Y+MGlRgnIvhskxc+hWbWhWq2QiJM/ijIJ0S0R+3vjmFKWHbzP913Sx+RjHN+12rOtyrh AUgVfA0VVo1GPX0zvGI/M06Hl4gd+RQsgAeMPNaCKQS+aCAMU7Lwzk6McT+h1Kpe0Vim Exww== X-Gm-Message-State: APjAAAU1kivuj0I1lpbQpWcOFVbZNhVTQEHupsR1tuiAb/8plmka/ZHa gFHV4j1AROC/jOEpE0wfalXZxnD+SfM= X-Google-Smtp-Source: APXvYqzJAjDv+3befhmqSHhumx/wnDTaCuU+pPLqPYd3hCNj3Q/NaCufLGnUPoBF6DHff1LF+W8XBw== X-Received: by 2002:a1c:ed04:: with SMTP id l4mr3713909wmh.81.1566984243106; Wed, 28 Aug 2019 02:24:03 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 39sm6581279wrc.45.2019.08.28.02.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2019 02:24:02 -0700 (PDT) Date: Wed, 28 Aug 2019 10:24:00 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, hao.a.wu@intel.com Cc: Laszlo Ersek , "Kinney, Michael D" , Andrew Fish , Baptiste Gerondeau , "Wang, Jian J" , "Feng, Bob C" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more) Message-ID: <20190828092400.GH29255@bivouac.eciton.net> References: <20190827124328.9034-1-leif.lindholm@linaro.org> <6ce1988a-bd79-893e-5d8d-724b98329ab9@redhat.com> <20190827205926.GG29255@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 28, 2019 at 01:40:22AM +0000, Wu, Hao A wrote: > Per my understanding to the analysis from Leif, Laszlo and Mike, the patch > will depend on the precedence of the below rules: > > * [LibraryClasses.common.$(MODULE_TYPE)] > * [LibraryClasses.$(Arch)] > > So for now, we should wait for the final call on the above open, right? Well, it is a bugfix regardless. But if the BaseTools behaviour is restored to what it was before 9 August, the current state has no observable side effects. And since we are in a hard freeze, I think this fix should wait until after the tag. Best Regards, Leif