From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=b4BgH2Ln; spf=pass (domain: linaro.org, ip: 209.85.221.47, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by groups.io with SMTP; Thu, 29 Aug 2019 02:49:46 -0700 Received: by mail-wr1-f47.google.com with SMTP id t16so2735808wra.6 for ; Thu, 29 Aug 2019 02:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Sg/upaMTm8sB6JbecYUn8MqWJQJqSuw0EbZYfgdNCwE=; b=b4BgH2LnGv3wlTKuf7bom73w4Q7Fijp+ezAA55CILkKQck7B1eAJwEMnQj0QTG/TYP qGGIYGbD3qPD1nR1Oe2Sh/E5KnJXPauhoUvZgJzgvgrFsiKL4PjmjSuTKH0ATWO8gBnY MDqiw9LvCYzKsBHjGIms1ww4d3Yt8QuDDZGmweKafT7Eay6/j9h8dIoxHdujJEFY+d3t 8G1jLjI1sSKMBS3PsL4n3I1WfWQqzkqONb1yQ+FaHdkLYVLTQtb/xGcQx6vXxAOC2fJF FjwqQ3cTukmYgQauQUL7kDurMYBmpBwHdX3C0vDeaGZLBYMV48tKwJMRl+3TebmTcuOA BJ/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Sg/upaMTm8sB6JbecYUn8MqWJQJqSuw0EbZYfgdNCwE=; b=dTBbJ9Ex9uiq5N4UY+QloTRdOXoU3NHAiWLUwA4tZ3C2+hBaJsLE1Dm+qKbuKHGEME o1Gl+epeCpkaBRlHl0RO75q3w4biE0PQkHoP1uLQRK+KiTKxzS5FnzrjyhjVprMl9eQz 80N+lDz2V5DkENU5P4DQCDqsjQmQfWXio6tG7IaKeARRLWTftjylrIYavxaA9lCZI/Y1 WVoNjhnjCIbALKc5d3tLzdnDvUe/NmqlXCyMemcbzaAGdaxE/hJIALQ0KKX1SQvWOg0p 3xv8ot2tKVh10J0bfPTmELg5TZFbCU7eoqpEdy9Xi6pF8x4qgapoosC/ofLfhE9AIDbx 7V7A== X-Gm-Message-State: APjAAAUZlEtrcANCuilDA01/vaUTbtl3/LnfrZJK06X9Ypv6GUpN9rmW dEV3UK17hdrXfMpUzNVCGv4+Qg== X-Google-Smtp-Source: APXvYqw7tftE4KO6+dwXKc/84+N1LmqUJhWIMzo7uAjBNg2dURRWSIYeNnzba8gLo5wc/OZexAOJwA== X-Received: by 2002:a5d:4582:: with SMTP id p2mr2720304wrq.305.1567072185075; Thu, 29 Aug 2019 02:49:45 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a192sm2597569wma.1.2019.08.29.02.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 02:49:44 -0700 (PDT) Date: Thu, 29 Aug 2019 10:49:42 +0100 From: "Leif Lindholm" To: "Ni, Ray" Cc: "Gao, Liming" , "Cetola, Stephano" , "Kinney, Michael D" , "Jayanth.Raghuram@dell.com" , "'Andrew Fish (afish@apple.com)'" , Laszlo Ersek , "Wei.G.Liu@dell.com" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. Message-ID: <20190829094942.GN29255@bivouac.eciton.net> References: <31e5cee5c49d4381bfb26a0968c11749@ausx13mps324.AMER.DELL.COM> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DCA9B@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DD7DA@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C2A1B73@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Aug 28, 2019 at 05:33:28PM +0000, Ni, Ray wrote: > Liming, Stephano and all stewards, > My understanding is the requirement of embedding patch into the mail > body is due to a limitation in old system (01.org). That system > couldn't support mail attachments. Oh, it could. I think it was just disabled. > With the existence of mail attachments capability in new groups.io > system, can we accept such kind of patch submission? Or any side > effect you see if allowing mail attachments? Traditionally, the reason for not wanting patches as attachments is that it complicates doing inline code review as part of the email. If the mail system (let's take a wild guess, Outlook/Exchange?) doesn't corrupt the text *too* badly, I don't have an issue with the patch being sent in the message body *and* being attached so it could actually be applied. Alternatively, one could put the patch in the message body and a link to the patch in a public repo where it can be obtained. Best Regards, Leif > > Thanks, > Ray > > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Wednesday, August 28, 2019 12:59 AM > To: Jayanth.Raghuram@dell.com; devel@edk2.groups.io > Cc: Wei.G.Liu@dell.com > Subject: Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. > > OK. So, you can't use git send-email to send this patch. Another way > is to fork edk2 and create the branch to include this change. > Then, send the mail to let people review this patch in your branch. > > And, for this patch, can you submit BZ https://bugzilla.tianocore.org/ first? > Then, update its commit message format based on this wiki. > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > > Thanks > Liming > From: Jayanth.Raghuram@dell.com [mailto:Jayanth.Raghuram@dell.com] > Sent: Wednesday, August 28, 2019 2:30 AM > To: Gao, Liming >; devel@edk2.groups.io > Cc: Wei.G.Liu@dell.com > Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. > > Hi Liming, > > I sent the review request based on the description in the links that you mentioned below. > I sent it in an Dell Email since I cannot use GIT SMTP to send email out from our servers. > Please let me know what is wrong and I can help rectify that. > > Regards > Jayanth Raghuram > DellEMC | Server Platform BIOS > office + 1 512 723 1470 > > From: Gao, Liming > > Sent: Monday, August 26, 2019 8:57 PM > To: devel@edk2.groups.io; Raghuram, Jayanth > Cc: Liu, Wei G > Subject: RE: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. > > > [EXTERNAL EMAIL] > Can you follow this process to send this patch again? > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > And, the commit message format is > https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format > > Thanks > Liming > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Jayanth.Raghuram@dell.com > Sent: Tuesday, August 27, 2019 3:55 AM > To: devel@edk2.groups.io > Cc: Wei.G.Liu@dell.com > Subject: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. > > Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling. > Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes > function calls in InternalHstiFindAip to improve error handling. An issue was > observed on Dell Poweredge R740, where the Dell PERC H740P controller UEFI > driver returned InfoTypesBuffer = NULL, InfoTypesBufferCount = 0 and caused > an FreePool assert. > > Signed-off-by: Jayanth Raghuram > > Cc: Wei G Liu > > > Attached: 0001-MdePkg-DxeHstiLib-Added-checks-to-improve-error-hand.patch > > Regards > Jayanth Raghuram > DellEMC | Server Platform BIOS > office + 1 512 723 1470 > >