From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ankit.sinha@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Fri, 30 Aug 2019 15:41:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Aug 2019 15:41:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,447,1559545200"; d="scan'208";a="186442177" Received: from ankitsin-desk1.amr.corp.intel.com ([10.7.159.71]) by orsmga006.jf.intel.com with ESMTP; 30 Aug 2019 15:41:25 -0700 From: "Sinha, Ankit" To: devel@edk2.groups.io Cc: Michael Kubacki , Nate DeSimone Subject: [edk2-platforms] [PATCH v1 1/1] ClevoOpenBoardPkg/Features: Enable ThunderBolt Date: Fri, 30 Aug 2019 15:41:25 -0700 Message-Id: <20190830224125.26296-1-ankit.sinha@intel.com> X-Mailer: git-send-email 2.16.2.windows.1 Add Thunderbolt ACPI table and enable feature PCD Cc: Michael Kubacki Cc: Nate DeSimone Signed-off-by: Ankit Sinha --- Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec | 1 + Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc | 2 +- Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Gpe.asl | 1 - Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Platform.asl | 1 + Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl | 55 -------------------- 5 files changed, 3 insertions(+), 57 deletions(-) diff --git a/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec b/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec index 28aedfef5988..9568d80b3aa9 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec +++ b/Platform/Intel/ClevoOpenBoardPkg/OpenBoardPkg.dec @@ -20,6 +20,7 @@ PACKAGE_GUID = D04CCA80-5F71-478D-9A26-72BC751D0106 Include N1xxWU/Include Features/Tbt/Include +Features/Tbt/AcpiTables [Guids] gBoardModuleTokenSpaceGuid = {0x72d1fff7, 0xa42a, 0x4219, {0xb9, 0x95, 0x5a, 0x67, 0x53, 0x6e, 0xa4, 0x2a}} diff --git a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc index ea759776fb17..653fb0638e1d 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc +++ b/Platform/Intel/ClevoOpenBoardPkg/N1xxWU/OpenBoardPkgConfig.dsc @@ -48,7 +48,7 @@ gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable|TRUE !endif - gBoardModuleTokenSpaceGuid.PcdTbtEnable|FALSE + gBoardModuleTokenSpaceGuid.PcdTbtEnable|TRUE # # More fine granularity control below: # diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Gpe.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Gpe.asl index 8976c7a0ffcd..c95f4788e8a3 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Gpe.asl +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Gpe.asl @@ -19,7 +19,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent External(\_SB.PCI0.PEG1.HPME, MethodObj) External(\_SB.PCI0.PEG2.HPME, MethodObj) External(\_GPE.AL6F, MethodObj) - External(\_SB.THDR, MethodObj) External(\_GPE.P0L6, MethodObj) External(\_GPE.P1L6, MethodObj) External(\_GPE.P2L6, MethodObj) diff --git a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Platform.asl b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Platform.asl index 063093a08cb5..e5fa1de70035 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Platform.asl +++ b/Platform/Intel/ClevoOpenBoardPkg/Acpi/BoardAcpiDxe/Dsdt/Platform.asl @@ -73,6 +73,7 @@ External(TBFF, MethodObj) External(FFTB, MethodObj) External(SXTB, MethodObj) +include ("Tbt.asl") // Interrupt specific registers include("Itss.asl") diff --git a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl index 2efe1a54f37e..e6cd45d49911 100644 --- a/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl +++ b/Platform/Intel/ClevoOpenBoardPkg/Features/Tbt/AcpiTables/Tbt.asl @@ -868,13 +868,6 @@ Scope(\_GPE) ADBG("Notify PEG2") Notify(\_SB.PCI0.PEG2,0) } -#ifndef CPU_CFL - Case (4) - { - ADBG("Notify PEG3") - Notify(\_SB.PCI0.PEG3,0) - } -#endif } }//Switch(ToInteger(TBSS)) // TBT Selector }//If(NOHP()) @@ -1606,54 +1599,6 @@ If(LAnd(LEqual(TBTS, 1),LOr(LEqual(RPS0, 20),LEqual(RPS1, 20)))) }//End of Scope(\_SB.PCI0.RP20) } -If(LAnd(LEqual(TBTS, 1),LOr(LEqual(RPS0, 21),LEqual(RPS1, 21)))) -{ - Scope(\_SB.PCI0.PEG0) - { - Device(HRUS)// Host router Upstream port - { - Name(_ADR, 0x00000000) - - Method(_RMV) - { - Return(TARS) - } // end _RMV - } - }//End of Scope(\_SB.PCI0.PEG0) -} - -If(LAnd(LEqual(TBTS, 1),LOr(LEqual(RPS0, 22),LEqual(RPS1, 22)))) -{ - Scope(\_SB.PCI0.PEG1) - { - Device(HRUS)// Host router Upstream port - { - Name(_ADR, 0x00000000) - - Method(_RMV) - { - Return(TARS) - } // end _RMV - } - }//End of Scope(\_SB.PCI0.PEG1) -} - -If(LAnd(LEqual(TBTS, 1),LOr(LEqual(RPS0, 23),LEqual(RPS1, 23)))) -{ - Scope(\_SB.PCI0.PEG2) - { - Device(HRUS)// Host router Upstream port - { - Name(_ADR, 0x00000000) - - Method(_RMV) - { - Return(TARS) - } // end _RMV - } - }//End of Scope(\_SB.PCI0.PEG2) -} - Scope(\_SB) { // -- 2.16.2.windows.1