public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file
@ 2019-08-31 14:07 Pete Batard
  2019-09-13 17:18 ` Leif Lindholm
  0 siblings, 1 reply; 2+ messages in thread
From: Pete Batard @ 2019-08-31 14:07 UTC (permalink / raw)
  To: devel; +Cc: ard.biesheuvel, leif.lindholm

The header files are used but missing in INF, which causes
warning message when building them.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 1 +
 ArmPlatformPkg/Library/HdLcd/HdLcd.inf         | 1 +
 ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf   | 1 +
 ArmPlatformPkg/PrePi/PeiMPCore.inf             | 1 +
 ArmPlatformPkg/PrePi/PeiUniCore.inf            | 1 +
 5 files changed, 5 insertions(+)

diff --git a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
index c3f2eb03f01c..d9d9bbd30e4c 100644
--- a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
+++ b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
@@ -16,6 +16,7 @@ [Defines]
   LIBRARY_CLASS                  = LcdHwLib
 
 [Sources.common]
+  ArmMaliDp.h
   ArmMaliDp.c
 
 [Packages]
diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
index c14f387b57d0..bc80e1adea27 100644
--- a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
+++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
@@ -17,6 +17,7 @@ [Defines]
   LIBRARY_CLASS                  = LcdHwLib
 
 [Sources.common]
+  HdLcd.h
   HdLcd.c
 
 [Packages]
diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
index 8b7cc48bd60d..757348c19659 100644
--- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
+++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
@@ -16,6 +16,7 @@ [Defines]
   LIBRARY_CLASS                  = LcdHwLib
 
 [Sources.common]
+  PL111Lcd.h
   PL111Lcd.c
 
 [Packages]
diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
index 8be222893e2a..9c5da0d42a7b 100644
--- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
+++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
@@ -15,6 +15,7 @@ [Defines]
   VERSION_STRING                 = 1.0
 
 [Sources]
+  PrePi.h
   PrePi.c
   MainMPCore.c
 
diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
index 95919b784185..ee9b05b25337 100644
--- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
+++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
@@ -15,6 +15,7 @@ [Defines]
   VERSION_STRING                 = 1.0
 
 [Sources]
+  PrePi.h
   PrePi.c
   MainUniCore.c
 
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file
  2019-08-31 14:07 [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file Pete Batard
@ 2019-09-13 17:18 ` Leif Lindholm
  0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2019-09-13 17:18 UTC (permalink / raw)
  To: Pete Batard; +Cc: devel, ard.biesheuvel

On Sat, Aug 31, 2019 at 03:07:29PM +0100, Pete Batard wrote:
> The header files are used but missing in INF, which causes
> warning message when building them.
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>

Thanks for the cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 9b5a1c789d39.

> ---
>  ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 1 +
>  ArmPlatformPkg/Library/HdLcd/HdLcd.inf         | 1 +
>  ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf   | 1 +
>  ArmPlatformPkg/PrePi/PeiMPCore.inf             | 1 +
>  ArmPlatformPkg/PrePi/PeiUniCore.inf            | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> index c3f2eb03f01c..d9d9bbd30e4c 100644
> --- a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> +++ b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> @@ -16,6 +16,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  ArmMaliDp.h
>    ArmMaliDp.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> index c14f387b57d0..bc80e1adea27 100644
> --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> @@ -17,6 +17,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  HdLcd.h
>    HdLcd.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> index 8b7cc48bd60d..757348c19659 100644
> --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> @@ -16,6 +16,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  PL111Lcd.h
>    PL111Lcd.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> index 8be222893e2a..9c5da0d42a7b 100644
> --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources]
> +  PrePi.h
>    PrePi.c
>    MainMPCore.c
>  
> diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> index 95919b784185..ee9b05b25337 100644
> --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources]
> +  PrePi.h
>    PrePi.c
>    MainUniCore.c
>  
> -- 
> 2.21.0.windows.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-13 17:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-31 14:07 [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file Pete Batard
2019-09-13 17:18 ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox