From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=aSDw46aY; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: haojian.zhuang@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Mon, 02 Sep 2019 02:31:20 -0700 Received: by mail-wm1-f66.google.com with SMTP id t9so13814411wmi.5 for ; Mon, 02 Sep 2019 02:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0U9zcphwSDkdOD/SgCPJa7zETNuB+TMq8J88+W0y0zQ=; b=aSDw46aYlaKh8hnF/DT6ShCRgUIQl0dT/OAV+zEdSouy1nLxPP9uGCPV52LZNBh6r8 GJKm0Un9Zu6hwv7MmnX3Kow59Xo81lfi2DHdJFgq/gsr9PNApp6f3Abvtn7TVdQKVo66 03FbzDqTXD0HQOzuqYLBTxTAZ9TOusGk1YEa9QNgJvWP21WnoMjX46HcxO640+fBIzvk a95VuI0yR7qoAb+B8KVSyU7/UhvTyodSM54xIR1XRNUmJUDKVmV6C4qb8VkHQVYoor7t Tz8unGtwSY5mpHP37iF3jkSjEBuKSh/3NySW+j8ATKqo+UlRzORKSL6FpO0AoMA1e0B2 Y1VQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0U9zcphwSDkdOD/SgCPJa7zETNuB+TMq8J88+W0y0zQ=; b=kln8SQEeUlfVbsnDu/8Kacf85lRmglOL1ReiiBEDqFHamIyZHbCLaejenhMN3Fz5XY ZHvzRAoPwFFUaFb/y6fyDP3/H7MpDFez2wRbElBmOzJ9IbHo1Nd7DwHBp6SLoQktHfho IAhct1uNkgM/T3Y/bQX6tLmP4uRw8p9Z1t8ydrTHj8p9HAtE/FEpWgi15Qq7e6Edjm+G YaTsvQ5BFKK3+l/42ICttMOB2r5p7zOhfJ20hEnVWEalRWp6SmaODim/lSj8jrr9ZQRp DempJ1kvz1vpKT6Kh5gvLiem66Ma46No3nDap5m3PEzeMubx69djM+sm/2emkSKEtO9f uFvg== X-Gm-Message-State: APjAAAXq1yvAZCPQKhDKDLkkyiq6/FVeuyyBiQbwT4GqqM/fHym7SPrd 0asYKEyf3TeMOYpsp0E/wxRHhA== X-Google-Smtp-Source: APXvYqxFHC0gR1xlBiPg7vrDT73eyQImxLdFfX1zFMe54y6TOoBavBM/27PEGstPSfIJZXVewINc3w== X-Received: by 2002:a1c:6a0b:: with SMTP id f11mr32182923wmc.87.1567416678572; Mon, 02 Sep 2019 02:31:18 -0700 (PDT) Return-Path: Received: from hackbox2.linaro.org ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id g201sm11376742wmg.34.2019.09.02.02.31.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Sep 2019 02:31:17 -0700 (PDT) Date: Mon, 2 Sep 2019 10:31:16 +0100 From: "Haojian Zhuang" To: "Loh, Tien Hock" Cc: "leif.lindholm@linaro.org" , "ard.biesheuvel@linaro.org" , "christopher.Co@microsoft.com" , "devel@edk2.groups.io" , "thloh85@gmail.com" Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver Message-ID: <20190902093116.GA29393@hackbox2.linaro.org> References: <20190724092606.185319-1-tien.hock.loh@intel.com> <20190730073300.GH6058@gmail.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Leif, Ard, Christopher, Could you help to share the comments on this patch set? Thanks a lot. Best Regards Haojian On Thu, Aug 15, 2019 at 09:09:19AM +0000, Loh, Tien Hock wrote: > Hi Leif, Ard, Christopher, > > Haojian and I have tested the driver on 2 platforms, any further comments on this? > > Thanks > Tien Hock > > > -----Original Message----- > > From: Haojian Zhuang > > Sent: Tuesday, July 30, 2019 3:33 PM > > To: Loh, Tien Hock ; leif.lindholm@linaro.org; > > ard.biesheuvel@linaro.org; christopher.Co@microsoft.com > > Cc: devel@edk2.groups.io; thloh85@gmail.com > > Subject: Re: [PATCH v2 0/3] add DwMmcHcDxe driver > > > > On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock.loh@intel.com wrote: > > > From: "Tien Hock, Loh" > > > > > > Changelog: > > > v3: > > > * Fix an issue in NonDiscoverableDeviceDxe driver where it did not > > invalidate > > > cache before copying the memory. > > > v2: > > > *Split DwMmcHcDxe driver into two patches. One is for PlatformDwMmc > > protocol, > > > and the other is for DwMmcHcDxe driver. > > > v1: > > > *Add NonDiscoverableDeviceDxe for embedded platform. Make > > DwMmcHcDxe driver > > > to support both eMMC and SD controller. > > > > > > Haojian Zhuang (3): > > > EmbeddedPkg: add NonDiscoverableDeviceDxe driver > > > EmbeddedPkg: add PlatformDwMmc protocol > > > EmbeddedPkg/Drivers: add DwMmcHcDxe driver > > > > > > .../Drivers/DwMmcHcDxe/ComponentName.c | 214 ++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c | 1295 > > +++++++++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec | 40 + > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h | 815 ++++++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf | 69 + > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c | 2366 > > +++++++++++++++++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h | 983 +++++++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c | 1042 ++++++++ > > > EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c | 1104 ++++++++ > > > EmbeddedPkg/EmbeddedPkg.dec | 1 + > > > EmbeddedPkg/Include/Protocol/PlatformDwMmc.h | 79 + > > > .../NonDiscoverableDeviceDxe/ComponentName.c | 124 + > > > .../NonDiscoverableDeviceDxe.c | 243 ++ > > > .../NonDiscoverableDeviceDxe.inf | 52 + > > > .../NonDiscoverableDeviceIo.c | 976 +++++++ > > > .../NonDiscoverableDeviceIo.h | 92 + > > > 16 files changed, 9495 insertions(+) > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/ComponentName.c > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.c > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.dec > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.h > > > create mode 100644 > > EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHcDxe.inf > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.c > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/DwMmcHci.h > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/EmmcDevice.c > > > create mode 100644 EmbeddedPkg/Drivers/DwMmcHcDxe/SdDevice.c > > > create mode 100644 EmbeddedPkg/Include/Protocol/PlatformDwMmc.h > > > create mode 100644 > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/ComponentName.c > > > create mode 100644 > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > eDx > > > e.c create mode 100644 > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > eDx > > > e.inf create mode 100644 > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > eIo > > > .c create mode 100644 > > > > > EmbeddedPkg/Universal/NonDiscoverableDeviceDxe/NonDiscoverableDevic > > eIo > > > .h > > > > > > -- > > > 2.19.0 > > > > > > > Hi Leif, Ard & Chris, > > > > Could you help to share your comments on this patch set? > > > > Best Regards > > Haojian