From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=LEMOn+fY; spf=pass (domain: gmx.de, ip: 212.227.17.21, mailfrom: xypron.glpk@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by groups.io with SMTP; Mon, 02 Sep 2019 02:57:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1567418226; bh=inzF9r9V3+E7eSgBDf/XSKJ9Arde6v1LtiPE4Hown3Y=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=LEMOn+fYIxInvwicaQ0ywVJWWojxwWpi/L7DHPIt34LMeIHQf4B678W0BTAMWHGfP 8v3AFrRRVGXkTTfYbhZCW3WjGCz+8UDvvg+iT1Tf9tzomrINiG8X7+KiR94p7rnimk lkXgVMGJ5VICr3HRb2VWl4/BbT0GqImz1ZeXKd1g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from LT02.fritz.box ([84.118.159.3]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0MS1g6-1hca4m0POs-00TA8R; Mon, 02 Sep 2019 11:57:06 +0200 From: "Heinrich Schuchardt" To: devel@edk2.groups.io Cc: Eric Jin , Supreeth Venkatesh , Stephano Cetola , Heinrich Schuchardt Subject: [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic letters Date: Mon, 2 Sep 2019 11:56:51 +0200 Message-Id: <20190902095651.4585-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:U4XmeoOXOhWVmatlJP6IKBQhLefFT6Kj9xY82nzB67L5wxbDgdl Ymy0irzkJnV3ZaiBWHAAr8uaiHvWxua4RR84xrWDHgaJ60VOaooO3bNqboEXDgP92mNOe/O NM75/ZQKqmWxzOvih18BXya94Jg34wjLSraxzdHhW7LgtAujnt1CcqmmPIfNaF18VrZRg7r TQ9pYeVbBfwZdK/oBL6KA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:VuJRUQio/5o=:uazkzKw9PpTuZk0n8/NfoU CRI2FwmrBGZgD5p6D1FH63ustCGih0CFBHr44aCZSqgBKsfBYdHaVEz6+IQGcjqDAnsy533D9 HX5N36rHX3BWn2+Ijt3x/lTCUa0nlSsGlZ2hOUSKMuhZrRODPmLJ/tsmCRybNlko2XoIzjqv/ 5YQg5FL5pxM/sVLI9HkmwVho3HTxXni8VusyYrNNOCwKamEC6xeat8LtDcFfnEsz37fsuo8io SzxZikyX7NsgSa6jjhaxi1tb34H/d/PlHzmFX2j0wCMKwCYM1jhDqYvhiZkH+rUrfeGRtSREC 9bz88Lm6guixbFEH48/Us6CfrOPTOIdMFuZUe+vd3h1y1zhMLVpNkQnxhB2XNtkaBWF6CK66Q TCi9RFr/QYrSxhTKgzL1yX4U/XWtWjMFeZSyBdEdmVarysKftZS5OwCQf+LqxUTisl1G7I6x1 DDilOfAksrbjpPtle4NAHrmTgEtGvIHIbvjygQBjaA4Nx8bjKyMkpsObYvrLckdqmxDDF0Fob rWAHo5Im9E2dmDJDoGbq68StfiaAf4bNibWEV15+W1f6oZFrI42JUQh3YSDfLL/9Kz6qELWBN OuuEJiqQa7EJoy+zpO8FsWYMcwi5R/34t8pbb1J8oe5sx20lrKyemgp5CbKNpl/FnMnxIEQgA +1+pMVxdzoQDTLAM+wplnzhgJMRUCER7ZAaZBmyHzvJPen12EQE7HvwsUP5PsSVYLvHZlDruo gZFketQYCSBvCEMx0iSVuG17Qu8u+Dpy3V1mwZY5LnqzCENrJmEZCpw+wXHOfZHzDDkV4qhB3 mXJLtUiZ0d0dd45WmOgzabm2AgMrERUmpvmJ4v6TqD6p6UqH1xSJQ6Z7STT/4EM5/7t3omBjQ jC6NR5f7wxOIz2EQasXCmb2zcHJ8r+v23KAUFMEleQa3b0HX6InnLzPCPAxqWS+h+nkP2yl5K T7I/rWCI4e7XJHFMUOJoO06UtFYoyc3MjKnuX/S0dBzDyIXLUlMCy+nJbwpvDxopKc75PsoQI 9cVQkN40A0/ZV/fIlkEhdIBCfLJ3FAsSOfsoQJFJI+dL2KJpRcyKQO2z35KnLXrXJvaIlBEpC QemIZJGH4p1Ypi91e7Gm6yjQuYQVRAqCapg7DJfLKXEFhErnPNx2/U/VU+poL59vp1siEmpUw RVgtZdEBLed7AuuxkzKESK8fNyMs56IXR7tFsu++CrwuiecA== Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1911 The test of StrUpr() of the UnicodeCollationProtocol2 uses the following test string: L"\x30\x50[A-D]\x40\x20\x30\x50f\x40\x20" This string contains the Unicode code point 0x050f (CYRILLIC SMALL LETTER KOMI TJE). The correct conversion to upper case is 0x050e (CYRILLIC CAPITAL LETTER KOMI TJE). The SCT code uses function ToUpper() which is not a part of the SCT code itself for the verification. As the EDK2 implementation of StrUpr() does not support upper-casing cyrillic letters it does not convert 0x050f but leaves it unchanged. This leads to rejecting the output of UEFI implementations fully supporting cyrillic letters. Replace cyrillic 0x50f by 0x50 ('P') to avoid false positives. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/UnicodeCollation2BBTestFunction.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/B= lackBoxTest/UnicodeCollation2BBTestFunction.c b/uefi-sct/SctPkg/TestCase/UE= FI/EFI/Protocol/UnicodeCollation2/BlackBoxTest/UnicodeCollation2BBTestFunct= ion.c index a8652a5c..653b263a 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBox= Test/UnicodeCollation2BBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/UnicodeCollation2/BlackBox= Test/UnicodeCollation2BBTestFunction.c @@ -451,7 +451,7 @@ BBTestStrUprFunctionAutoTest ( CHAR16 *TestData[] =3D{=0D L"\x21\x22\x31\x32\x41\x42\x4= 3\x44\x45\x46\x47\x48\x49\x4A\x4B\x4C\x4D\x4E\x4F\x50\x51\x52\x53\x54\x55\x= 56\x57\x58\x59\x5Ax61\x62\x7D\x7E",=0D L"\x30\x50[abcdzyxw!)(@#*]\x4= 0\x20\x30\x50\ab\x40\x20",=0D - L"\x30\x50[A-D]\x40\x20\x30\x= 50f\x40\x20",=0D + L"\x30\x50[A-D]\x40\x20\x30\x= 50\x40\x20",=0D L""=0D };=0D =0D --=20 2.20.1