From: "Zhang, Shenglei" <shenglei.zhang@intel.com>
To: devel@edk2.groups.io
Cc: Michael Kubacki <michael.a.kubacki@intel.com>,
Sai Chaganty <rangasai.v.chaganty@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [PATCH] AdvancedFeaturePkg/BmcElog: Change arithmetic logic
Date: Mon, 2 Sep 2019 20:05:13 +0800 [thread overview]
Message-ID: <20190902120514.18028-1-shenglei.zhang@intel.com> (raw)
Change the value from "sizeof(UINT8)" to 1 in the arithmetic expression.
The original value added to (UINT8 *)&GetBmcGlobalEnables is
(sizeof(UINT8)*sizeof(UINT8)) which equals to 1, so the functionality
looks right. But the arithmetic logic is actually wrong.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
index 421fbdec..beaa3fa0 100644
--- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
+++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c
@@ -131,7 +131,7 @@ Returns:
ElogStat = 1;
}
- CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + sizeof(UINT8), sizeof(UINT8));
+ CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + 1, sizeof(UINT8));
SetBmcGlobalEnables.SetEnables.Bits.SystemEventLogging = ElogStat;
Status = IpmiSetBmcGlobalEnables (&SetBmcGlobalEnables, &CompletionCode);
--
2.18.0.windows.1
next reply other threads:[~2019-09-02 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-02 12:05 Zhang, Shenglei [this message]
2019-09-02 12:05 ` [PATCH] AdvancedFeaturePkg/BmcElog: Initialize ClearSelResponse Zhang, Shenglei
2019-09-16 5:11 ` [edk2-devel] " Liming Gao
2019-09-16 5:11 ` [edk2-devel] [PATCH] AdvancedFeaturePkg/BmcElog: Change arithmetic logic Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902120514.18028-1-shenglei.zhang@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox