From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: shenglei.zhang@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Mon, 02 Sep 2019 05:05:18 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 05:05:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; d="scan'208";a="186985426" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 02 Sep 2019 05:05:16 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Michael Kubacki , Sai Chaganty , Liming Gao Subject: [PATCH] AdvancedFeaturePkg/BmcElog: Change arithmetic logic Date: Mon, 2 Sep 2019 20:05:13 +0800 Message-Id: <20190902120514.18028-1-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 Change the value from "sizeof(UINT8)" to 1 in the arithmetic expression. The original value added to (UINT8 *)&GetBmcGlobalEnables is (sizeof(UINT8)*sizeof(UINT8)) which equals to 1, so the functionality looks right. But the arithmetic logic is actually wrong. Cc: Michael Kubacki Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Shenglei Zhang --- Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c index 421fbdec..beaa3fa0 100644 --- a/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c +++ b/Platform/Intel/AdvancedFeaturePkg/Ipmi/BmcElog/BmcElog.c @@ -131,7 +131,7 @@ Returns: ElogStat = 1; } - CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + sizeof(UINT8), sizeof(UINT8)); + CopyMem (&SetBmcGlobalEnables, (UINT8 *)&GetBmcGlobalEnables + 1, sizeof(UINT8)); SetBmcGlobalEnables.SetEnables.Bits.SystemEventLogging = ElogStat; Status = IpmiSetBmcGlobalEnables (&SetBmcGlobalEnables, &CompletionCode); -- 2.18.0.windows.1