From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: shenglei.zhang@intel.com) Received: from mga06.intel.com (mga06.intel.com []) by groups.io with SMTP; Mon, 02 Sep 2019 05:34:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Sep 2019 05:34:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,459,1559545200"; d="scan'208";a="186990346" Received: from shenglei-dev.ccr.corp.intel.com ([10.239.158.52]) by orsmga006.jf.intel.com with ESMTP; 02 Sep 2019 05:34:55 -0700 From: "Zhang, Shenglei" To: devel@edk2.groups.io Cc: Michael Kubacki , Chasel Chiu , Nate DeSimone , Liming Gao Subject: [PATCH] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL Date: Mon, 2 Sep 2019 20:34:50 +0800 Message-Id: <20190902123452.27716-2-shenglei.zhang@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 In-Reply-To: <20190902123452.27716-1-shenglei.zhang@intel.com> References: <20190902123452.27716-1-shenglei.zhang@intel.com> Currently there is no check for the parameter OutTable. So add the logic that return value EFI_INVALID_PARAMETER when the OutTable is NULL. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .../Test/Library/TestPointCheckLib/DxeCheckAcpi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c index 263781a2..3828ab72 100644 --- a/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c +++ b/Platform/Intel/MinPlatformPkg/Test/Library/TestPointCheckLib/DxeCheckAcpi.c @@ -611,6 +611,9 @@ DumpAcpiRsdt ( if (OutTable != NULL) { *OutTable = NULL; } + else{ + return EFI_INVALID_PARAMETER; + } ReturnStatus = EFI_SUCCESS; EntryCount = (Rsdt->Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) / sizeof(UINT32); @@ -664,6 +667,9 @@ DumpAcpiXsdt ( if (OutTable != NULL) { *OutTable = NULL; } + else{ + return EFI_INVALID_PARAMETER; + } ReturnStatus = EFI_SUCCESS; EntryCount = (Xsdt->Length - sizeof (EFI_ACPI_DESCRIPTION_HEADER)) / sizeof(UINT64); -- 2.18.0.windows.1