From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: dandan.bi@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 04 Sep 2019 01:24:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 01:24:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,465,1559545200"; d="scan'208";a="187548711" Received: from shwdeopenpsi114.ccr.corp.intel.com ([10.239.157.147]) by orsmga006.jf.intel.com with ESMTP; 04 Sep 2019 01:24:22 -0700 From: "Dandan Bi" To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Jian J Wang , Hao A Wu , Ray Ni , Liming Gao , Zhichao Gao Subject: [patch 0/3] Unload image on EFI_SECURITY_VIOLATION Date: Wed, 4 Sep 2019 16:23:58 +0800 Message-Id: <20190904082401.6868-1-dandan.bi@intel.com> X-Mailer: git-send-email 2.18.0.windows.1 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1992 For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, the Image was loaded and an ImageHandle was created with a valid EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. This follows UEFI Spec. But if the caller of LoadImage() doesn't have the option to defer the execution of an image, we can not treat EFI_SECURITY_VIOLATION like any other LoadImage() error, we should unload image for the EFI_SECURITY_VIOLATION to avoid resource leak. This patch is to do error handling for EFI_SECURITY_VIOLATION explicitly for the callers in edk2 which don't have the policy to defer the execution of the image. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Liming Gao Cc: Zhichao Gao Dandan Bi (3): EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION MdeModulePkg: Unload image on EFI_SECURITY_VIOLATION ShellPkg: Unload image on EFI_SECURITY_VIOLATION .../AndroidFastboot/Arm/BootAndroidBootImg.c | 9 +++++++++ .../Library/AndroidBootImgLib/AndroidBootImgLib.c | 12 ++++++++++++ MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 9 +++++++++ .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 9 +++++++++ MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c | 9 +++++++++ .../Library/UefiBootManagerLib/BmLoadOption.c | 11 ++++++++++- MdeModulePkg/Library/UefiBootManagerLib/BmMisc.c | 11 ++++++++++- .../PlatformDriOverrideDxe/PlatDriOverrideLib.c | 11 ++++++++++- ShellPkg/Application/Shell/ShellManParser.c | 9 +++++++++ .../Library/UefiShellDebug1CommandsLib/LoadPciRom.c | 11 ++++++++++- ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c | 11 ++++++++++- 11 files changed, 107 insertions(+), 5 deletions(-) -- 2.18.0.windows.1