From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=YUeI7bxh; spf=pass (domain: linaro.org, ip: 209.85.221.44, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by groups.io with SMTP; Wed, 04 Sep 2019 01:38:14 -0700 Received: by mail-wr1-f44.google.com with SMTP id l11so11437832wrx.5 for ; Wed, 04 Sep 2019 01:38:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OGQ/vDV8tcDgOVoxlxA+HdVtQeSUH3HxATdqQ3EQdmY=; b=YUeI7bxhqhPcCp1k5uZByzilWaLrBtioS3Jqz8YBXVKNsaCbVkOA2CNPNnpdpZcFEE /Wg3PWGR8sAv+2D4iNfOTK/+dxRocy6dIMWNeZBEYgC+30x7tK464Lp9nyVNHDVWnJ3J tHK+yXRBy+UdosI2Se7OgcHeugecNYNZ9Ea8/GCIlfMUTz0HioM4R1yudr8o8hbvTKcH QcPqPUkm9ZsmG0vjqJi1f5caAOjIL25qpNtlFEX0F/akKZJGyRB9N/ju+BuSmDyv4dO6 Aydb564aBVjmlc1LnctcTsgGykkJtkzRvAsBr+1ecM9X6qzZvCnAXhiwpQ79ESNAOVPf PnyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OGQ/vDV8tcDgOVoxlxA+HdVtQeSUH3HxATdqQ3EQdmY=; b=a+v1Xp+dK+Nn90gO960CCSXZ/ce0PMq7SIWdJJAOsnBILCIDsXL0R6TbpbBODK5Cvn vgccTXwmXA625bgWyqUbUbo2vfkMBluB6PuSYhhSolSRzINatgPlhZVvvOhQV9reRlnp zqW5hLNS5JarQJ5BTizaeUx5YrcG1GR/Sv9Bz9fGbrbOQ+R6P37x7C3gcOqQcIpVbN2q jan49TVyeQIrVAwdTlM6yhzGukgJkueCx4UxlrxH8K9ehWEW4qyNQpZqigh2sRkC4EXm HK3eAuo8xnJ5BH+aQwbPpqJjYgBRe3Ipj+DOp7F8W07qgDYPdOkT20RDy1HPSFcAYzVB bEmQ== X-Gm-Message-State: APjAAAVzP9eb1BbAF32UNRmWrQwqXK+gDIksQ4RSfiC5kIzsOikrVMET 4kK0QPX/Nv2h0zmRMDlhOXgg0A== X-Google-Smtp-Source: APXvYqyllUqVT/y4HGS4qyARjArCtrtjs3kuAklxqD5mUwbxiLhufJz0fg9PI1jWhp76XWSApKRb5g== X-Received: by 2002:a5d:6288:: with SMTP id k8mr4083641wru.209.1567586292557; Wed, 04 Sep 2019 01:38:12 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id q25sm2008437wmj.22.2019.09.04.01.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 01:38:11 -0700 (PDT) Date: Wed, 4 Sep 2019 09:38:10 +0100 From: "Leif Lindholm" To: "Feng, Bob C" Cc: "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption Message-ID: <20190904083810.GD29255@bivouac.eciton.net> References: <20190129020610.14300-1-bob.c.feng@intel.com> <20190129020610.14300-33-bob.c.feng@intel.com> <20190902190211.GZ29255@bivouac.eciton.net> <20190902190438.GA29255@bivouac.eciton.net> <08650203BA1BD64D8AD9B6D5D74A85D16152FF60@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D16152FF60@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Bob, On Wed, Sep 04, 2019 at 02:10:23AM +0000, Feng, Bob C wrote: > Hi Leif, >=20 > I have no Debian environment. On Debian, can python3 work with > antlr3? Yes. The below is equivalent to what I have already done. Can you please respond to the question I asked about the API version error I see when I then try to run it, included in my original email? Best Regards, Leif > I checked the antlr3 python github repository, the source code is still = in beta version and has not been updated for 7 years. >=20 > But If yes, I think the import statement in ECC can be changed as: > try: > import antlr4 as antlr > from Ecc.CParser4.CLexer import CLexer > from Ecc.CParser4.CParser import CParser > except: > import antlr3 as antlr > antlr.InputStream =3D antlr.StringStream > from Ecc.CParser3.CLexer import CLexer > from Ecc.CParser3.CParser import CParser=20 >=20 >=20 > Thanks, > Bob >=20 >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Le= if Lindholm > Sent: Tuesday, September 3, 2019 3:05 AM > To: Feng, Bob C > Cc: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Pytho= n3 adaption >=20 > Argh - forgot about the mailing list move, forwarding to current list. >=20 > / > Leif >=20 > On Mon, Sep 02, 2019 at 08:02:11PM +0100, Leif Lindholm wrote: > > Hi Bob, > >=20 > > I was running Ecc today, apparently for the first time since I=20 > > switched to Python3 by default. > >=20 > > I have raised https://bugzilla.tianocore.org/show_bug.cgi?id=3D2148 ov= er=20 > > the way Python3 hard codes use of antlr4, whereas it seems to me it=20 > > should be possible to ue Python3 with antlr3 (but not Python2 with=20 > > antlr4). > >=20 > > However, whilst that issue could be looked at without extreme urgency,= = =20 > > I am curious as to what is causing the error I am seeing upon working= =20 > > around the import failure on my Debian installation (which lacks=20 > > python3-antlr4). > >=20 > > The output I get when running > > $ Ecc -t /work/git/edk2/EmbeddedPkg/Drivers/DtPlatformDxe/ -s > >=20 > > is > >=20 > > --- > > /work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py:409: Deprecation= Warning: time.clock has been deprecated in Python 3.3 and will be removed f= rom Python 3.8: use time.perf_counter or time.process_time instead > > StartTime =3D time.clock() > > 11:44:43, Sep.02 2019 [00:00] > >=20 > > Loading ECC configuration ... done > > Building database for Meta Data File Done! > > Parsing=20 > > //work/git/edk2/EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c > > Traceback (most recent call last): > > File "/usr/lib/python3.7/runpy.py", line 193, in _run_module_as_main > > "__main__", mod_spec) > > File "/usr/lib/python3.7/runpy.py", line 85, in _run_code > > exec(code, run_globals) > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 4= 10, in > > Ecc =3D Ecc() > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 9= 4, in __init__ > > self.DetectOnlyScanDirs() > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 1= 30, in DetectOnlyScanDirs > > self.BuildDatabase() > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/EccMain.py", line 1= 50, in BuildDatabase > > c.CollectSourceCodeDataIntoDB(EccGlobalData.gTarget) > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/c.py", line 526, in= CollectSourceCodeDataIntoDB > > collector.ParseFile() > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/CodeFragmentCollect= or.py", line 517, in ParseFile > > lexer =3D CLexer(cStream) > > File "/work/git/edk2/BaseTools/Source/Python/Ecc/CParser3/CLexer.py"= , line 147, in __init__ > > Lexer.__init__(self, input) > > File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 10= 39, in __init__ > > BaseRecognizer.__init__(self, state) > > File "/usr/lib/python3/dist-packages/antlr3/recognizers.py", line 16= 9, in __init__ > > .format(self.api_version)) > > RuntimeError: ANTLR version mismatch: The recognizer has been generate= d with API V0, but this runtime does not support this. > > --- > >=20 > > Any idea? > >=20 > > Best Regards, > >=20 > > Leif > >=20 > > On Tue, Jan 29, 2019 at 10:06:09AM +0800, Feng, Bob C wrote: > > > v2: > > > The python files under CParser4 are generated by antlr4 and for > > > python3 usage. They have python3 specific syntax, for example the=20 > > > data type declaration for the arguments of a function. That is not= =20 > > > compitable with python2. this patch is to remove these syntax. > > >=20 > > > ECC tool Python3 adaption. > > >=20 > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > Signed-off-by: Bob Feng > > > Cc: Liming Gao > > > --- > > > BaseTools/Source/Python/Ecc/{ =3D> CParser3}/CLexer.py | 0 > > > BaseTools/Source/Python/Ecc/{ =3D> CParser3}/CParser.py | 0 > > > BaseTools/Source/Python/Ecc/CParser3/__init__.py | 0 > > > BaseTools/Source/Python/Ecc/CParser4/C.g4 | 637 ++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > BaseTools/Source/Python/Ecc/CParser4/CLexer.py | 632 ++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++ > > > BaseTools/Source/Python/Ecc/CParser4/CListener.py | 815 ++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++ > > > BaseTools/Source/Python/Ecc/CParser4/CParser.py | 6279 ++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++++++++++++++++++++ > > > + > > > BaseTools/Source/Python/Ecc/CParser4/__init__.py | 0 > > > BaseTools/Source/Python/Ecc/Check.py | 4 +- > > > BaseTools/Source/Python/Ecc/CodeFragmentCollector.py | 20 +-- > > > BaseTools/Source/Python/Ecc/Configuration.py | 3 - > > > BaseTools/Source/Python/Ecc/EccMain.py | 2 +- > > > BaseTools/Source/Python/Ecc/EccToolError.py | 4 +- > > > BaseTools/Source/Python/Ecc/FileProfile.py | 2 +- > > > BaseTools/Source/Python/Ecc/MetaDataParser.py | 2 +- > > > BaseTools/Source/Python/Ecc/c.py | 6 +- > > > BaseTools/Source/Python/Ecc/config.ini | 2 - > > > 17 files changed, 8385 insertions(+), 23 deletions(-) >=20 >=20 >=20