From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=GfWpDr9m; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 04 Sep 2019 10:51:34 -0700 Received: by mail-wr1-f66.google.com with SMTP id g7so22262628wrx.2 for ; Wed, 04 Sep 2019 10:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PmrHW16Dd4ltP1t2wY6BriD/tWYcvHsZXygydNMoaoY=; b=GfWpDr9mJqGlg7cdq6p7yM685oJMNUsUyCclIXH6c2NpIkhsbK35g7eT+Sc9uQt2Xe 7GGJoyDqWuu87Upmfu53KIvYy6qcFefEvrE8DahR0Au/fQUtlgxVZzUkDLEePKgOBPpz 08N5EbvwK8VsTYNAIyovRwktOndh5JAgTqBSIlanod3/6z/jsYxZTjOgcpJSqZR1FBkN H+LuSfitPMFKEk3KUVPdwp/5K0JqTg3VSlcdDArPhpLhzUbmd2aXYh40676YUDqOCOvU rsWCZ+5EmB0ihSnV7+UIqz99G3Exm3bNrUohOjrKtyieQmaToxgKQLpFc7f+UC57On3A VyRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PmrHW16Dd4ltP1t2wY6BriD/tWYcvHsZXygydNMoaoY=; b=WRJiOznuBkuT95lrYVOgcr+0OI2BqndU5Rj2vgGbBKs9OuHhA8l42IzpsXbUeDYtmp G4FakhjCnFMKgIk8ahSQ2dv08aV8e5iCfI3pVzEmf/HsVKPlEuIVzy53GlUuQx++z6X0 rAVb3zcu5tNH2Gc9AYYXFZtcQHingnEMyi2qFiE2EnImbQzoxOuoa0YWObIs+C6LB4qR /8UiPb+z2ONiKmWd2nBORDhwZ+gJlmF5HMnrimUphg3nrOWITMVHPK33hi3tJ5csyu6K B9rTTem4vakYcu3Y7NylepUlW2CnVY5hes1oaoFdJXmro3iZ3JdSYYAirL4MwTgHZYSg RkyQ== X-Gm-Message-State: APjAAAWwKGnIsVyFP8s9ANdTKj1So+f4nge/womaDBcXaU0Odl8xdx1H yHmYlDkP1LjSOo4bT+lPPJ1dlGZ6KeI= X-Google-Smtp-Source: APXvYqwVj2OxB3QOxWBNs7Va1D4ms8oMLj9c149TyhLfAjT17nUfCcVEb1R57NI5TCgM8kg0eRQHwQ== X-Received: by 2002:adf:dfc5:: with SMTP id q5mr51827745wrn.142.1567619492229; Wed, 04 Sep 2019 10:51:32 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o25sm3346637wmc.36.2019.09.04.10.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Sep 2019 10:51:31 -0700 (PDT) Date: Wed, 4 Sep 2019 18:51:29 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Message-ID: <20190904175129.GO29255@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1567593797-26216-2-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Abner, On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote: > - Add RiscVPkg package which provides RISC-V processor related drivers and libraries. > - Support RISC-V OpenSBI and RISC-V platforms > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > RiscVPkg/RiscVPkg.dec | 57 +++++++++++++++++++++++++++++++++++++++++++++ > RiscVPkg/RiscVPkg.uni | Bin 0 -> 1718 bytes > RiscVPkg/RiscVPkgExtra.uni | Bin 0 -> 1374 bytes > 3 files changed, 57 insertions(+) > create mode 100644 RiscVPkg/RiscVPkg.dec > create mode 100644 RiscVPkg/RiscVPkg.uni > create mode 100644 RiscVPkg/RiscVPkgExtra.uni > > diff --git a/RiscVPkg/RiscVPkg.dec b/RiscVPkg/RiscVPkg.dec > new file mode 100644 > index 0000000..acf71fe > --- /dev/null > +++ b/RiscVPkg/RiscVPkg.dec > @@ -0,0 +1,57 @@ > +## @file RiscVPkg.dec > +# This Package provides UEFI RISC-V modules and libraries. > +# > +# Copyright (c) 2016 - 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# > +# This program and the accompanying materials are licensed and made available under > +# the terms and conditions of the BSD License which accompanies this distribution. > +# The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +## > + > +[Defines] > + DEC_SPECIFICATION = 0x00010005 > + PACKAGE_NAME = RiscVPkg > + PACKAGE_UNI_FILE = RiscVPkg.uni > + PACKAGE_GUID = 993C7CAC-C87C-4F08-A2CF-AD3AABA859D1 > + PACKAGE_VERSION = 0.1 > + > +[Includes] > + Include > + opensbi/include > + opensbi/lib/utils/libfdt This one is something we need to sort out (together). Having multiple copies of libfdt in the tree is not on. I personally think we need a longer-term encapsulation of libfdt that doesn't mess up the coding style. But until then, I would be much happier if you used the half measure we have in EmbeddedPkg: EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. > + > +[LibraryClasses] > + > +[LibraryClasses.RISCV32, LibraryClasses.RISCV64] > + > +[Guids] > + gUefiRiscVPkgTokenSpaceGuid = { 0x4261e9c8, 0x52c0, 0x4b34, { 0x85, 0x3d, 0x48, 0x46, 0xea, 0xd3, 0xb7, 0x2c}} > + gUefiRiscVMachineContextGuid = { 0xdad19cd5, 0x9d1f, 0x4f38, { 0xbc, 0xba, 0x10, 0x81, 0xe4, 0xcd, 0xb7, 0x3f}} > + > +[PcdsFixedAtBuild] > + # Processor Specific Data GUID HOB GUID > + gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSpecificDataGuidHobGuid|{0x20, 0x72, 0xD5, 0x2F, 0xCF, 0x3C, 0x4C, 0xBC, 0xB1, 0x65, 0x94, 0x90, 0xDC, 0xF2, 0xFA, 0x93}|VOID*|0x00001000 > + gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosGuidHobGuid|{0x0F, 0x34, 0x00, 0x92, 0x04, 0x12, 0x45, 0x4A, 0x9C, 0x11, 0xB8, 0x8B, 0xDF, 0xC6, 0xFA, 0x6F}|VOID*|0x00001001 > + gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosType4GuidHobGuid|{0x5B, 0x36, 0xEA, 0x23, 0x79, 0x6D, 0x4F, 0xCF, 0x9C, 0x22, 0x25, 0xC0, 0x89, 0x8C, 0x25, 0xB9}|VOID*|0x00001002 > + gUefiRiscVPkgTokenSpaceGuid.PcdProcessorSmbiosType7GuidHobGuid|{0xBF, 0xB4, 0x6D, 0x1B, 0x7E, 0x10, 0x47, 0x44, 0xB8, 0xBD, 0xFF, 0x1E, 0xDD, 0xDF, 0x71, 0x65}|VOID*|0x00001003 > + > + > + # > + # 1000000000 > + # PcdRiscVMachineTimerTickInNanoSecond = --------------------------------------- > + # PcdRiscVMachineTimerFrequencyInHerz > + # > + gUefiRiscVPkgTokenSpaceGuid.PcdRiscVMachineTimerTickInNanoSecond|100|UINT64|0x00001010 > + gUefiRiscVPkgTokenSpaceGuid.PcdRiscVMachineTimerFrequencyInHerz|10000000|UINT64|0x00001011 My personal preference would be for these Pcds to be included with the specific commits that add use of them. > + > +[PcdsPatchableInModule] > + > +[PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > + > +[UserExtensions.TianoCore."ExtraFiles"] > + RiscVPkgExtra.uni > diff --git a/RiscVPkg/RiscVPkg.uni b/RiscVPkg/RiscVPkg.uni > new file mode 100644 > index 0000000000000000000000000000000000000000..550e30d5c9e5db4091e4ba5090e38413a5c69393 > GIT binary patch I think we're happy taking .uni files as UTF-8 these days - this greatly simplifies documentation review. Regards, Leif > literal 1718 > zcmchXNpBND5QXcE#D8cx7eI*(95^6^h~r7H5@O2>fm1ZL6K8}SqqZ@a9}j%5dloy1 > z1Sd3_UTb;vs;YngYFNV@|1&;k@9f$#o7t5;wnv=mu4irQ+mRjEM|NFHZERl{r${+F > zvjzJUoy>l6GU2RmEA#Acky)}&S?T-;*<0?e!dNeTRK6tf)iyzUYB$I_dxHI^%rEV^ > zy|7od&-y(!z6YGEAXB08!Bdj^@mLd*Wx(2ET=UO@mpLn;Q4C$HGaqs@W0pqrF7zHb > z>HDBNLGq0?Vdd=u_y=H?Hy8Xau;Ph+&c5Jag@kw$i(_!ik<{HL=gV=D29AV6yha9v > z!m-QH5^f<9r-fZ)a?*2-dPBSz_cLqoT|#O&}9ktiP?uiKdtGHGN;Wnrz`1=UgM > zHOX^}{n-vCM_$CinDKs;8NOsmz9Ucav1G4kN8l{{Rn_54tSX9Y?qi08`3JIhG41jb > zx!fQ%%JmmH6GFDy;zE_SA``De&8r3@$CCGf@jB6a^4YkPgC!>;BAC!0yWZ > zyIKvX-~?P<>ZoHUjEDAty*kaos^&rHyrvCVC4uRooiit#i<4-f%0ip|N|5LW%N zXpJ>y*_G8Ab2IF<+uuTW!M&_@f=6c;Nc94;bI#jXm5omD-eV{1I+M= zynkjsINMv>U3(oSW)4HsSNN zA-tS2o?z{gS&ZpU=K~}k{`SbGdTUAr6mOks;sADpw1#C*O{}R~b=H!zAs&uF?Y25w > z^;~q}?n^pHdlD)-Y8RcXDjH!s<&XVRD Pm-YX|Ux)1?&zk=L?rRDP > > literal 0 > HcmV?d00001 > > diff --git a/RiscVPkg/RiscVPkgExtra.uni b/RiscVPkg/RiscVPkgExtra.uni > new file mode 100644 > index 0000000000000000000000000000000000000000..64235949b742be811c22776aaa6b76741e8e68d6 > GIT binary patch > literal 1374 > zcmZvcNpBND5QXcE#D8d+3!uaX4jd3d*zu593Gv8wSWc0bEF zxvQ(Xme;SU=g;qsbu93I&M(+|yR^)fc43e05mudzY+z$MuzmZ4mfF zMxPRs*)J>$Y-1}dN58>mgFa;^`vJZ;oL%_Zu4^>4 zYujUgM2;Vhvv8jVRqmCNvQADmA=x z>;liX)`OLI|G_^2v#JHJyCzG{?N{g(2L&GDO)SpAvBFbl+mf$ zh!Sog5~o#OMJ>wAckI>0sm)jwcT0p$^BQxYMns~1 z`{*Y-m;!wf2XoecZ<$d`nN&OSq#7G^-F61fs$Mf4!NjU=amjh?kTCzm_aUZTej=A! > zyk=$mx@1DgihEpW(h559#%EqL7&(@I?u@s&eNI0+4|=e{GUEmd-p6kBHd(IuSJPcd > z-RH;>P^C=K&<C@6YNcfrUwIFSAxgbGY{Emp0&1+ > z%B!p`WY2YJdo{LTpE(z z5puoTq^uHek=U0yPm_HB7b#Pvntfhd#aktVf2%rfm+eVCKlm%;YOLkMTjOrW6 > y+J&iO)3ijhIWXMtN?L@e8L(*oPG%luwI%n%TL35A}MR?_sM(CC|Utz|=+n > > literal 0 > HcmV?d00001 > > -- > 2.7.4 > > > >