From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ehs8wINY; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 05 Sep 2019 07:42:30 -0700 Received: by mail-wm1-f67.google.com with SMTP id t17so3127799wmi.2 for ; Thu, 05 Sep 2019 07:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jw/Y6PE9P93RZSi7zDTeuANiHhtJQXg4RRF1qF9xl2M=; b=ehs8wINYNjA4lMwvRKEq/bJIGCC8sPd03nLgtvdeubRkq5Q4xQcmbXEEyHsTs76sxZ 12KqFhxmdIce6Yf9JK6RaZjPrrFJhXH9inyLPXeErBmiQ8REXD5UJFRpqr5HWTcs2eGJ SxfjRH+1RIV8Bfk4BpasoLKi36gq6ohI69PVEggLYbYNy9Ruls2r9YLScO8fr36CiIFe 0oi5IUZgDA7Zz9syjD/hhv9dZeO9anaM2CUuNql0NIj84I1LAWqmlYHfutsOeBHdiRzB jQ9T/xRQr/Do/2cSs9rIdbiQjoh9t81U6sfyrcc2DF+ZRqLwD0Sk1by5B5zcPsu25W4e fBeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jw/Y6PE9P93RZSi7zDTeuANiHhtJQXg4RRF1qF9xl2M=; b=N4XjmNaQIftVgLpxsfRdY7GDvWz5YrKUbhqX4a+wzCfAH80DmgmF9fMuITdwp0sxA7 aK83z8NfR4ZwXyTegDlMJXupbxgVVKKVWyRvD2BXCIH1fSY/MBGa6I44a4ODkA8qo49G UzSRMxjLNkyj0ADMd+0zOVrD3bdpzgkRMq3K76slohGWBvJChgtKszwG4UIqBruQH6ch 5KPPoFqqLXAwYeSqeMQkmAy0QUcMR21SbYYuqXdoDc7ZRHUh27BBT6buaRHN9eMFghXm 7dkH0Z0xKrWO8XgWVb5J1sxQoeuP4p4oUCrZ7eZ2NZCBw/IGYTXqvZ2Hds/52Pu7NPe7 Ar1g== X-Gm-Message-State: APjAAAVR2GkCnDQ1ICkLpeZfkyDeTmn91K/8HnSQlcbfY6zlW1bH/TN0 4cdJxh91JIuK6JDWTl8/puUZqepCxBw= X-Google-Smtp-Source: APXvYqykX38pbKDTIpN18fG0kt6a3ihbJkJVHz1EErzjvMB8h2HajdQ1oMlYyPD3aRBL9VAni7kI8A== X-Received: by 2002:a1c:6c19:: with SMTP id h25mr3100647wmc.64.1567694548756; Thu, 05 Sep 2019 07:42:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f6sm5195275wrh.30.2019.09.05.07.42.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 07:42:28 -0700 (PDT) Date: Thu, 5 Sep 2019 15:42:26 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 09/22]: MdePkg/BaseCpuLib: RISC-V Base CPU library implementation. Message-ID: <20190905144226.GA29255@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-10-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1567593797-26216-10-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 04, 2019 at 06:43:04PM +0800, Abner Chang wrote: > Implement RISC-V CPU related functions in BaseCpuLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 Apart from the CLA and the License of the new file, this one looks fine to me. / Leif > Signed-off-by: Abner Chang > --- > MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 4 ++++ > MdePkg/Library/BaseCpuLib/RiscV/Cpu.s | 25 +++++++++++++++++++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 MdePkg/Library/BaseCpuLib/RiscV/Cpu.s > > diff --git a/MdePkg/Library/BaseCpuLib/BaseCpuLib.inf b/MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > index a7cb381..20ee774 100644 > --- a/MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > +++ b/MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > @@ -7,6 +7,7 @@ > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> # Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> # Portions copyright (c) 2011 - 2013, ARM Ltd. All rights reserved.
> +# Copyright (c) 2016, Hewlett Packard Enterprise Development LP. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -59,6 +60,9 @@ > AArch64/CpuFlushTlb.asm | MSFT > AArch64/CpuSleep.asm | MSFT > > +[Sources.RISCV64] > + RiscV/Cpu.s > + > [Packages] > MdePkg/MdePkg.dec > > diff --git a/MdePkg/Library/BaseCpuLib/RiscV/Cpu.s b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.s > new file mode 100644 > index 0000000..9a1bf0f > --- /dev/null > +++ b/MdePkg/Library/BaseCpuLib/RiscV/Cpu.s > @@ -0,0 +1,25 @@ > +//------------------------------------------------------------------------------ > +// > +// CpuSleep for RISC-V > +// > +// Copyright (c) 2016, Hewlett Packard Enterprise Development LP. All rights reserved.
> +// This program and the accompanying materials > +// are licensed and made available under the terms and conditions of the BSD License > +// which accompanies this distribution. The full text of the license may be found at > +// http://opensource.org/licenses/bsd-license.php. > +// > +// THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +// WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +// > +//------------------------------------------------------------------------------ > +.data > +.align 3 > +.section .text > + > +.global ASM_PFX(_CpuSleep) > + > +ASM_PFX(_CpuSleep): > + wfi > + ret > + > + > -- > 2.7.4 > > > >