From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=cCfWamG1; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 05 Sep 2019 07:51:53 -0700 Received: by mail-wr1-f68.google.com with SMTP id 30so3111380wrk.11 for ; Thu, 05 Sep 2019 07:51:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rKN7Z98zl2A76WtSI12wVfEViVp755LqDddyaZae7+s=; b=cCfWamG1P+QpeQjbONdJItQEmLTwoWArEPtg0WZ3UiHWWDU7OBBXlkcV9nV0EaTJgt ULdRi4R6bqktK2BZhYVf0hPi990/0m+b0djcB6z34e44FgkxX8q5WEUaqOnzYtRSsxhY 0eMM5U0QHPwVoomjUUWyDa0hl39JI3BpycLslSaZqnqrnZXI3PqAe6MauBYnVf0FxFsb mTK1SePRYGDIWJVukN6p16frG0mGwFdLwmfoh/YAZWTFTbfV6kMZVn6cAEsKIni8t9zQ X8XXfwtxptgfEg4vp5i1bdpXd6cE/UMtEMH6SlIqO+/LAYgUiYaMSEin7O8sp0bB0bsC Ab8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rKN7Z98zl2A76WtSI12wVfEViVp755LqDddyaZae7+s=; b=tz40eC5vRWTfP5J4KfSDN2NPImhe0G90Wb3hyFmR3i2R0avBOiGXojo+JcI0dIVdtM iwqGRjFijJgH3PIHnBeJooihbcuxiaC6lrFUCzC+XZIXIKQsf0rkiPOdyA4KYmTB7qPV Okn4OLT6kVPJqkXniyZVbKajecYfx5ginVmdeMpRDo4STejEagbwrPZ0XZSUsceLD5JA K4PyXELXQQP/9CFfZdWxupKNyN6HzfZK+e0kgc5bCJpk6WFydA3zbwklF2Z7peROZ02T 9pvOScR9DDj/pqHkM8/rqB3TE93ilsOvOBgUZy3NtQTBbmoIlroQxYKWRXrTPtf0cU4Q mHZA== X-Gm-Message-State: APjAAAVGkodhvTcuR6hmNMV/y4JWiEvQax4O5rBqUA8V7l26f/pQodJK kWvc3Al4jplmUIoUoXc8+m+DuZFT2i4= X-Google-Smtp-Source: APXvYqy3Q3vIxu6Et7FrhBIBgNMP5zK5YGaUNTh8iHyp3lfvwbD3SDG6Qsr1DnlbqYkvLiTWE2Mk/Q== X-Received: by 2002:a5d:6288:: with SMTP id k8mr2951627wru.209.1567695111344; Thu, 05 Sep 2019 07:51:51 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x6sm4863663wmf.38.2019.09.05.07.51.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 07:51:50 -0700 (PDT) Date: Thu, 5 Sep 2019 15:51:49 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 10/22]: MdePkg/BaseSynchronizationLib: RISC-V cache related code. Message-ID: <20190905145149.GB29255@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-11-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1567593797-26216-11-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 04, 2019 at 06:43:05PM +0800, Abner Chang wrote: > Support RISC-V cache related functions. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > .../BaseSynchronizationLib.inf | 6 + > .../RiscV64/Synchronization.c | 189 +++++++++++++++++++++ > .../RiscV64/SynchronizationAsm.s | 84 +++++++++ Shouldn't this be SynchronizationAsm.S? Or well, "Asm" shouldn't be in the name, the filename ending takes care of dscribing what type of file it is. But .s (lowercase) denotes an assembler file that is *not* run through the C preprocessor, which ... I really don't see the point of. The filename should always be *.S (so we don't need to go back and rename the files if we decide to add include statements or local #defines). / Leif > 3 files changed, 279 insertions(+) > create mode 100644 MdePkg/Library/BaseSynchronizationLib/RiscV64/Synchronization.c > create mode 100644 MdePkg/Library/BaseSynchronizationLib/RiscV64/SynchronizationAsm.s