From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=jeSRcZkQ; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 05 Sep 2019 08:56:00 -0700 Received: by mail-wr1-f66.google.com with SMTP id h7so3384197wrt.13 for ; Thu, 05 Sep 2019 08:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2V26p+B32tI2Lg/26sLOutwc02t+6sZHPgux90xr3cs=; b=jeSRcZkQaqwVmKenUAZwSxanczDyaO4TxsEvhSBA8I4gBakB09V4aoGhHho/VgYRAy /554sgvFuollD4E7frcOHVXKVdu5V9HxqCLKS74iZykzv6U82pnFnAbNv243tr9tPEzP SSaF9diiMQJ7ay1oSyf3K8qDKYa3Y4lO1PW2eYzNTNCcFRpGK5G5PEc/QApIVTeVQHCE iVB+Zdq3Cw5/KMdAsRD9xFO2N4snwu/8lKbDXkP88EXkAKScWLzUpZI4hBbyKvLj9eCW L7DOkANsbT9JbIz4hvRDqfFVqd7BMQ+3vSlehep7/sBAIdsaXwZkXa3hV90nqWbk+Y6d fi+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2V26p+B32tI2Lg/26sLOutwc02t+6sZHPgux90xr3cs=; b=HpNgZK4/6tYC9XCgKM0l009A6piAXg1uFK8WShKtPmZvBZVo1V7o5+iZ7aSMNgveS1 Pb9BZjhb2lk3NonfiySjN1L2so+Y6IyiOy8GR77bMGNOn3iu4zvUTUvCdirPxKPP8h4L k3+3YgNVj0Vi3e3YoXt+eU3CNtidVeYNJFOmuxIyWzH8OiPj6DOq5Ep4m4ijn205kgIi jDn+jCJ4Zzg1+9ugDU2cqPBS5927qeLMeWC8eaS+xspqG6l0MopmMWTCTP7Z+zs0wkTa 9xnMqP/A/Sb7B/N1uPLKw/Q74dLETKMWyD21Y43XJXOvohz8qyuSohnuIQEHHrbvma/8 BqbQ== X-Gm-Message-State: APjAAAW7ae9nlMhXftnKxMGeqcvtCVoNyzAgSu006VFm/ajRQKSSUT5O V3MA3qaiuEoTQPDH3397okC3Ng== X-Google-Smtp-Source: APXvYqwu3Clmh7p/NFN6BqcMndzEXcK+x+xjmb1g0vwnXl29RZOizlVlK0KLCW4L8m7jvNVk+0xqTA== X-Received: by 2002:adf:cc84:: with SMTP id p4mr3402677wrj.201.1567698959073; Thu, 05 Sep 2019 08:55:59 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g3sm4708313wrh.28.2019.09.05.08.55.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 08:55:58 -0700 (PDT) Date: Thu, 5 Sep 2019 16:55:56 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: edk2-devel-groups-io , Laszlo Ersek Subject: Re: [PATCH] ArmVirtPkg/ArmVirtPrePiUniCoreRelocatable: revert to PIE linking Message-ID: <20190905155556.GD29255@bivouac.eciton.net> References: <20190904230423.24661-1-ard.biesheuvel@linaro.org> <20190905141923.GX29255@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 05, 2019 at 07:25:39AM -0700, Ard Biesheuvel wrote: > > > [BuildOptions] > > > - GCC:*_*_*_DLINK_FLAGS = -shared -Wl,-Bsymbolic -Wl,-T,$(MODULE_DIR)/Scripts/PrePi-PIE.lds > > > + GCC:*_*_*_DLINK_FLAGS = -Wl,-Bsymbolic,-pie,-T,$(MODULE_DIR)/Scripts/PrePi-PIE.lds > > > > We already merged a fix for AARCH64 though - could/should this be > > active on ARM only? > > > > A problem I have with this patch is that ArmVirtQemuKernel curently > > doesn't boot on my qemu (with/without kvm, built with GCC5 or CLANG38, > > with or without this patch): > > ProcessPciHost: Config[0x4010000000+0x10000000) Bus[0x0..0xFF] > > Io[0x0+0x10000)@0x3EFF0000 Mem32[0x10000000+0x2EFF0000)@0x0 > > Mem64[0x8000000000+0x8000000000)@0x0 > > MapGcdMmioSpace: failed to set memory space attributes for region > > [0x4010000000+0x10000000) > > > > ASSERT_EFI_ERROR (Status = Unsupported) > > ASSERT [PciHostBridgeDxe] > > /work/git/edk2/ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.c(293): > > !EFI_ERROR (Status) > > qemu-system-arm: terminating on signal 15 from pid 4680 (killall) > > > > Does it work with -M virt,highmem=off ? Ah, yes - that works fine then, also with the patch. Well, with that, and your explanation in the other thread: Acked-by: Leif Lindholm