From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=q62Vambf; spf=pass (domain: linaro.org, ip: 209.85.128.43, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by groups.io with SMTP; Thu, 05 Sep 2019 09:26:16 -0700 Received: by mail-wm1-f43.google.com with SMTP id q19so3525667wmc.3 for ; Thu, 05 Sep 2019 09:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WrmEE3ccBO9UbkEtFYhouhQbDSMyZMgaNFocLty7xeE=; b=q62VambfZ+q+naCGkQ1EywxZucufYPXJdRfOQBal4Vt8slenFGdz+gxk0qxqYEVsL4 84niAsqkT9i19FQVYyiZeD7FLzcQL/fYlHeWlC5ha8EyMMB/YZ4SQIyqRvm20e/LyGwH EZQlDR3vE518Z04PFe/q4L4gRM71qBWzH+OANST4aVSSw6RHrPBhlgHZKl5atzcchzUk b9Ru//TymQhudxLlowCpcrPKeMtHKFsaTZNWyMv1KvY7jOflNfCvsgeQWwzx3P5N0aXL yj1e9FfZWW29jrGH1UORTXkWn1+I1Gq2FBfVGHDVszQdZg7epQVTb4hgrW06DWBrgT6k JGPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WrmEE3ccBO9UbkEtFYhouhQbDSMyZMgaNFocLty7xeE=; b=SuYg0CYMWZc4ukRvcK2XQ7A+ZH94qtTIhHNwKy6enLRSjCl4UE712rfE9YqM3x0wjs NLzROCpELV0XIU5Xcc+aKU0G4xopy2koZRMYnkbdasOkoHkWBgIFnqH/LnFbSqNUz8/2 SDaKe0lnLjSP3q4Ztn4rrAv4layQ+b7+iqCT7CePHvlKwSgQNTwZqIJ4EPOm9i+sBifx 718Z88iiG95Q3Mm82xFwv0aGVez+uhc5kso5ea12jCotv5k6DT88Z8Vq4Ay0m+dYr/yi IPryhNUEtK5AVhOMZGYT3bVM/uJIAFO2f0+RG7qRcn1RgrUcET+dx5jvj54PYYqmH02u BWUw== X-Gm-Message-State: APjAAAWwdWiG3eOMCG7+wAGU48qn6XRWLyrX3UfEzx8/BgXlPdsBweZl YJm4B/XKmVvc9qWWsNp7Zap7kKubmMM= X-Google-Smtp-Source: APXvYqxJG6ixgIguI9f8XsLKJ3G6S2Tcm3kkeCH5FB+UYeykH6y6Qpsa6UbKZ1UqpcRoHv7OnxIfPA== X-Received: by 2002:a05:600c:2056:: with SMTP id p22mr3361309wmg.159.1567700774362; Thu, 05 Sep 2019 09:26:14 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id e3sm3767232wrh.12.2019.09.05.09.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 09:26:13 -0700 (PDT) Date: Thu, 5 Sep 2019 17:26:12 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, abner.chang@hpe.com Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 15/22]: RiscVPkg/RealTimeClockRuntimeDxe: Add RISC-V RTC Runtime Driver Message-ID: <20190905162612.GH29255@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-16-git-send-email-abner.chang@hpe.com> MIME-Version: 1.0 In-Reply-To: <1567593797-26216-16-git-send-email-abner.chang@hpe.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Sep 04, 2019 at 06:43:10PM +0800, Abner Chang wrote: > This is the abstract driver which incorporate with platform level RTC library (RealTimeClockLib) to provide Real Time Clock Architecture Protocol. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > .../RealTimeClockRuntimeDxe/RealTimeClock.c | 157 +++++++++++++++++++++ > .../RealTimeClockRuntimeDxe.inf | 44 ++++++ > 2 files changed, 201 insertions(+) > create mode 100644 RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClock.c > create mode 100644 RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf Why do we have this separate implementation? It looks pretty much equivalent to EmbeddedPkg/RealTimeClockRuntimeDxe/, but with the timezone handling ripped out. / Leif > diff --git a/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClock.c b/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClock.c > new file mode 100644 > index 0000000..c3d04e7 > --- /dev/null > +++ b/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClock.c > @@ -0,0 +1,157 @@ > +/** @file > + Implementation of EFI RealTimeClock runtime services via platform RTC Lib. > + > + Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> + Copyright (c) 2008 - 2009, Apple Inc. All rights reserved.
> + > + This program and the accompanying materials > + are licensed and made available under the terms and conditions of the BSD License > + which accompanies this distribution. The full text of the license may be found at > + http://opensource.org/licenses/bsd-license.php > + > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > + WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > + > +**/ > + > +#include > +#include > +#include > +#include > +#include > + > +EFI_HANDLE mHandle = NULL; > + > +/** > + Returns the current time and date information, and the time-keeping capabilities > + of the hardware platform. > + > + @param Time A pointer to storage to receive a snapshot of the current time. > + @param Capabilities An optional pointer to a buffer to receive the real time clock > + device's capabilities. > + > + @retval EFI_SUCCESS The operation completed successfully. > + @retval EFI_INVALID_PARAMETER Time is NULL. > + @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error. > + > +**/ > +EFI_STATUS > +EFIAPI > +GetTime ( > + OUT EFI_TIME *Time, > + OUT EFI_TIME_CAPABILITIES *Capabilities > + ) > +{ > + return LibGetTime (Time, Capabilities); > +} > + > + > + > +/** > + Sets the current local time and date information. > + > + @param Time A pointer to the current time. > + > + @retval EFI_SUCCESS The operation completed successfully. > + @retval EFI_INVALID_PARAMETER A time field is out of range. > + @retval EFI_DEVICE_ERROR The time could not be set due due to hardware error. > + > +**/ > +EFI_STATUS > +EFIAPI > +SetTime ( > + IN EFI_TIME *Time > + ) > +{ > + return LibSetTime (Time); > +} > + > + > +/** > + Returns the current wakeup alarm clock setting. > + > + @param Enabled Indicates if the alarm is currently enabled or disabled. > + @param Pending Indicates if the alarm signal is pending and requires acknowledgement. > + @param Time The current alarm setting. > + > + @retval EFI_SUCCESS The alarm settings were returned. > + @retval EFI_INVALID_PARAMETER Any parameter is NULL. > + @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved due to a hardware error. > + > +**/ > +EFI_STATUS > +EFIAPI > +GetWakeupTime ( > + OUT BOOLEAN *Enabled, > + OUT BOOLEAN *Pending, > + OUT EFI_TIME *Time > + ) > +{ > + return LibGetWakeupTime (Enabled, Pending, Time); > +} > + > + > +/** > + Sets the system wakeup alarm clock time. > + > + @param Enabled Enable or disable the wakeup alarm. > + @param Time If Enable is TRUE, the time to set the wakeup alarm for. > + > + @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alarm was enabled. If > + Enable is FALSE, then the wakeup alarm was disabled. > + @retval EFI_INVALID_PARAMETER A time field is out of range. > + @retval EFI_DEVICE_ERROR The wakeup time could not be set due to a hardware error. > + @retval EFI_UNSUPPORTED A wakeup timer is not supported on this platform. > + > +**/ > +EFI_STATUS > +EFIAPI > +SetWakeupTime ( > + IN BOOLEAN Enabled, > + OUT EFI_TIME *Time > + ) > +{ > + return LibSetWakeupTime (Enabled, Time); > +} > + > + > + > +/** > + This is the declaration of an EFI image entry point. This can be the entry point to an application > + written to this specification, an EFI boot service driver, or an EFI runtime driver. > + > + @param ImageHandle Handle that identifies the loaded image. > + @param SystemTable System Table for this image. > + > + @retval EFI_SUCCESS The operation completed successfully. > + > +**/ > +EFI_STATUS > +EFIAPI > +InitializeRealTimeClock ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + EFI_STATUS Status; > + > + Status = LibRtcInitialize (ImageHandle, SystemTable); > + if (EFI_ERROR (Status)) { > + return Status; > + } > + > + SystemTable->RuntimeServices->GetTime = GetTime; > + SystemTable->RuntimeServices->SetTime = SetTime; > + SystemTable->RuntimeServices->GetWakeupTime = GetWakeupTime; > + SystemTable->RuntimeServices->SetWakeupTime = SetWakeupTime; > + > + Status = gBS->InstallMultipleProtocolInterfaces ( > + &mHandle, > + &gEfiRealTimeClockArchProtocolGuid, > + NULL, > + NULL > + ); > + > + return Status; > +} > + > diff --git a/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf b/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > new file mode 100644 > index 0000000..afc1bca > --- /dev/null > +++ b/RiscVPkg/Universal/RealTimeClockRuntimeDxe/RealTimeClockRuntimeDxe.inf > @@ -0,0 +1,44 @@ > +#/** @file > +# This driver installs RTC Architecture Protocol > +# > +# Copyright (c) 2019, Hewlett Packard Enterprise Development LP. All rights reserved.
> +# Copyright (c) 2006 - 2007, Intel Corporation. All rights reserved.
> +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +# > +#**/ > + > +[Defines] > + INF_VERSION = 0x00010005 > + BASE_NAME = RealTimeClock > + FILE_GUID = C641D483-B367-40EF-96B3-860B75A4604E > + MODULE_TYPE = DXE_RUNTIME_DRIVER > + VERSION_STRING = 1.0 > + > + ENTRY_POINT = InitializeRealTimeClock > + > +[Sources.common] > + RealTimeClock.c > + > +[Packages] > + MdePkg/MdePkg.dec > + RiscVPkg/RiscVPkg.dec > + > +[LibraryClasses] > + UefiBootServicesTableLib > + UefiDriverEntryPoint > + DebugLib > + RealTimeClockLib > + > +[Protocols] > + gEfiRealTimeClockArchProtocolGuid > + > +[Depex] > + TRUE > + > -- > 2.7.4 > > > >