From: "Chiu, Chasel" <chasel.chiu@intel.com>
To: devel@edk2.groups.io
Cc: Michael Kubacki <michael.a.kubacki@intel.com>,
Nate DeSimone <nathaniel.l.desimone@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
Date: Fri, 6 Sep 2019 15:01:10 +0800 [thread overview]
Message-ID: <20190906070110.18204-1-chasel.chiu@intel.com> (raw)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159
FSP Dispatch mode will share same stack and heap with
bootloader so we should not reserve separate temporary
ram for FSP.
Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
Test: internal platform can boot with FSP Dispatch mode
with 64KB temporary RAM back.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 55ae9f47ac..2009bb225a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
@@ -69,10 +69,10 @@
gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
!else
#
- # FSP Dispatch mode will share the same stack with boot loader,
- # here temporary ram size is used by FSP heap and can be smaller
+ # FSP Dispatch mode will share the same stack and heap with boot loader,
+ # no separate temporary ram required by FSP.
#
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0
#
# In FSP Dispatch mode boot loader stack size must be big enough for executing
--
2.13.3.windows.1
next reply other threads:[~2019-09-06 7:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 7:01 Chiu, Chasel [this message]
2019-09-11 1:39 ` [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode Kubacki, Michael A
2019-09-11 2:20 ` Nate DeSimone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906070110.18204-1-chasel.chiu@intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox