* [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
@ 2019-09-06 7:01 Chiu, Chasel
2019-09-11 1:39 ` Kubacki, Michael A
2019-09-11 2:20 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Chiu, Chasel @ 2019-09-06 7:01 UTC (permalink / raw)
To: devel; +Cc: Michael Kubacki, Nate DeSimone, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159
FSP Dispatch mode will share same stack and heap with
bootloader so we should not reserve separate temporary
ram for FSP.
Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
Test: internal platform can boot with FSP Dispatch mode
with 64KB temporary RAM back.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 55ae9f47ac..2009bb225a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
@@ -69,10 +69,10 @@
gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
!else
#
- # FSP Dispatch mode will share the same stack with boot loader,
- # here temporary ram size is used by FSP heap and can be smaller
+ # FSP Dispatch mode will share the same stack and heap with boot loader,
+ # no separate temporary ram required by FSP.
#
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0
#
# In FSP Dispatch mode boot loader stack size must be big enough for executing
--
2.13.3.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
2019-09-06 7:01 [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode Chiu, Chasel
@ 2019-09-11 1:39 ` Kubacki, Michael A
2019-09-11 2:20 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Kubacki, Michael A @ 2019-09-11 1:39 UTC (permalink / raw)
To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L, Gao, Liming
Reviewed-by: Michael Kubacki <michael.a.kubacki@intel.com>
> -----Original Message-----
> From: Chiu, Chasel
> Sent: Friday, September 6, 2019 12:01 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel
> L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB
> Temporary RAM in Dispatch mode.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159
>
> FSP Dispatch mode will share same stack and heap with bootloader so we
> should not reserve separate temporary ram for FSP.
> Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
>
> Test: internal platform can boot with FSP Dispatch mode
> with 64KB temporary RAM back.
>
> Cc: Michael Kubacki <michael.a.kubacki@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
> ---
>
> Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.ds
> c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> index 55ae9f47ac..2009bb225a 100644
> ---
> a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> dsc
> +++
> b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.
> d
> +++ sc
> @@ -69,10 +69,10 @@
> gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
> !else
> #
> - # FSP Dispatch mode will share the same stack with boot loader,
> - # here temporary ram size is used by FSP heap and can be smaller
> + # FSP Dispatch mode will share the same stack and heap with boot
> + loader, # no separate temporary ram required by FSP.
> #
> - gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000
> + gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0
>
> #
> # In FSP Dispatch mode boot loader stack size must be big enough for
> executing
> --
> 2.13.3.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
2019-09-06 7:01 [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode Chiu, Chasel
2019-09-11 1:39 ` Kubacki, Michael A
@ 2019-09-11 2:20 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2019-09-11 2:20 UTC (permalink / raw)
To: Chiu, Chasel, devel@edk2.groups.io; +Cc: Kubacki, Michael A, Gao, Liming
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Chiu, Chasel
Sent: Friday, September 6, 2019 12:01 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A <michael.a.kubacki@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <liming.gao@intel.com>
Subject: [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2159
FSP Dispatch mode will share same stack and heap with bootloader so we should not reserve separate temporary ram for FSP.
Set PcdFspTemporaryRamSize to 0 in Dispatch mode.
Test: internal platform can boot with FSP Dispatch mode
with 64KB temporary RAM back.
Cc: Michael Kubacki <michael.a.kubacki@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Chasel Chiu <chasel.chiu@intel.com>
---
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
index 55ae9f47ac..2009bb225a 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkgPcd.d
+++ sc
@@ -69,10 +69,10 @@
gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000
!else
#
- # FSP Dispatch mode will share the same stack with boot loader,
- # here temporary ram size is used by FSP heap and can be smaller
+ # FSP Dispatch mode will share the same stack and heap with boot
+ loader, # no separate temporary ram required by FSP.
#
- gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0x00010000
+ gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize | 0
#
# In FSP Dispatch mode boot loader stack size must be big enough for executing
--
2.13.3.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-11 2:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-06 7:01 [edk2-platforms: PATCH] KabylakeOpenBoardPkg: Missed 64KB Temporary RAM in Dispatch mode Chiu, Chasel
2019-09-11 1:39 ` Kubacki, Michael A
2019-09-11 2:20 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox