[PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line

[PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line

[Zhang, Shenglei]

The original end of last line is '/r'. Now update it to '/r/n'.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
    The v1 patch is "BoardModulePkg/CmosAccessLib: Remove white ending line".

 .../BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf b/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
index 77ea219f..f84d6d1a 100644
--- a/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
+++ b/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
@@ -25,4 +25,4 @@
 
 [Packages]
   MdePkg/MdePkg.dec
-  BoardModulePkg/BoardModulePkg.dec
\ No newline at end of file
+  BoardModulePkg/BoardModulePkg.dec
-- 
2.18.0.windows.1

[PATCH v2] UserInterfaceFeaturePkg: Update the end of last line

[Zhang, Shenglei]

The original the of last line is '/r'. Now update it to '/r/n'.

Cc: Dandan Bi <dandan.bi@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
    The v1 patch is "UserInterfaceFeaturePkg:Remove white ending line in DSC file".

 .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
index e97bed53..6c5f77b5 100644
--- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
+++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
@@ -77,4 +77,4 @@
   UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf
 
 [BuildOptions]
-  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.18.0.windows.1

Re: [PATCH v2] UserInterfaceFeaturePkg: Update the end of last line

[Dandan Bi]

Reviewed-by: Dandan Bi <dandan.bi@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2] UserInterfaceFeaturePkg: Update the end of last line
> 
> The original the of last line is '/r'. Now update it to '/r/n'.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "UserInterfaceFeaturePkg:Remove white ending line in DSC
> file".
> 
>  .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> index e97bed53..6c5f77b5 100644
> --- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> +++
> b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> @@ -77,4 +77,4 @@
>    UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf
> 
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No
> newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.18.0.windows.1

Re: [edk2-devel] [PATCH v2] UserInterfaceFeaturePkg: Update the end of last line

[Philippe Mathieu-Daudé]

On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> The original the of last line is '/r'. Now update it to '/r/n'.
> 
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "UserInterfaceFeaturePkg:Remove white ending line in DSC file".
> 
>  .../Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> index e97bed53..6c5f77b5 100644
> --- a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> +++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> @@ -77,4 +77,4 @@
>    UserInterfaceFeaturePkg/UserAuthentication/UserAuthenticationSmm.inf
>  
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

[PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

[Zhang, Shenglei]

Remove white space in AcpiDebug.c.
The original end of last line in DebugFeaturePkg.dsc is '/r'.
Now update it to '/r/n'.

Cc: Eric Dong <eric.dong@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
    The v1 patch is "DebugFeaturePkg: Remove white space and white ending line".

 Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
 Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
index f9cd8bcb..5ad8d259 100644
--- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
+++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
@@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
   if (EFI_ERROR (Status)) {
     return Status;
   }
-  
+
   Status = SmmBase2->InSmm (SmmBase2, &InSmm);
   ASSERT_EFI_ERROR (Status);
   if (EFI_ERROR (Status)) {
@@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
 
   return Status;
 }
-
diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
index 30f57d5d..8e5ff4c9 100644
--- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
+++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
@@ -98,4 +98,4 @@
   DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
 
 [BuildOptions]
-  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
\ No newline at end of file
+  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
-- 
2.18.0.windows.1

Re: [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update the
> ending format
> 
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "DebugFeaturePkg: Remove white space and white ending
> line".
> 
>  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> index f9cd8bcb..5ad8d259 100644
> --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> -
> +
>    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
>    ASSERT_EFI_ERROR (Status);
>    if (EFI_ERROR (Status)) {
> @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
> 
>    return Status;
>  }
> -
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index 30f57d5d..8e5ff4c9 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -98,4 +98,4 @@
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
> 
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No
> newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> --
> 2.18.0.windows.1

Re: [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

[Zhang, Shenglei]

For this patch, I'll update the file format of AcpiDebug.c to Dos format when pushing the patch.

Thanks,
Shenglei

> -----Original Message-----
> From: Dong, Eric
> Sent: Monday, September 9, 2019 8:36 AM
> To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: RE: [PATCH v2] DebugFeaturePkg: Remove white space and update
> the ending format
> 
> Reviewed-by: Eric Dong <eric.dong@intel.com>
> 
> > -----Original Message-----
> > From: Zhang, Shenglei
> > Sent: Saturday, September 7, 2019 1:16 AM
> > To: devel@edk2.groups.io
> > Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> > Subject: [PATCH v2] DebugFeaturePkg: Remove white space and update
> the
> > ending format
> >
> > Remove white space in AcpiDebug.c.
> > The original end of last line in DebugFeaturePkg.dsc is '/r'.
> > Now update it to '/r/n'.
> >
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> > ---
> > v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
> >     The v1 patch is "DebugFeaturePkg: Remove white space and white
> ending
> > line".
> >
> >  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
> >  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
> >  2 files changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > index f9cd8bcb..5ad8d259 100644
> > --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> > @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
> >    if (EFI_ERROR (Status)) {
> >      return Status;
> >    }
> > -
> > +
> >    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
> >    ASSERT_EFI_ERROR (Status);
> >    if (EFI_ERROR (Status)) {
> > @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
> >
> >    return Status;
> >  }
> > -
> > diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > index 30f57d5d..8e5ff4c9 100644
> > --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> > @@ -98,4 +98,4 @@
> >    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
> >
> >  [BuildOptions]
> > -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES \ No
> > newline at end of file
> > +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> > --
> > 2.18.0.windows.1

Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format

[Philippe Mathieu-Daudé]

On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "DebugFeaturePkg: Remove white space and white ending line".
> 
>  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> index f9cd8bcb..5ad8d259 100644
> --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> -  
> +
>    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
>    ASSERT_EFI_ERROR (Status);
>    if (EFI_ERROR (Status)) {
> @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
>  
>    return Status;
>  }
> -
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index 30f57d5d..8e5ff4c9 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -98,4 +98,4 @@
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
>  
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Re: [edk2-devel] [PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line

[Dong, Eric]

Reviewed-by: Eric Dong <eric.dong@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Saturday, September 7, 2019 1:16 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH v2] BoardModulePkg/CmosAccessLib: Update the
> end of last line
> 
> The original end of last line is '/r'. Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "BoardModulePkg/CmosAccessLib: Remove white ending
> line".
> 
>  .../BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf      | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
> b/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
> index 77ea219f..f84d6d1a 100644
> ---
> a/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
> +++
> b/Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf
> @@ -25,4 +25,4 @@
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> -  BoardModulePkg/BoardModulePkg.dec
> \ No newline at end of file
> +  BoardModulePkg/BoardModulePkg.dec
> --
> 2.18.0.windows.1
> 
> 
>