public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
@ 2019-09-11 10:13 Bob Feng
  2019-09-12  5:51 ` Liming Gao
  0 siblings, 1 reply; 2+ messages in thread
From: Bob Feng @ 2019-09-11 10:13 UTC (permalink / raw)
  To: devel; +Cc: Liming Gao, Bob Feng

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2080
After checking that if the build can't
ignore Autogen due to there is no compelet autogen files, 
the build tool need to do a completely Autogen.

This patch is to fix a bug that if AutoGen
can't be skiped, the SkipAutoGen flag
need to set to False

Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Bob Feng <bob.c.feng@intel.com>
---
 BaseTools/Source/Python/build/build.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/BaseTools/Source/Python/build/build.py b/BaseTools/Source/Python/build/build.py
index 13be6c33ecd5..a034664dc388 100755
--- a/BaseTools/Source/Python/build/build.py
+++ b/BaseTools/Source/Python/build/build.py
@@ -2202,10 +2202,11 @@ class Build():
                 ExitFlag = threading.Event()
                 ExitFlag.clear()
                 if self.SkipAutoGen:
                     Wa = self.VerifyAutoGenFiles()
                     if Wa is None:
+                        self.SkipAutoGen = False
                         Wa, self.BuildModules = self.PerformAutoGen(BuildTarget,ToolChain)
                     else:
                         GlobalData.gAutoGenPhase = True
                         self.BuildModules = self.SetupMakeSetting(Wa)
                 else:
-- 
2.20.1.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
  2019-09-11 10:13 [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen Bob Feng
@ 2019-09-12  5:51 ` Liming Gao
  0 siblings, 0 replies; 2+ messages in thread
From: Liming Gao @ 2019-09-12  5:51 UTC (permalink / raw)
  To: Feng, Bob C, devel@edk2.groups.io

Reviewed-by: Liming Gao <liming.gao@intel.com>

>-----Original Message-----
>From: Feng, Bob C
>Sent: Wednesday, September 11, 2019 6:14 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Feng, Bob C <bob.c.feng@intel.com>
>Subject: [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen
>
>REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2080
>After checking that if the build can't
>ignore Autogen due to there is no compelet autogen files,
>the build tool need to do a completely Autogen.
>
>This patch is to fix a bug that if AutoGen
>can't be skiped, the SkipAutoGen flag
>need to set to False
>
>Cc: Liming Gao <liming.gao@intel.com>
>Signed-off-by: Bob Feng <bob.c.feng@intel.com>
>---
> BaseTools/Source/Python/build/build.py | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/BaseTools/Source/Python/build/build.py
>b/BaseTools/Source/Python/build/build.py
>index 13be6c33ecd5..a034664dc388 100755
>--- a/BaseTools/Source/Python/build/build.py
>+++ b/BaseTools/Source/Python/build/build.py
>@@ -2202,10 +2202,11 @@ class Build():
>                 ExitFlag = threading.Event()
>                 ExitFlag.clear()
>                 if self.SkipAutoGen:
>                     Wa = self.VerifyAutoGenFiles()
>                     if Wa is None:
>+                        self.SkipAutoGen = False
>                         Wa, self.BuildModules =
>self.PerformAutoGen(BuildTarget,ToolChain)
>                     else:
>                         GlobalData.gAutoGenPhase = True
>                         self.BuildModules = self.SetupMakeSetting(Wa)
>                 else:
>--
>2.20.1.windows.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-12  5:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-11 10:13 [Patch 1/1] BaseTools: Fixed a bug of IgnoreAutoGen Bob Feng
2019-09-12  5:51 ` Liming Gao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox