From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=lTOdInEV; spf=pass (domain: gmx.de, ip: 212.227.17.21, mailfrom: xypron.glpk@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) by groups.io with SMTP; Wed, 11 Sep 2019 11:45:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1568227481; bh=FRuHZT+Q61+SI/0jTSbOyqBSg1/CrtNlygJkGByv+Hk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=lTOdInEVEOK1+zPpP5RQsmoJmDPcklP/gNnDn3l0ag0knKFtUBnvOeWIFzPE+5EX/ W/lgZblZzvU/ueYUMJHT7s0jbghsv9+rVcFtNFbCy/DCV1ZxP1krqtSR6pRF8sV96i HS9QM1Kr0BK4K2Pe95IPz136pZav5KVAMSitP9xk= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([84.118.159.3]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0LhSfM-1iUJD735mK-00mcN2; Wed, 11 Sep 2019 20:44:41 +0200 From: "Heinrich Schuchardt" To: EDK II Development Cc: Eric Jin , Supreeth Venkatesh , Stephano Cetola , Heinrich Schuchardt Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported Date: Wed, 11 Sep 2019 20:44:30 +0200 Message-Id: <20190911184430.29684-1-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:PxnkFal2VMHT84a+61M/Ne2CuCZptv9wLnwXhdH/9vyNRT7jlI0 Ze12Wih1hCmmbh+OgPbD44+kheLGTfxWqC6K/bXMRxhgfi/PtmHapDVNehg+vGq/TQtr0DO xkUfQH3BJ6FJ+aiRNHPb5ZzPBuxnz7Yv5C+JnunL0YBnlE52DDyUqNH0WTWDGAbIImLQ4sc nL9s2vWYmTWTN56WFVooA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:/6rf95GsNS0=:gW50Kh+evHciXhxFIoZdQl YlDn5MFu4RWVE6f/Dqa+cDArUhbgaGyW37CBbu5lXKm55P2SV6oUsJF9FH+6VlFzAHqdM16av TyjH0rdtkXdftJ4nCEF/FdKbKqTWbHcdBD0deF9GGLq2YUptEVqmaYcuQqXwyhcKVeyNkzQW9 UlLh6kF5rEuYYL5e8WDKPDI4JBb5MgkQxORlD0bfZnQyOolRJbAH/gnQY32iTQw6xCbmr7riS dZtsvf91P8g9tQIvSpsCvs7uwwBSgp7MJS/dGHyWBiyIEw2m5uB7ANhbCBy3ZfTrPkyDzVTjQ RSjBUxN4xikqo1NDNqObDVQTDOMASr7ybb2Toxm8pPtQyHZM6SaG9Pxyn7kGrVgwCvRkqGCH1 yp9DGbZS6J23zq1/lmfAV00BI0n5odmU2GLt6+1l1SdckdcjqO750Cp1DMP0IRuyk+Ibn7Ium iyfOHtqMrgd9w2f/liGwPhuFuZ6DLeLKHptJjxO8BP+yQ6zTNEGotN4FJJ6MhPkbiTZTbBb8Z Di/dhEvuCzm/He2cMDynyXINQtkxOAOeOB1mAmbb/ZRci6hWH/wH2eM28ptB3mO1vPHh7lcn3 KtAiPqO/IH29/y9PCUOG2L97sD1g6EfpUi/vxuEs/Yb4XGibyY9wGbEJoAFANB0OUnLD98HIN EBDeExXop4FGA3IwerMQH/jS/MgdkRiCSj6KFSMBnzdeT+KSVUh9UeJB4z+DnToXrwX85Wz7M W+CiFSmnLJeszw1m1uSEDT6f5Id/CtP/tD4wLs6xSRvSm+Pj6WX5v7E0GalumyQDKvM6bUl4i //1KYjgqvfMz3g3vvMyxb96KOmx54TxUZgoDV+xHyZ4THmplhY0U9IBDwo4BZif2OKuR2jfrX 7R3LPtXeRtUoFhoDlLG6I4c3BjaUz+jir60cNsJpzBRXmjzh2zacqqjFH0zATnLqFWTmSE5qs Ha8Qs4+Z8MyJ4yAFHyEnmcJ/899IQ33rGIMFja/QsBIE8wsSqglpqnXh/GEYrp47uz0LtDzAA xrIZq2WoLtNaqcpULm0Yy/FXJNLNDwZfd8DA/d+oyiiojN8ja+ADOszRizr7CdxRGOmUBYFlc k9zW6oZVv0Tn0ALiI1eqm4beEGmZNUZM5CfFZwPwoXFz8sdwUD1j/zsEfWk1ZrQX4IfvY5A6L 9/uJct0xWLD8JmrjLpQ6AwqJlVvM2G12okiA1t7QOIptnQxu2a6CijpQq0FmapXdB/HFOQnVv JU2mcQ3fLyMLyzKSsEu7art85svqaNQefkGIku9eyBLZhdQj0WD1J0Bi5h0g= Content-Transfer-Encoding: quoted-printable REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState() to return EFI_UNSUPPORTED if a state change is not supported. This for instance may be the case when connecting via a serial connection. Up to now the SCT has marked the conformance test as FAILED if SetState() was called with invalid parameters and EFI_UNSUPPORTED was returned which contradicts the specification. Instead create a warning if SetState() returns EFI_UNSUPPORTED. This allows the user to check if the non-support is justified. Signed-off-by: Heinrich Schuchardt --- v2: Issue warning if EFI_UNSUPPORTED is returned when called with invalid parameters. --- .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/B= lackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/TestCase= /UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBTestCo= nformance.c index d997b651..946cb274 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBox= Test/SimpleTextInputExBBTestConformance.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBox= Test/SimpleTextInputExBBTestConformance.c @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( );=0D }=0D }=0D - =0D - if ( EFI_INVALID_PARAMETER !=3D Status) {=0D +=0D + if (Status =3D=3D EFI_UNSUPPORTED) {=0D + AssertionType =3D EFI_TEST_ASSERTION_WARNING;=0D + } else if (Status !=3D EFI_INVALID_PARAMETER) {=0D AssertionType =3D EFI_TEST_ASSERTION_FAILED;=0D } else {=0D AssertionType =3D EFI_TEST_ASSERTION_PASSED;=0D --=20 2.20.1