From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file
Date: Fri, 13 Sep 2019 18:18:15 +0100 [thread overview]
Message-ID: <20190913171815.GK13575@bivouac.eciton.net> (raw)
In-Reply-To: <20190831140729.8404-1-pete@akeo.ie>
On Sat, Aug 31, 2019 at 03:07:29PM +0100, Pete Batard wrote:
> The header files are used but missing in INF, which causes
> warning message when building them.
>
> Signed-off-by: Pete Batard <pete@akeo.ie>
Thanks for the cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 9b5a1c789d39.
> ---
> ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 1 +
> ArmPlatformPkg/Library/HdLcd/HdLcd.inf | 1 +
> ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf | 1 +
> ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 +
> ArmPlatformPkg/PrePi/PeiUniCore.inf | 1 +
> 5 files changed, 5 insertions(+)
>
> diff --git a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> index c3f2eb03f01c..d9d9bbd30e4c 100644
> --- a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> +++ b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> @@ -16,6 +16,7 @@ [Defines]
> LIBRARY_CLASS = LcdHwLib
>
> [Sources.common]
> + ArmMaliDp.h
> ArmMaliDp.c
>
> [Packages]
> diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> index c14f387b57d0..bc80e1adea27 100644
> --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> @@ -17,6 +17,7 @@ [Defines]
> LIBRARY_CLASS = LcdHwLib
>
> [Sources.common]
> + HdLcd.h
> HdLcd.c
>
> [Packages]
> diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> index 8b7cc48bd60d..757348c19659 100644
> --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> @@ -16,6 +16,7 @@ [Defines]
> LIBRARY_CLASS = LcdHwLib
>
> [Sources.common]
> + PL111Lcd.h
> PL111Lcd.c
>
> [Packages]
> diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> index 8be222893e2a..9c5da0d42a7b 100644
> --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> @@ -15,6 +15,7 @@ [Defines]
> VERSION_STRING = 1.0
>
> [Sources]
> + PrePi.h
> PrePi.c
> MainMPCore.c
>
> diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> index 95919b784185..ee9b05b25337 100644
> --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> @@ -15,6 +15,7 @@ [Defines]
> VERSION_STRING = 1.0
>
> [Sources]
> + PrePi.h
> PrePi.c
> MainUniCore.c
>
> --
> 2.21.0.windows.1
>
prev parent reply other threads:[~2019-09-13 17:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 14:07 [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file Pete Batard
2019-09-13 17:18 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190913171815.GK13575@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox