From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=SudbwyoY;
 spf=pass (domain: linaro.org, ip: 209.85.221.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67])
 by groups.io with SMTP; Fri, 13 Sep 2019 10:18:19 -0700
Received: by mail-wr1-f67.google.com with SMTP id i1so32268684wro.4
        for <devel@edk2.groups.io>; Fri, 13 Sep 2019 10:18:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=0J9r/DcYDt+8tVedcB81OmiSXRjE6DF4V8u/el3/o1w=;
        b=SudbwyoYoEZWcSNBotXZ2QGF1GvLCWmWm36Fp5HRGxE8DvdpGqIa+hfSt1HtLRkKks
         qA+f+/MRRvHIWV6Y3n+F2FAE/uJWev7b4YCTcAbKobPaDtUNfd72hIeYpbHWRvy1Zf8R
         7zgyZQphe1hCjKJuG7aoJMKBi+CiIWj6fDiTFk/Ra/iWF3TuqvkHqAWSJLhj915bjGFo
         puxYBVEkSMkPxG8chVk2/QCaolxIk5zrNG8qazbww4gUx1ScczXnlUI2caIvhE9vxnb/
         45cgmlEzMOR8Jdc3enebQQRTCtLNoptKTCRMy6wvOd0JbhAm/K74vq+epGhgllx4+KwK
         n+Zw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=0J9r/DcYDt+8tVedcB81OmiSXRjE6DF4V8u/el3/o1w=;
        b=j7nQN0E8vuHMPeFl2mFsIASBo2epSXY915c1xTgmKvGRiqHecJlwFrs1LOVPuMweLU
         OW+Yo6IhFhoa0k9KOp+2mNEbj1klCsRCdOOisxHAGCgT/iiLyGQsqFI6/3p46u/OpgPv
         H40hHG9v8RjWmUNu9hnCIqJky2qqIuVTmQPKOmuHawbA6+MztJyJkEldf56+9mUewEwW
         UnEfZQDNycjqqRCIS00jt8zaI/XFeiiT7Tj0J4L1l735EsGCT5PH3eGixwYUfkL4oZUT
         nZR9wzjxoy7qc7IQQ6Oi6whiZZ5FGtsKOgoefR3NJhAp07VRUjQ6PrLbayzAxUdujFLf
         yp8A==
X-Gm-Message-State: APjAAAUd1AxY+81U2L26tuGrTMOX6chuUu0mCq0gIuXl+K6CX5k2I8AO
	DAYQw3CDon+UjPquMClbYP4I1Q==
X-Google-Smtp-Source: APXvYqyImHuKQf9v9yu4cIeqU4Gruf0h98YkcG5c1B61VxNXB/CXTHdH0QZTUfxu0shcQ/2N/dH1wQ==
X-Received: by 2002:a5d:6647:: with SMTP id f7mr40661829wrw.170.1568395097730;
        Fri, 13 Sep 2019 10:18:17 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id q124sm5835666wma.5.2019.09.13.10.18.16
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 13 Sep 2019 10:18:17 -0700 (PDT)
Date: Fri, 13 Sep 2019 18:18:15 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Pete Batard <pete@akeo.ie>
Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org
Subject: Re: [PATCH 1/1] ArmPlatformPkg: Add missing header files in INF file
Message-ID: <20190913171815.GK13575@bivouac.eciton.net>
References: <20190831140729.8404-1-pete@akeo.ie>
MIME-Version: 1.0
In-Reply-To: <20190831140729.8404-1-pete@akeo.ie>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Aug 31, 2019 at 03:07:29PM +0100, Pete Batard wrote:
> The header files are used but missing in INF, which causes
> warning message when building them.
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>

Thanks for the cleanup.
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 9b5a1c789d39.

> ---
>  ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf | 1 +
>  ArmPlatformPkg/Library/HdLcd/HdLcd.inf         | 1 +
>  ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf   | 1 +
>  ArmPlatformPkg/PrePi/PeiMPCore.inf             | 1 +
>  ArmPlatformPkg/PrePi/PeiUniCore.inf            | 1 +
>  5 files changed, 5 insertions(+)
> 
> diff --git a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> index c3f2eb03f01c..d9d9bbd30e4c 100644
> --- a/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> +++ b/ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.inf
> @@ -16,6 +16,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  ArmMaliDp.h
>    ArmMaliDp.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> index c14f387b57d0..bc80e1adea27 100644
> --- a/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> +++ b/ArmPlatformPkg/Library/HdLcd/HdLcd.inf
> @@ -17,6 +17,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  HdLcd.h
>    HdLcd.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> index 8b7cc48bd60d..757348c19659 100644
> --- a/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> +++ b/ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.inf
> @@ -16,6 +16,7 @@ [Defines]
>    LIBRARY_CLASS                  = LcdHwLib
>  
>  [Sources.common]
> +  PL111Lcd.h
>    PL111Lcd.c
>  
>  [Packages]
> diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> index 8be222893e2a..9c5da0d42a7b 100644
> --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources]
> +  PrePi.h
>    PrePi.c
>    MainMPCore.c
>  
> diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> index 95919b784185..ee9b05b25337 100644
> --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf
> +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf
> @@ -15,6 +15,7 @@ [Defines]
>    VERSION_STRING                 = 1.0
>  
>  [Sources]
> +  PrePi.h
>    PrePi.c
>    MainUniCore.c
>  
> -- 
> 2.21.0.windows.1
>