public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file
@ 2019-08-31 14:08 Pete Batard
  2019-09-13 17:23 ` Leif Lindholm
  0 siblings, 1 reply; 2+ messages in thread
From: Pete Batard @ 2019-08-31 14:08 UTC (permalink / raw)
  To: devel; +Cc: ard.biesheuvel, leif.lindholm

The header files are used but missing in INF, which causes
warning message when building them.

Signed-off-by: Pete Batard <pete@akeo.ie>
---
 Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf             | 1 +
 Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf                           | 1 +
 Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf                         | 1 +
 Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf                     | 2 ++
 Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf                                 | 1 +
 Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf         | 1 +
 Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
 7 files changed, 8 insertions(+)

diff --git a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
index 3da379b99bbb..487b7e3592ab 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
@@ -16,6 +16,7 @@ [Defines]
   ENTRY_POINT                    = MMCInitialize
 
 [Sources.common]
+  ArasanMmcHostDxe.h
   ArasanMmcHostDxe.c
 
 [Packages]
diff --git a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
index 6d6c90b78408..2fc4302526a1 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
@@ -23,6 +23,7 @@ [Defines]
 
 [Sources]
   ConfigDxe.c
+  ConfigDxeFormSetGuid.h
   ConfigDxeHii.vfr
   ConfigDxeHii.uni
 
diff --git a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
index 652f6827f351..11271045bdd9 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
@@ -26,6 +26,7 @@ [Defines]
 #
 
 [Sources]
+  DisplayDxe.h
   DisplayDxe.c
   Screenshot.c
   ComponentName.c
diff --git a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
index 6eaca35aef55..f86480c035ba 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
@@ -16,6 +16,8 @@ [Defines]
   ENTRY_POINT                    = DwUsbHostEntryPoint
 
 [Sources.common]
+  DwcHw.h
+  DwUsbHostDxe.h
   DwUsbHostDxe.c
   DriverBinding.c
   ComponentName.c
diff --git a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
index 2c71bb624387..0690f9da9c4f 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
@@ -18,6 +18,7 @@ [Defines]
 
 [Sources.common]
   ComponentName.c
+  Mmc.h
   Mmc.c
   MmcBlockIo.c
   MmcIdentification.c
diff --git a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
index 8f99528f8963..394a4f61a5b8 100644
--- a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
+++ b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
@@ -27,6 +27,7 @@ [Defines]
 
 [Sources]
   FvbInfo.c
+  VarBlockService.h
   VarBlockService.c
   VarBlockServiceDxe.c
   FileIo.c
diff --git a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
index 7ce3e95c80d6..e1b132a0ae3a 100644
--- a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
+++ b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
@@ -25,6 +25,7 @@ [Defines]
 #
 
 [Sources]
+  PlatformBm.h
   PlatformBm.c
 
 [Packages]
-- 
2.21.0.windows.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file
  2019-08-31 14:08 [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file Pete Batard
@ 2019-09-13 17:23 ` Leif Lindholm
  0 siblings, 0 replies; 2+ messages in thread
From: Leif Lindholm @ 2019-09-13 17:23 UTC (permalink / raw)
  To: Pete Batard; +Cc: devel, ard.biesheuvel

On Sat, Aug 31, 2019 at 03:08:50PM +0100, Pete Batard wrote:
> The header files are used but missing in INF, which causes
> warning message when building them.
> 
> Signed-off-by: Pete Batard <pete@akeo.ie>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as e60b57484b8a.

Thanks!

> ---
>  Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf             | 1 +
>  Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf                           | 1 +
>  Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf                         | 1 +
>  Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf                     | 2 ++
>  Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf                                 | 1 +
>  Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf         | 1 +
>  Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 +
>  7 files changed, 8 insertions(+)
> 
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
> index 3da379b99bbb..487b7e3592ab 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf
> @@ -16,6 +16,7 @@ [Defines]
>    ENTRY_POINT                    = MMCInitialize
>  
>  [Sources.common]
> +  ArasanMmcHostDxe.h
>    ArasanMmcHostDxe.c
>  
>  [Packages]
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
> index 6d6c90b78408..2fc4302526a1 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf
> @@ -23,6 +23,7 @@ [Defines]
>  
>  [Sources]
>    ConfigDxe.c
> +  ConfigDxeFormSetGuid.h
>    ConfigDxeHii.vfr
>    ConfigDxeHii.uni
>  
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
> index 652f6827f351..11271045bdd9 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf
> @@ -26,6 +26,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  DisplayDxe.h
>    DisplayDxe.c
>    Screenshot.c
>    ComponentName.c
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
> index 6eaca35aef55..f86480c035ba 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf
> @@ -16,6 +16,8 @@ [Defines]
>    ENTRY_POINT                    = DwUsbHostEntryPoint
>  
>  [Sources.common]
> +  DwcHw.h
> +  DwUsbHostDxe.h
>    DwUsbHostDxe.c
>    DriverBinding.c
>    ComponentName.c
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
> index 2c71bb624387..0690f9da9c4f 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf
> @@ -18,6 +18,7 @@ [Defines]
>  
>  [Sources.common]
>    ComponentName.c
> +  Mmc.h
>    Mmc.c
>    MmcBlockIo.c
>    MmcIdentification.c
> diff --git a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
> index 8f99528f8963..394a4f61a5b8 100644
> --- a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
> +++ b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf
> @@ -27,6 +27,7 @@ [Defines]
>  
>  [Sources]
>    FvbInfo.c
> +  VarBlockService.h
>    VarBlockService.c
>    VarBlockServiceDxe.c
>    FileIo.c
> diff --git a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> index 7ce3e95c80d6..e1b132a0ae3a 100644
> --- a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> +++ b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> @@ -25,6 +25,7 @@ [Defines]
>  #
>  
>  [Sources]
> +  PlatformBm.h
>    PlatformBm.c
>  
>  [Packages]
> -- 
> 2.21.0.windows.1
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-09-13 17:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-31 14:08 [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file Pete Batard
2019-09-13 17:23 ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox