From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=buNRM1L9; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 13 Sep 2019 10:23:17 -0700 Received: by mail-wm1-f68.google.com with SMTP id o184so3571315wme.3 for ; Fri, 13 Sep 2019 10:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7f64Pw0NbFn0ttwm3b/imRaOM3QU+SXrSz2QVr+5JZw=; b=buNRM1L9VG1RUi4+TU/PUDqKBcAYbigfRCPCYlMQ1dO9gy5Q3U2csb0u+lpLA+WD/+ BmHL6+MsXkX5y+u9sy2+L8s0HsL8Bv7yGxr1rFRbGxyaJktoG/bPt/aOh8n9hpi7TuCJ xb1vIgurrPl3Pl4PX3MncsmSTbdNjpFwDGs/oD3oNNVSsD5HYtBdgBIKy8NRSv/VDcbr mWvoyf981WyZSGkGpwJ4jMNlBT0bXiDi7NeFlm7QrprHyOvvugY9aBHG055lPWR43v+r wSAjxIpcclfdaXEojfdFy2PSLayZS3Bs3HCnqxBa07GFeMFYE8UJcwZJOkoBnSgYfz0e LF0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7f64Pw0NbFn0ttwm3b/imRaOM3QU+SXrSz2QVr+5JZw=; b=XQLoX+IK7wMnNoAk87jyhEAkXhsbiF06PCry1gLv1LVPeyPMDLqQ4jKqQeuAvh1P83 9lroLPQBcG1kOCQGtSiLNU81kUhVo9dbWQEyyG6Qs5tFGso7+40VXDyjgSfdIqpf+ffL FhyldXnUpq0QtyuY46TpOMTZOmr8VX7GFqr41mL5GCAdue9poIcB9p2xX40g7T7OOi0N f/irKRFeqUs7I4+8RmELmApvv1XjVCprcgMre+pBMG/waAO2cGODZGru8uij+LeP5GlJ QPPxsfKPnSfszDhLkTmTGfhCZd80gg09AdmSvWYotXeS0xRdIYvgSvJJjFtpKi0ZWUVd tbOQ== X-Gm-Message-State: APjAAAVn22cCvOH3CXODvsAJhm+IWDN/VOZY9GVt4MrybgdrIoPwwB6Y JUA+zL2oq8FfMabnYbUiwrUfKw== X-Google-Smtp-Source: APXvYqzJ6gYpBIAjM8BzW8rchxNVH+JXDRBaI8S5jECLxuK3g5qVRK7XVgn0l82zKLRr+ZUUqh2xcQ== X-Received: by 2002:a7b:c203:: with SMTP id x3mr4515396wmi.8.1568395395400; Fri, 13 Sep 2019 10:23:15 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id x5sm40749707wrg.69.2019.09.13.10.23.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Sep 2019 10:23:14 -0700 (PDT) Date: Fri, 13 Sep 2019 18:23:13 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms PATCH 1/1] Platform/RPi3: Add missing header files in INF file Message-ID: <20190913172313.GL13575@bivouac.eciton.net> References: <20190831140850.4972-1-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20190831140850.4972-1-pete@akeo.ie> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Aug 31, 2019 at 03:08:50PM +0100, Pete Batard wrote: > The header files are used but missing in INF, which causes > warning message when building them. > > Signed-off-by: Pete Batard Reviewed-by: Leif Lindholm Pushed as e60b57484b8a. Thanks! > --- > Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 2 ++ > Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf | 1 + > Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 + > 7 files changed, 8 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf > index 3da379b99bbb..487b7e3592ab 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf > @@ -16,6 +16,7 @@ [Defines] > ENTRY_POINT = MMCInitialize > > [Sources.common] > + ArasanMmcHostDxe.h > ArasanMmcHostDxe.c > > [Packages] > diff --git a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf > index 6d6c90b78408..2fc4302526a1 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf > @@ -23,6 +23,7 @@ [Defines] > > [Sources] > ConfigDxe.c > + ConfigDxeFormSetGuid.h > ConfigDxeHii.vfr > ConfigDxeHii.uni > > diff --git a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf > index 652f6827f351..11271045bdd9 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/DisplayDxe/DisplayDxe.inf > @@ -26,6 +26,7 @@ [Defines] > # > > [Sources] > + DisplayDxe.h > DisplayDxe.c > Screenshot.c > ComponentName.c > diff --git a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf > index 6eaca35aef55..f86480c035ba 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf > @@ -16,6 +16,8 @@ [Defines] > ENTRY_POINT = DwUsbHostEntryPoint > > [Sources.common] > + DwcHw.h > + DwUsbHostDxe.h > DwUsbHostDxe.c > DriverBinding.c > ComponentName.c > diff --git a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf > index 2c71bb624387..0690f9da9c4f 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/MmcDxe/MmcDxe.inf > @@ -18,6 +18,7 @@ [Defines] > > [Sources.common] > ComponentName.c > + Mmc.h > Mmc.c > MmcBlockIo.c > MmcIdentification.c > diff --git a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf > index 8f99528f8963..394a4f61a5b8 100644 > --- a/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf > +++ b/Platform/RaspberryPi/RPi3/Drivers/VarBlockServiceDxe/VarBlockServiceDxe.inf > @@ -27,6 +27,7 @@ [Defines] > > [Sources] > FvbInfo.c > + VarBlockService.h > VarBlockService.c > VarBlockServiceDxe.c > FileIo.c > diff --git a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > index 7ce3e95c80d6..e1b132a0ae3a 100644 > --- a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > +++ b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > @@ -25,6 +25,7 @@ [Defines] > # > > [Sources] > + PlatformBm.h > PlatformBm.c > > [Packages] > -- > 2.21.0.windows.1 >