From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Gao, Zhichao" <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
Date: Tue, 17 Sep 2019 10:14:42 +0100 [thread overview]
Message-ID: <20190917091442.GC24787@bivouac.eciton.net> (raw)
In-Reply-To: <C0706E73DB8C124D9B9C38AA364E5D5E0562D3B0@SHSMSX106.ccr.corp.intel.com>
On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote:
> That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d).
> This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result.
> I should double check the new guid used in the file.
Determining what affects build and not is something humans are very
bad at and computers are very good at.
So you should build check every patch you submit to the list, no
matter how trivial.
In normal circumstances, so should the maintainers before pushing the
patch.
We now have a commit in the tree known to break the build of pretty
much all ARM/AARCH64 platforms. This will be very unpleasant for
future bisect.
Best Regards,
Leif
next prev parent reply other threads:[~2019-09-17 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 6:19 [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Gao, Zhichao
2019-09-17 6:19 ` [PATCH V2 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console Gao, Zhichao
2019-09-17 9:38 ` Laszlo Ersek
2019-09-17 6:19 ` [PATCH V2 2/3] MdeModulePkg/TerminalDxe: Extend the terminal console support types Gao, Zhichao
2019-09-17 6:19 ` [PATCH V2 3/3] MdeModulePkg/BM_UI: Add the new terminal types to related menu Gao, Zhichao
2019-09-17 6:28 ` [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Ard Biesheuvel
2019-09-17 6:47 ` Liming Gao
2019-09-17 7:16 ` Gao, Zhichao
2019-09-17 7:17 ` Zhang, Shenglei
2019-09-17 8:23 ` Ard Biesheuvel
2019-09-17 9:14 ` Leif Lindholm [this message]
2019-09-17 14:32 ` Liming Gao
[not found] ` <15C5258FC1CFF61F.11658@groups.io>
2019-09-17 7:41 ` [edk2-devel] [PATCH V2 2/3] MdeModulePkg/TerminalDxe: Extend the terminal console support types Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190917091442.GC24787@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox