From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=yyObQinj; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Tue, 17 Sep 2019 02:14:47 -0700 Received: by mail-wm1-f68.google.com with SMTP id p7so2382369wmp.4 for ; Tue, 17 Sep 2019 02:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vg66exnkv8n8lyWIZ3vwDm68jUS+rEl5quzUimxMN5c=; b=yyObQinjrtnRXZCtFAKGJgkR+98G/QQ+yhqyCZJlpXljTQR7hdoclHmNRzNqnA6rgc NDIKQ2du3SNGpsdVdLP9dmOq/FqLI+c75DGdurlwYRRZtrwObTtbVw7k1XycIrMbWpuf 9L1y14ANKbOULhbVcEEMk8lpdPNLKVkVRVy8l9jAAaUewYtg94bRKFr5Pq1dI19fEPKT 2rMCLmCYDJr56+SKPXA3ewPatEeZzCsUyhRjhMVnwUCKT+rGI07U5QBgqDjIQd8rQegl JwkZiKV/TVCxR8IsGdLdG2yx6QAi3NYvcQQU78QJ4gUgTj9OJKww63DgJIvBTe1bG0hh oLsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=vg66exnkv8n8lyWIZ3vwDm68jUS+rEl5quzUimxMN5c=; b=GvO1KW9XvcZ3lk5K11uP6L/PLgCk5++uHzFGWl5DJzSEfh0Lrm+wfhpfYK9BSNCKFO KacBPQd6lf83+LXPhSfVI1fNymewr+TMVZwtg1xoqGg92BtkkCX8PRwAvRNb+zOY5CoF 8ZO7bjb4xpm7rFmJrWLvmQhvzERNC4y1jzvYfKuUxyKoY3lD4tFlvR5kjpyycoEtnzv8 sB6xjYh3NC9KMpv57bIjbTO+tdmS0LsyPzkHmBALntHLiRvWxooIHN4+9Hc48jyZ1xpn 4yW4Dgdc1o8AFu7QCv8ZbN9wkfKGDqMEwTSQoigthCMBVcL1tlOUQB8DKvuWiCsd258W Fuwg== X-Gm-Message-State: APjAAAUvZLJ5wkXY+lC0wSyEcs0VK3ZQxSBa5xMW9W0vv0C4pjHDIVqs 8pantlht0ZmupBHLrqfZ04rHmuAgbtE= X-Google-Smtp-Source: APXvYqzSK1HaF1xUSgveLWsq9mO1g7VSOMHJs3lHoplXT2Ohby6fXoRLgMfC/4UBS0vsaBDwQGZtNA== X-Received: by 2002:a1c:ef14:: with SMTP id n20mr2810615wmh.89.1568711685843; Tue, 17 Sep 2019 02:14:45 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id c6sm2200022wrb.60.2019.09.17.02.14.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 02:14:44 -0700 (PDT) Date: Tue, 17 Sep 2019 10:14:42 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: "ard.biesheuvel@linaro.org" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , Laszlo Ersek , "Gao, Liming" , "Gao, Zhichao" Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types Message-ID: <20190917091442.GC24787@bivouac.eciton.net> References: <20190917061912.17420-1-zhichao.gao@intel.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Tue, Sep 17, 2019 at 07:17:27AM +0000, Zhang, Shenglei wrote: > That's my mistake to push the broken patch(0d85e67714e31e0dbe4241ab2ebb7c423aba174d). > This patch only updates the file guid, which I thought has no risk. So I didn’t check the build result. > I should double check the new guid used in the file. Determining what affects build and not is something humans are very bad at and computers are very good at. So you should build check every patch you submit to the list, no matter how trivial. In normal circumstances, so should the maintainers before pushing the patch. We now have a commit in the tree known to break the build of pretty much all ARM/AARCH64 platforms. This will be very unpleasant for future bisect. Best Regards, Leif