From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=xAKkP8Ty; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Tue, 17 Sep 2019 07:03:22 -0700 Received: by mail-wr1-f68.google.com with SMTP id l11so3310083wrx.5 for ; Tue, 17 Sep 2019 07:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PsYsNlnrN3YfDORhGV49nhAimLrOZVJ+EDuCpA/AshU=; b=xAKkP8TyZOE/CgkoKFEhzxKMGDPyTkv5GS/vTGMB9cGO2JlXyCDdECmaAWt9FQQVxh MjyUMY0/mvJy9vptjn6c7Y5m52TyvXIjfA3lzEgVDvI6uX7m/Evm1UaU69Yo4CeBcQKq j8ldejjtsMM7DCIcEpCmZPztCmfhCd5pt2KHNJhGyaQAp3qqwHZx9riIJ5quKUu2/mms wG40VzRSIG+pK3G2jGUkzxG5kz8n8Ir0on0Em3DlC4OZGMWxgHhZRgKz/tb6Pr2ggY1n KVSCB1xc79uqS6chFBMwoPuhEWDMejrewN9KRxzyv007riP6ehvCet4G6eab8PSAXuHT yzGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PsYsNlnrN3YfDORhGV49nhAimLrOZVJ+EDuCpA/AshU=; b=FQJXXBV6ONt9Ui5miTXSAwXaq1BiAcDcPEY7ovyuJcQ82b9CKKdmVpSe/ZQl3w5Yeq UqfkiEEicrZlY57BTOoUA2C/uQ2oYelIDeaCYZsGqFsweLGddhGWsxznTP953DxYvaRy 7T5MdrjguJYA/vSHordOOv3vaixxRahll05luCo5y9p9KQSCXW17sLI5LIJFtQXonk1y T4TrNM6u49myGxiJJa7ipEPazVgoB0UCp5qheIpkaXDZ0Y09yZv+ewPbmX/nNlpNwjDu XyWJvx73kA1VMzyGOPbUqFXD56RiZ7YUeEUn2iOfX0FAtlW3QnXWD6mj/quV8GfUFP77 UlmA== X-Gm-Message-State: APjAAAVvugBhV45Lx8RZNr0KSTqffTxi8SZPkVzhX1vQcMfxTQD1THs9 7R3Lm0+mQRXE3ijm3WY1rpIK6Q== X-Google-Smtp-Source: APXvYqxJJb8Mx65xzyRNFwtn47ZR9MZwIEP/RA/UHZJYY6VdAB+4Hi6Yl9KK1HbYLvyU18LxWXAtjw== X-Received: by 2002:adf:f081:: with SMTP id n1mr3132761wro.273.1568729000342; Tue, 17 Sep 2019 07:03:20 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id v2sm4189862wmf.18.2019.09.17.07.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 07:03:19 -0700 (PDT) Date: Tue, 17 Sep 2019 15:03:18 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package. Message-ID: <20190917140318.GF28454@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-2-git-send-email-abner.chang@hpe.com> <20190904175129.GO29255@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 16, 2019 at 05:15:08AM +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Thursday, September 5, 2019 1:51 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: > > RiscVPkg: RISC-V processor package. > > > > Hi Abner, > > > > On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote: > > > - Add RiscVPkg package which provides RISC-V processor related drivers > > and libraries. > > > - Support RISC-V OpenSBI and RISC-V platforms > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Abner Chang > > > --- > > > RiscVPkg/RiscVPkg.dec | 57 > > +++++++++++++++++++++++++++++++++++++++++++++ > > > RiscVPkg/RiscVPkg.uni | Bin 0 -> 1718 bytes > > > RiscVPkg/RiscVPkgExtra.uni | Bin 0 -> 1374 bytes > > > 3 files changed, 57 insertions(+) > > > create mode 100644 RiscVPkg/RiscVPkg.dec create mode 100644 > > > RiscVPkg/RiscVPkg.uni create mode 100644 RiscVPkg/RiscVPkgExtra.uni > > > > > > diff --git a/RiscVPkg/RiscVPkg.dec b/RiscVPkg/RiscVPkg.dec new file > > > mode 100644 index 0000000..acf71fe > > > --- /dev/null > > > +++ b/RiscVPkg/RiscVPkg.dec > > > @@ -0,0 +1,57 @@ > > > +## @file RiscVPkg.dec > > > +# This Package provides UEFI RISC-V modules and libraries. > > > +# > > > +# Copyright (c) 2016 - 2019, Hewlett Packard Enterprise Development > > > +LP. All rights reserved.
# # This program and the accompanying > > > +materials are licensed and made available under # the terms and > > > +conditions of the BSD License which accompanies this distribution. > > > +# The full text of the license may be found at # > > > +INVALID URI REMOVED > > 3A__opensource.org_li > > > +censes_bsd- > > 2Dlicense.php&d=DwIBAg&c=C5b8zRQO1miGmBeVZ2LFWg&r=_SN6FZBN > > > > > +4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=1PSVwg69_Y8lpR9wdv1TN7 > > kg2brsZYR > > > +sj5F_hpyPrv4&s=USJlvms7O9ZDAsM0U- > > FGng8i0uJkAMNbDEp1S_C4p0A&e= > > > +# > > > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" > > > +BASIS, # WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > > EITHER EXPRESS OR IMPLIED. > > > +# > > > +## > > > + > > > +[Defines] > > > + DEC_SPECIFICATION = 0x00010005 > > > + PACKAGE_NAME = RiscVPkg > > > + PACKAGE_UNI_FILE = RiscVPkg.uni > > > + PACKAGE_GUID = 993C7CAC-C87C-4F08-A2CF-AD3AABA859D1 > > > + PACKAGE_VERSION = 0.1 > > > + > > > +[Includes] > > > + Include > > > + opensbi/include > > > + opensbi/lib/utils/libfdt > > > > This one is something we need to sort out (together). Having multiple copies > > of libfdt in the tree is not on. > > > > I personally think we need a longer-term encapsulation of libfdt that doesn't > > mess up the coding style. But until then, I would be much happier if you used > > the half measure we have in EmbeddedPkg: > > EmbeddedPkg/Library/FdtLib/ and EmbeddedPkg/Include/. > > We may not go this way due to everything is from OpenSBI and we > don't want to maintain the difference to open source OpenSBI. Just > take what OpenSBI provides. If libfdt was a very quickly changing project, I might agree with you. But it is not. It is a very simple piece of code that performs a small set of operations on a very well defined structured encapsulation format. So please use the one from EmbeddedPkg. On the very unlikely occurrence that you require functionality not provided by the version in there, we can update it. / Leif