From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=fmk3ZvoA; spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Tue, 17 Sep 2019 07:12:01 -0700 Received: by mail-wm1-f67.google.com with SMTP id r195so3383365wme.2 for ; Tue, 17 Sep 2019 07:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fofM2zFX+QH9M4ya/yFY/fffbG+tC18jZyP2gXfza9M=; b=fmk3ZvoA2aC53KlVwYe4G2asSPsOMqQDRfLdnRNN2jq47OpEivdGJ0cKc7krD/m8Cf QybW69tPFdTuhdDpfvbBz9ckcwugD8RxGPXxuSQECYjmZeHZUUoyJMHxPEQWDOrJq2BF BEeFGd8u47v9dgUyHxyuS65YcExbErnY6OYV60PeWxzbmWuwbEA4UJfm5SaSo+UMwyWQ 0zwf9nxFq9xNfpmHxR/aWkCX6VE06tuGOVdIZoLc6HC6sWhSFMmN7ETzo17iulIwqRZE x2Nn7jJnVCpFZ5GvPala6LMyx8OnTwvJOpTyqYNGI2JNogEHilQM4V4sHEZnorDi02f4 DAMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fofM2zFX+QH9M4ya/yFY/fffbG+tC18jZyP2gXfza9M=; b=UaJth6Iqeao5JhKfSnals6u0mkXPfaQVlzKMHh6n6UCCPB0mPdacFbM7Zzrml3UjHW LwWbY1lw4B5MLSQYSGBY6mAp2uq9qoHiyYWqMmYcugt7MQyFAr5Eameoo9ZV7pCi+lpt k+5ockIggZtDfcBkBqS7QOdnaw5BeqyFv8mWUKKIBrjq8qRgW9/eyHfQU39lnqq20rf3 Ea1FjapoLTIbtQDqmJsAtYKWzmPmixe3dUg8gctqBinmUbOS94KFZmGARuvvC6wZODhZ kyB4XLYrbXOJb19iOJHz3vFmIs3Aq8BBaflc6yvs7AoUMZ/hOG+77ttkgjeD3jcLY1/g f9HQ== X-Gm-Message-State: APjAAAWoo43ZV24SFYt+9J6S3aJzXVzLirsG/NWlCuHtJpbB8YagIa56 55FjdMN1iFUGhN4td0dc+ZPXcA== X-Google-Smtp-Source: APXvYqw3tntmleFi3xGKbGs4hDNCjHNXyuRC3rcnuM0UIF2kCHdgkkEAB3yRCQdBSWoN8EONFW//7g== X-Received: by 2002:a1c:ed16:: with SMTP id l22mr3773608wmh.172.1568729519317; Tue, 17 Sep 2019 07:11:59 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d28sm3359179wrb.95.2019.09.17.07.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Sep 2019 07:11:58 -0700 (PDT) Date: Tue, 17 Sep 2019 15:11:57 +0100 From: "Leif Lindholm" To: "Chang, Abner (HPS SW/FW Technologist)" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 04/22]: MdePkg/Include: RISC-V definitions. Message-ID: <20190917141157.GG28454@bivouac.eciton.net> References: <1567593797-26216-1-git-send-email-abner.chang@hpe.com> <1567593797-26216-5-git-send-email-abner.chang@hpe.com> <20190904204024.GR29255@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Sep 16, 2019 at 05:31:40AM +0000, Chang, Abner (HPS SW/FW Technologist) wrote: > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Thursday, September 5, 2019 4:40 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 04/22]: > > MdePkg/Include: RISC-V definitions. > > > > On Wed, Sep 04, 2019 at 06:42:59PM +0800, Abner Chang wrote: > > > Add RISC-V processor related definitions. > > > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > Signed-off-by: Abner Chang > > > --- > > > MdePkg/Include/IndustryStandard/PeImage.h | 14 +- > > > MdePkg/Include/Library/BaseLib.h | 67 ++++++ > > > MdePkg/Include/Protocol/DebugSupport.h | 55 +++++ > > > MdePkg/Include/Protocol/PxeBaseCode.h | 8 + > > > MdePkg/Include/RiscV64/ProcessorBind.h | 336 > > ++++++++++++++++++++++++++++++ > > > MdePkg/Include/Uefi/UefiBaseType.h | 25 +++ > > > MdePkg/Include/Uefi/UefiSpec.h | 11 + > > > 7 files changed, 513 insertions(+), 3 deletions(-) create mode > > > 100644 MdePkg/Include/RiscV64/ProcessorBind.h > > > > > > diff --git a/MdePkg/Include/IndustryStandard/PeImage.h > > > b/MdePkg/Include/IndustryStandard/PeImage.h > > > index 720bb08..47796b2 100644 > > > --- a/MdePkg/Include/IndustryStandard/PeImage.h > > > +++ b/MdePkg/Include/IndustryStandard/PeImage.h > > > @@ -9,6 +9,8 @@ > > > > > > Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > reserved.
Portions copyright (c) 2008 - 2009, Apple Inc. All > > > rights reserved.
> > > +Portions Copyright (c) 2016, Hewlett Packard Enterprise Development > > > +LP. All rights reserved.
> > > + > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > **/ > > > @@ -34,6 +36,9 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > #define IMAGE_FILE_MACHINE_X64 0x8664 > > > #define IMAGE_FILE_MACHINE_ARMTHUMB_MIXED 0x01c2 > > > #define IMAGE_FILE_MACHINE_ARM64 0xAA64 > > > +#define IMAGE_FILE_MACHINE_RISCV32 0x5032 > > > +#define IMAGE_FILE_MACHINE_RISCV64 0x5064 > > > +#define IMAGE_FILE_MACHINE_RISCV128 0x5128 > > > > > > // > > > // EXE file formats > > > @@ -478,9 +483,9 @@ typedef struct { > > > /// > > > #define EFI_IMAGE_SIZEOF_BASE_RELOCATION 8 > > > > > > -// > > > -// Based relocation types. > > > -// > > > +/// > > > +/// Based relocation types. > > > +/// > > > > I don't know if this change to the comment block is a wonky rebase or > > whatever, but please drop it. > > No, I revised it to three back slash because most of comment block > use three back slash. It is always appreciated when people provide style fixes, but they should be provided as separate patches. In this case I don't see the value in doing that however, since // is the comment format specified by the coding standars. A separate patch fixing the existing incorrect ones would be preferable (but not important). Best Regards, Leif