From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=CSI81d4e;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by groups.io with SMTP; Tue, 17 Sep 2019 08:27:55 -0700
Received: by mail-wm1-f67.google.com with SMTP id g207so3978828wmg.5
        for <devel@edk2.groups.io>; Tue, 17 Sep 2019 08:27:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=kANv23IuP5FTNps/A3wjbgQWlaQOsXQemthl5kTlK24=;
        b=CSI81d4ewWP2JE7kZrFuosT/nLrZ2VxHXl2NkR50usOyzKEu3Z9lzE07VZghNKvBOk
         8YDb75FK5NqA3LTNZM2lRbprp7XMgHS0EMJPX+usqoDIM7X7yelflF48gdXELCHMv2Ui
         +iL5wQoCONWnDBwNVBQkDc4Bbprah7SNgXyHqkDb14EVFpT81t/quwlMTI8S6C17OgSd
         gX85+tVxO4AU040/nmSvYimJc6QwcUVEMQGDut3ZNUWnJu2QcF0EpzNIXfSW545nkh83
         NB1Vo6GuSyQvWF9+BnWJm6+bfuFBt81jMjMW0zwry/t10xv7/86CpPM1xDBIPkj2EoLJ
         0gGA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=kANv23IuP5FTNps/A3wjbgQWlaQOsXQemthl5kTlK24=;
        b=cv1i8DTJMz64Bt3QQc7NNmLucvGBbgBDmr7l5BM8VYsN7fCwt9jUSp5lX8UMgmYReB
         Q6c+ReiznnRaN0iKPhAdDt8pmf06HCEmzvbXLEr4h6aeyMxWRX46Dgf2NHNakxo8uKQd
         SNmEsygwCqrKU7C9d+PuJgaFZDEOSMP4jnwn7jBr0vmA92ILfOgYexW1e56ttZgca2bJ
         cVIRLUT/RNH9x2Z8R402rGpxugVFC+kvEevCpe16gKzpwO/RHa8XpLvX3Sfi6Xr9d5cl
         HS80aG0JKeCWzOJrOG3dHTVYhuPxrV+etB91nFwg9NhQ9Uy0Do39jgZq+2Isel18W2U+
         KJ9w==
X-Gm-Message-State: APjAAAWimiwpzGHAMV3DbDDOd73qAGmzEW+/QySDbYTrGinedeYxfgrG
	SjeInIVEoueApvAmgoTYBhf/6Q==
X-Google-Smtp-Source: APXvYqzzdyscsNuFzWY5cDWsMAv88RZnOSZ6cP61gd8DB7kQHP3PU2mtI1mSzCjj4A5INumF/g8mqw==
X-Received: by 2002:a1c:60c1:: with SMTP id u184mr3925215wmb.32.1568734073794;
        Tue, 17 Sep 2019 08:27:53 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id y13sm5800764wrg.8.2019.09.17.08.27.52
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 17 Sep 2019 08:27:53 -0700 (PDT)
Date: Tue, 17 Sep 2019 16:27:51 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Andy Hayes <andy.hayes@displaylink.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH v1 1/1] Drivers/DisplayLink/DisplayLinkPkg DisplayLinkGop
Message-ID: <20190917152751.GM28454@bivouac.eciton.net>
References: <1568187713-4492-1-git-send-email-andy.hayes@displaylink.com>
 <1568187713-4492-2-git-send-email-andy.hayes@displaylink.com>
MIME-Version: 1.0
In-Reply-To: <1568187713-4492-2-git-send-email-andy.hayes@displaylink.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Sep 11, 2019 at 07:42:03AM +0000, Andy Hayes wrote:
> Corrected initialisation of one of data structures used to transmit USB
> control messages. Mistake had no practical effects but fixing to be on safe
> side.

So, was the only request used index 0? Or why didn't this cause an
issue? Nevertheless, a clear fix.

> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Andy Hayes <andy.hayes@displaylink.com>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
Pushed as 958aaf600728.

/
    Leif

> ---
>  Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> index 252293da39d4..9871ab0378ce 100644
> --- a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> +++ b/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/UsbTransfer.c
> @@ -107,7 +107,7 @@ DlUsbSendControlWriteMessage (
>    UINT32                 UsbStatus;
>    EFI_USB_DEVICE_REQUEST UsbRequest;
>  
> -  ZeroMem (&Request, sizeof (Request));
> +  ZeroMem (&UsbRequest, sizeof (UsbRequest));
>    UsbRequest.RequestType = USB_REQ_TYPE_VENDOR | USB_TARGET_INTERFACE;
>    UsbRequest.Index = Device->InterfaceDescriptor.InterfaceNumber;
>    UsbRequest.Request = Request;
> -- 
> 1.8.3.1
>