From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:20 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30CA618C426E; Tue, 17 Sep 2019 19:50:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25FFA600C4; Tue, 17 Sep 2019 19:50:18 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Siyuan Fu Subject: [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() Date: Tue, 17 Sep 2019 21:49:18 +0200 Message-Id: <20190917194935.24322-19-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Tue, 17 Sep 2019 19:50:20 +0000 (UTC) Content-Transfer-Encoding: quoted-printable NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). NetLibGetMacAddress() only uses the return value ("SnpHandle") for a NULL-check. Fix the type of "SnpHandle". This patch is a no-op. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek --- Notes: lightly tested: MAC strings are displayed in UiApp NetworkPkg/Library/DxeNetLib/DxeNetLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c b/NetworkPkg/Librar= y/DxeNetLib/DxeNetLib.c index 8e2f720666ea..a39c20be3d34 100644 --- a/NetworkPkg/Library/DxeNetLib/DxeNetLib.c +++ b/NetworkPkg/Library/DxeNetLib/DxeNetLib.c @@ -2182,7 +2182,7 @@ NetLibGetMacAddress ( EFI_SIMPLE_NETWORK_MODE SnpModeData; EFI_MANAGED_NETWORK_PROTOCOL *Mnp; EFI_SERVICE_BINDING_PROTOCOL *MnpSb; - EFI_HANDLE *SnpHandle; + EFI_HANDLE SnpHandle; EFI_HANDLE MnpChildHandle; =20 ASSERT (MacAddress !=3D NULL); --=20 2.19.1.3.g30247aa5d201