From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:24 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7381810DCC81; Tue, 17 Sep 2019 19:50:24 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 69450600C4; Tue, 17 Sep 2019 19:50:23 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Jiaxin Wu , Siyuan Fu Subject: [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list Date: Tue, 17 Sep 2019 21:49:21 +0200 Message-Id: <20190917194935.24322-22-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Tue, 17 Sep 2019 19:50:24 +0000 (UTC) Content-Transfer-Encoding: quoted-printable The SockFreeFoo() callback function for NetbufFromExt() has to match the NET_VECTOR_EXT_FREE prototype, which takes a (VOID*) as callback argument (Arg). EFI_EVENT has nothing to do with NET_VECTOR_EXT_FREE. Fix the SockFreeFoo() parameter list. This change is a no-op in practice. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Laszlo Ersek --- Notes: build-tested only NetworkPkg/TcpDxe/SockImpl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/NetworkPkg/TcpDxe/SockImpl.c b/NetworkPkg/TcpDxe/SockImpl.c index f5e01771e2a8..fb28e2ed40d3 100644 --- a/NetworkPkg/TcpDxe/SockImpl.c +++ b/NetworkPkg/TcpDxe/SockImpl.c @@ -67,13 +67,13 @@ SockBufNext ( /** User provided callback function for NetbufFromExt. =20 - @param[in] Event The Event this notify function registered to, igno= red. + @param[in] Arg The Arg parameter forwarded by NetbufFromExt(). Ig= nored. =20 **/ VOID EFIAPI SockFreeFoo ( - IN EFI_EVENT Event + IN VOID *Arg ) { return; --=20 2.19.1.3.g30247aa5d201