From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:28 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B5ED73018ECE; Tue, 17 Sep 2019 19:50:27 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC6A4600C4; Tue, 17 Sep 2019 19:50:26 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Jordan Justen Subject: [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call Date: Tue, 17 Sep 2019 21:49:23 +0200 Message-Id: <20190917194935.24322-24-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 17 Sep 2019 19:50:27 +0000 (UTC) Content-Transfer-Encoding: quoted-printable The SignalEvent() boot service takes an EFI_EVENT, not an (EFI_EVENT*). Fix the call in the notification function of "EFI_SIMPLE_NETWORK_PROTOCOL.WaitForPacket". This is an actual bug. The reason it's never been triggered is likely tha= t the "SNP.WaitForPacket" event is rarely waited for by applications -- edk= 2 itself has zero instances of that, for example. Cc: Ard Biesheuvel Cc: Jordan Justen Signed-off-by: Laszlo Ersek --- Notes: build-tested only OvmfPkg/VirtioNetDxe/Events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/VirtioNetDxe/Events.c b/OvmfPkg/VirtioNetDxe/Events.= c index 620910774bc5..83e96e5e5d91 100644 --- a/OvmfPkg/VirtioNetDxe/Events.c +++ b/OvmfPkg/VirtioNetDxe/Events.c @@ -58,7 +58,7 @@ VirtioNetIsPacketAvailable ( MemoryFence (); =20 if (Dev->RxLastUsed !=3D RxCurUsed) { - gBS->SignalEvent (&Dev->Snp.WaitForPacket); + gBS->SignalEvent (Dev->Snp.WaitForPacket); } } =20 --=20 2.19.1.3.g30247aa5d201