From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:50:34 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1275337E79; Tue, 17 Sep 2019 19:50:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id CAA8A600C8; Tue, 17 Sep 2019 19:50:32 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Chao Zhang , Jian Wang , Jiewen Yao Subject: [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration Date: Tue, 17 Sep 2019 21:49:27 +0200 Message-Id: <20190917194935.24322-28-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 17 Sep 2019 19:50:34 +0000 (UTC) Content-Transfer-Encoding: quoted-printable EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration", similarly to gBS->RegisterProtocolNotify(). We should pass the address of an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT just happens to be specified as (VOID*), and has nothing to do with the registration. This change is a no-op in practice; it's a semantic improvement. Cc: Chao Zhang Cc: Jian Wang Cc: Jiewen Yao Signed-off-by: Laszlo Ersek --- Notes: build-tested only SecurityPkg/HddPassword/HddPasswordDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/HddPassword/HddPasswordDxe.c b/SecurityPkg/HddPa= ssword/HddPasswordDxe.c index b0d795b6597f..051e64091d7f 100644 --- a/SecurityPkg/HddPassword/HddPasswordDxe.c +++ b/SecurityPkg/HddPassword/HddPasswordDxe.c @@ -2770,7 +2770,7 @@ HddPasswordDxeInit ( { EFI_STATUS Status; HDD_PASSWORD_DXE_PRIVATE_DATA *Private; - EFI_EVENT Registration; + VOID *Registration; EFI_EVENT EndOfDxeEvent; EDKII_VARIABLE_LOCK_PROTOCOL *VariableLock; =20 --=20 2.19.1.3.g30247aa5d201