From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:49:52 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B084F693C8; Tue, 17 Sep 2019 19:49:51 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id A744C600C4; Tue, 17 Sep 2019 19:49:50 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Subject: [PATCH 02/35] EmbeddedPkg: add missing EFIAPI calling convention specifiers Date: Tue, 17 Sep 2019 21:49:02 +0200 Message-Id: <20190917194935.24322-3-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 17 Sep 2019 19:49:51 +0000 (UTC) Content-Transfer-Encoding: quoted-printable This patch is unrelated to the rest of the series; it just makes sure tha= t "EmbeddedPkg/EmbeddedPkg.dsc" builds for all platforms advertised in SUPPORTED_ARCHITECTURES (in particular, X64). No functional changes. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Laszlo Ersek --- Notes: build-tested only EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h | 32 +++++++++++= ++++----- EmbeddedPkg/GdbStub/GdbStubInternal.h | 9 ++++++ EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c | 1 + EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c | 1 + EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 8 +++++ EmbeddedPkg/MetronomeDxe/Metronome.c | 1 + 6 files changed, 44 insertions(+), 8 deletions(-) diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h b/EmbeddedP= kg/Drivers/SataSiI3132Dxe/SataSiI3132.h index e3db0821c38f..20636574c271 100644 --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h @@ -205,7 +205,9 @@ SataSiI3132DriverBindingStop ( IN EFI_HANDLE *ChildHandleBuffer ); =20 -EFI_STATUS SiI3132AtaPassThruCommand ( +EFI_STATUS +EFIAPI +SiI3132AtaPassThruCommand ( IN SATA_SI3132_INSTANCE *pSataSiI3132Instance, IN SATA_SI3132_PORT *pSataPort, IN UINT16 PortMultiplierPort, @@ -216,7 +218,9 @@ EFI_STATUS SiI3132AtaPassThruCommand ( /** * EFI ATA Pass Thru Protocol */ -EFI_STATUS SiI3132AtaPassThru ( +EFI_STATUS +EFIAPI +SiI3132AtaPassThru ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, IN UINT16 PortMultiplierPort, @@ -224,37 +228,49 @@ EFI_STATUS SiI3132AtaPassThru ( IN EFI_EVENT Event OPTIONAL ); =20 -EFI_STATUS SiI3132GetNextPort ( +EFI_STATUS +EFIAPI +SiI3132GetNextPort ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN OUT UINT16 *Port ); =20 -EFI_STATUS SiI3132GetNextDevice ( +EFI_STATUS +EFIAPI +SiI3132GetNextDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, IN OUT UINT16 *PortMultiplierPort ); =20 -EFI_STATUS SiI3132BuildDevicePath ( +EFI_STATUS +EFIAPI +SiI3132BuildDevicePath ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, IN UINT16 PortMultiplierPort, IN OUT EFI_DEVICE_PATH_PROTOCOL **DevicePath ); =20 -EFI_STATUS SiI3132GetDevice ( +EFI_STATUS +EFIAPI +SiI3132GetDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN EFI_DEVICE_PATH_PROTOCOL *DevicePath, OUT UINT16 *Port, OUT UINT16 *PortMultiplierPort ); =20 -EFI_STATUS SiI3132ResetPort ( +EFI_STATUS +EFIAPI +SiI3132ResetPort ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port ); =20 -EFI_STATUS SiI3132ResetDevice ( +EFI_STATUS +EFIAPI +SiI3132ResetDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, IN UINT16 PortMultiplierPort diff --git a/EmbeddedPkg/GdbStub/GdbStubInternal.h b/EmbeddedPkg/GdbStub/= GdbStubInternal.h index b8346d7a545f..b08159302cfa 100644 --- a/EmbeddedPkg/GdbStub/GdbStubInternal.h +++ b/EmbeddedPkg/GdbStub/GdbStubInternal.h @@ -323,6 +323,7 @@ SendError ( Send 'OK' when the function is done executing successfully. **/ VOID +EFIAPI SendSuccess ( VOID ); @@ -332,6 +333,7 @@ SendSuccess ( Send empty packet to specify that particular command/functionality is n= ot supported. **/ VOID +EFIAPI SendNotSupported ( VOID ); @@ -353,6 +355,7 @@ ReadNthRegister ( @param SystemContext Register content at time of the exce= ption **/ VOID +EFIAPI ReadGeneralRegisters ( IN EFI_SYSTEM_CONTEXT SystemContext ); @@ -364,6 +367,7 @@ ReadGeneralRegisters ( @param InBuffer This is the input buffer received from g= db server **/ VOID +EFIAPI WriteNthRegister ( IN EFI_SYSTEM_CONTEXT SystemContext, IN CHAR8 *InBuffer @@ -377,6 +381,7 @@ WriteNthRegister ( **/ =20 VOID +EFIAPI WriteGeneralRegisters ( IN EFI_SYSTEM_CONTEXT SystemContext, IN CHAR8 *InBuffer @@ -391,6 +396,7 @@ WriteGeneralRegisters ( @param *PacketData Pointer to Payload data for the packet **/ VOID +EFIAPI ReadFromMemory ( IN CHAR8 *PacketData ); @@ -404,6 +410,7 @@ ReadFromMemory ( @param PacketData Pointer to Payload data for the packet **/ VOID +EFIAPI WriteToMemory ( IN CHAR8 *PacketData ); @@ -418,6 +425,7 @@ WriteToMemory ( **/ =20 VOID +EFIAPI ContinueAtAddress ( IN EFI_SYSTEM_CONTEXT SystemContext, IN CHAR8 *PacketData @@ -432,6 +440,7 @@ ContinueAtAddress ( @param PacketData Pointer to Payload data for the packet **/ VOID +EFIAPI SingleStep ( IN EFI_SYSTEM_CONTEXT SystemContext, IN CHAR8 *PacketData diff --git a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c b/Embedd= edPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c index c250844eda74..08bba1bbf111 100644 --- a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c +++ b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c @@ -174,6 +174,7 @@ RemoveSpcrTable ( =20 STATIC VOID +EFIAPI OnReadyToBoot ( IN EFI_EVENT Event, IN VOID *Context diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c b/EmbeddedPkg/Dr= ivers/Lan9118Dxe/Lan9118Dxe.c index a0fca4d6a335..2138f7576bec 100644 --- a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c +++ b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c @@ -34,6 +34,7 @@ LAN9118_DEVICE_PATH Lan9118PathTemplate =3D { ** */ EFI_STATUS +EFIAPI Lan9118DxeEntry ( IN EFI_HANDLE Handle, IN EFI_SYSTEM_TABLE *SystemTable diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c b/Em= beddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c index f6a723adfb28..0e2905c1ebb0 100644 --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c @@ -39,6 +39,7 @@ GetSataDevice ( } =20 EFI_STATUS +EFIAPI SiI3132AtaPassThruCommand ( IN SATA_SI3132_INSTANCE *SataSiI3132Instance, IN SATA_SI3132_PORT *SataPort, @@ -310,6 +311,7 @@ SiI3132AtaPassThruCommand ( =20 **/ EFI_STATUS +EFIAPI SiI3132AtaPassThru ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, @@ -371,6 +373,7 @@ SiI3132AtaPassThru ( =20 **/ EFI_STATUS +EFIAPI SiI3132GetNextPort ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN OUT UINT16 *Port @@ -442,6 +445,7 @@ SiI3132GetNextPort ( =20 **/ EFI_STATUS +EFIAPI SiI3132GetNextDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, @@ -523,6 +527,7 @@ SiI3132GetNextDevice ( =20 **/ EFI_STATUS +EFIAPI SiI3132BuildDevicePath ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, @@ -601,6 +606,7 @@ SiI3132BuildDevicePath ( port number does not exist. **/ EFI_STATUS +EFIAPI SiI3132GetDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN EFI_DEVICE_PATH_PROTOCOL *DevicePath, @@ -717,6 +723,7 @@ SiI3132HwResetPort ( =20 **/ EFI_STATUS +EFIAPI SiI3132ResetPort ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port @@ -772,6 +779,7 @@ SiI3132ResetPort ( =20 **/ EFI_STATUS +EFIAPI SiI3132ResetDevice ( IN EFI_ATA_PASS_THRU_PROTOCOL *This, IN UINT16 Port, diff --git a/EmbeddedPkg/MetronomeDxe/Metronome.c b/EmbeddedPkg/Metronome= Dxe/Metronome.c index 579332169507..13db25168fac 100644 --- a/EmbeddedPkg/MetronomeDxe/Metronome.c +++ b/EmbeddedPkg/MetronomeDxe/Metronome.c @@ -110,6 +110,7 @@ EFI_HANDLE gMetronomeHandle =3D NULL; =20 **/ EFI_STATUS +EFIAPI MetronomeInitialize ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable --=20 2.19.1.3.g30247aa5d201