From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 17 Sep 2019 12:49:53 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 242C4300CB26; Tue, 17 Sep 2019 19:49:53 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-37.rdu2.redhat.com [10.10.120.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B0E3600C4; Tue, 17 Sep 2019 19:49:51 +0000 (UTC) From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Subject: [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call Date: Tue, 17 Sep 2019 21:49:03 +0200 Message-Id: <20190917194935.24322-4-lersek@redhat.com> In-Reply-To: <20190917194935.24322-1-lersek@redhat.com> References: <20190917194935.24322-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Tue, 17 Sep 2019 19:49:53 +0000 (UTC) Content-Transfer-Encoding: quoted-printable - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: IN OUT EFI_HANDLE *ChildHandle - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: IN EFI_HANDLE ChildHandle Fix the DestroyChild() call in TcpFastbootTransportStop(). This is an actual bugfix; I don't know why the current code doesn't crash= . Perhaps the function is never reached in practice? (It could be tied to a= n error path.) Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Laszlo Ersek --- Notes: build-tested only EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.= c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootT= ransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/Fastbo= otTransportTcp.c index 29f23a82c75f..34f9ba74e4db 100644 --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTranspor= tTcp.c +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTranspor= tTcp.c @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( Status =3D mTcpListener->Configure (mTcpListener, NULL); ASSERT_EFI_ERROR (Status); =20 - Status =3D mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcp= Handle); + Status =3D mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpH= andle); =20 // Free any data the user didn't pick up Entry =3D (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead)= ; --=20 2.19.1.3.g30247aa5d201