public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination
@ 2019-09-18  2:38 xianhui liu
  2019-09-20  3:10 ` Eric Jin
       [not found] ` <15C606D26BDCC3CD.32767@groups.io>
  0 siblings, 2 replies; 3+ messages in thread
From: xianhui liu @ 2019-09-18  2:38 UTC (permalink / raw)
  To: devel; +Cc: Oleksiy, Supreeth Venkatesh, Eric Jin

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1942
avoid using EFI_VARIABLE_RUNTIME_ACCESS without
EFI_VARIABLE_BOOTSERVICE_ACCESS in AttrArray.

Cc: Oleksiy <oleksiyy@ami.com>
Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
Cc: Eric Jin <eric.jin@intel.com>
Signed-off-by: xianhui liu <xianhuix.liu@intel.com>
---
 .../BlackBoxTest/AuthVariableServicesBBTestConformance.c            | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
index a1d1c4c3..23b00e35 100644
--- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
+++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/AuthVariableServicesBBTestConformance.c
@@ -1,7 +1,7 @@
 /** @file
 
   Copyright 2006 - 2012 Unified EFI, Inc.<BR>
-  Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
+  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
 
   This program and the accompanying materials
   are licensed and made available under the terms and conditions of the BSD License
@@ -160,19 +160,16 @@ AuthVariableDERConfTest (
     //  For 1 attribute.
     //
     EFI_VARIABLE_NON_VOLATILE,
-    EFI_VARIABLE_RUNTIME_ACCESS,
     EFI_VARIABLE_BOOTSERVICE_ACCESS,
     EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
 
     //
     //  For 2 attributes.
     //
-    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS,
     EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS,
     EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
 
     EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS,
-    EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
 
     EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
 
@@ -180,7 +177,6 @@ AuthVariableDERConfTest (
     //  For 3 attributes.
     //
     EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS,
-    EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
     EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
     EFI_VARIABLE_RUNTIME_ACCESS | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_TIME_BASED_AUTHENTICATED_WRITE_ACCESS,
 
-- 
2.14.1.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-23  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-18  2:38 [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination xianhui liu
2019-09-20  3:10 ` Eric Jin
     [not found] ` <15C606D26BDCC3CD.32767@groups.io>
2019-09-23  8:03   ` [edk2-devel] " Eric Jin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox