From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@citrix.com header.s=securemail header.b=PPKSrVgc;
 spf=pass (domain: citrix.com, ip: 216.71.155.168, mailfrom: anthony.perard@citrix.com)
Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168])
 by groups.io with SMTP; Wed, 18 Sep 2019 02:32:45 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple;
  d=citrix.com; s=securemail; t=1568799164;
  h=date:from:to:cc:subject:message-id:references:
   mime-version:in-reply-to;
  bh=0DAmLFS/liuNkvXe6Nj6z17cs8FmhPriLkiFHpR0oJk=;
  b=PPKSrVgcI//kLU8U1kehZrLQX97pDUqKRGJjOnXTBgeqgXzK5//o/x4b
   Am71Je0NZ/mvWu3z6y/bvziryvHddlMrkkhwqCpEHLhQ/SRY63igdlRgO
   i5TeGjp+0NhK7l3RD464Csy8kjxcSsc9eFat4R3KAy5NFsPMWAJK8WwLj
   4=;
Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com
Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  anthony.perard@citrix.com) identity=pra;
  client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible
Received-SPF: Pass (esa5.hc3370-68.iphmx.com: domain of
  anthony.perard@citrix.com designates 162.221.158.21 as
  permitted sender) identity=mailfrom;
  client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133
  ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4
  ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88
  ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all"
Received-SPF: None (esa5.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@mail.citrix.com) identity=helo;
  client-ip=162.221.158.21; receiver=esa5.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="postmaster@mail.citrix.com";
  x-conformance=sidf_compatible
IronPort-SDR: V7CRykGfuAL5XHN3HvvA5gC+NCdJSn5UhIpuYxFI2YY55fRpLQj5JIviUWA9Zyt7dVc8tZ4KFj
 0cW7ChnvTUfnuvAD9D11Owkz9FfbXdbrsivri7nSHwHTSfsNsD7ZPo84QQTJXH6NDZupIi3fil
 ilnbxjazt0G1F4+xp56099aGEnhK9JOdV89cB//Zs6xJq9mqQ0DKRH6mV+REfpUKbg2Y7dvUhz
 sUJ9ZY8izeG2CUatoxZKIw48L+VgJeiDkDtgRExxWywQbL71nib4rCODnJvlec1VSOMoBbzn4+
 w78=
X-SBRS: 2.7
X-MesageID: 5919245
X-Ironport-Server: esa5.hc3370-68.iphmx.com
X-Remote-IP: 162.221.158.21
X-Policy: $RELAYED
X-IronPort-AV: E=Sophos;i="5.64,520,1559534400"; 
   d="scan'208";a="5919245"
Date: Wed, 18 Sep 2019 10:32:42 +0100
From: "Anthony PERARD" <anthony.perard@citrix.com>
To: Laszlo Ersek <lersek@redhat.com>
CC: edk2-devel-groups-io <devel@edk2.groups.io>, Ard Biesheuvel
	<ard.biesheuvel@linaro.org>, Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call
Message-ID: <20190918093242.GI1308@perard.uk.xensource.com>
References: <20190917194935.24322-1-lersek@redhat.com>
 <20190917194935.24322-23-lersek@redhat.com>
MIME-Version: 1.0
In-Reply-To: <20190917194935.24322-23-lersek@redhat.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Return-Path: anthony.perard@citrix.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Tue, Sep 17, 2019 at 09:49:22PM +0200, Laszlo Ersek wrote:
> Unlike the InstallMultipleProtocolInterfaces() boot service, which takes
> an (EFI_HANDLE*) as first parameter, the
> UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as
> first parameter.
> 
> This is an actual bug. It must have remained hidden until now because it's
> on an error path. Fix the UninstallMultipleProtocolInterfaces() call.
> 
> Cc: Anthony Perard <anthony.perard@citrix.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Julien Grall <julien.grall@arm.com>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Thanks,

-- 
Anthony PERARD