From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=qwq23adS; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 18 Sep 2019 09:44:02 -0700 Received: by mail-wr1-f66.google.com with SMTP id r5so97643wrm.12 for ; Wed, 18 Sep 2019 09:44:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=neGFSHyWTFtZ46Be5q/noBUAIUXwbFlnV/tEEPYTP4o=; b=qwq23adSq9ICYmk5vFdwNhtGHyiXRmrcazxO5LVvbFPQS7TcQpJKVmKmdr1/M4PWrg KbSq600lR2i9vABsdfPUTIvDbkfhMtzLfr/5Nsrc2HPA/TbiMurgKCCvgY+wILd/upGo O+p8SKrx5VQIWXWAWGYENVKL+7ShoZd3dTlqDEmvzaVm5ER1tCgxRThPcckRvGmt/Ef+ mRMHEPdh9e2VwzrzirrR8EQlTh7ai9AZcBDHkC2L3rayMUnqKk7XSxRvTLPWXJgSLQjc EBxq+L0XHDRweB6K+o0xIpK2gducZQtxabBDEzWTmVAyKHfiIuKbft5+fP5igfjvmmce le+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=neGFSHyWTFtZ46Be5q/noBUAIUXwbFlnV/tEEPYTP4o=; b=cAZBKjWqA5eXvdAiMPLjqPJgVNeEgPA+sUcs8bM6b/3Lr+3GjEQ7jO3LWMg7lwUCaS 7EpE6uumJB6X/qfLGtblEB0033hDWPEgxtIhvUIyH6G52y8sxt4TPRkA3vzoe5AUuADZ BnBdk6SYblvZIjwhDMgXtANgmb36AFc7N3WTbdCIr7p+dPiAwZ8eNdokJGr8hEKYFAVi ebazXfPH1lxgtEQ7pNqL+AqxITE8Tsg7Q9++jp8WHO+DJg5wyK6fK7A/BjglWtU4nNx1 Vyymsqbp+ScDcq4M6/c70le1+r+ib7SJcRH7nukuxmKK2kXFZ044C6dL8tgjj+Ki5ZnC Qmmg== X-Gm-Message-State: APjAAAWY6DSu01T81Jz9gccopDNZvKrN5cqRFvz16nSpL4HRh3nL9mpY kFln+AuY9in01lQ2dkNjLh4s2A== X-Google-Smtp-Source: APXvYqy0RpIjPusMlnemd1a/BKOZODOQ46N5x6hBGHJy0T7bRQxiVblIJBY0zQF6wRs9P7PCX0KAaQ== X-Received: by 2002:a5d:5229:: with SMTP id i9mr4091973wra.76.1568825040943; Wed, 18 Sep 2019 09:44:00 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y3sm6891462wmg.2.2019.09.18.09.43.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Sep 2019 09:44:00 -0700 (PDT) Date: Wed, 18 Sep 2019 17:43:58 +0100 From: "Leif Lindholm" To: Baptiste Gerondeau Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, liming.gao@intel.com, shenglei.zhang@intel.com Subject: Re: [PATCH 0/3] Arm builds on Visual Studio Message-ID: <20190918164358.GH28454@bivouac.eciton.net> References: MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Thanks Baptiste, Ard: I would appreciate if you could sanity check the syntax conversion in 2/3 - it looks correct to me. >>From my point of view, for the series: Reviewed-by: Leif Lindholm But we also need a nod from the MdePkg maintainers. / Leif On Wed, Sep 18, 2019 at 06:05:21PM +0200, Baptiste Gerondeau wrote: > EDIT: Resending the series since I mistakenly used the wrong email, > sorry ! > > We are currently making an effort to make ARM (and AARCH64 eventually) > builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). > > These 3 patches correspond to an effort to make the assembler work with > MSFT, which entails : > - Feeding MSFT the RVCT .asm files, since they share syntax > requirements. > - Fixing some instructions syntax in those .asm files, in order to make > them palatable for MSFT. > - Fixing some minor formatting issue in INF files, while we're at it. > > This set enables the assembler, meanwhile the C also require changes, > which will come in a set later. This set makes the RVCT toolchain family > and profiles obsolete, unblocking : > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750 > > As mentioned in the above bug, dropping RVCT would entail orphanating > the .asm files that powered the RVCT build. Since Visual Studio uses the > same file syntax, those can be reused to power the VS build. > > These patches have been tested on VS2019 (v15.9.11) and VS2017 (v16.0.1) > > Baptiste GERONDEAU (3): > ArmPkg/MdePkg : Unify INF files format > ARM/Assembler: Correct syntax from RVCT for MSFT > ARM/Assembler: Reuse RVCT assembler for MSFT build > > ArmPkg/Drivers/ArmGic/ArmGicLib.inf | 2 +- > ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm | 30 +++++++++++++++++------------- > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf | 2 +- > ArmPkg/Library/ArmExceptionLib/ArmRelocateExceptionLib.inf | 2 +- > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf | 2 +- > ArmPkg/Library/ArmLib/Arm/ArmV7Support.asm | 6 ++++-- > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 8 ++++---- > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 ++-- > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf | 2 +- > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 2 +- > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf | 2 +- > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 2 +- > ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 6 +++--- > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 6 +++--- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.asm | 18 +++++++++--------- > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf | 2 +- > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | 20 ++++++++++---------- > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +- > 21 files changed, 65 insertions(+), 59 deletions(-) > > -- > 2.23.0 >