public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 02/35] EmbeddedPkg: add missing EFIAPI calling convention specifiers
Date: Wed, 18 Sep 2019 18:41:38 +0100	[thread overview]
Message-ID: <20190918174138.GK28454@bivouac.eciton.net> (raw)
In-Reply-To: <20190917194935.24322-3-lersek@redhat.com>

On Tue, Sep 17, 2019 at 09:49:02PM +0200, Laszlo Ersek wrote:
> This patch is unrelated to the rest of the series; it just makes sure that
> "EmbeddedPkg/EmbeddedPkg.dsc" builds for all platforms advertised in
> SUPPORTED_ARCHITECTURES (in particular, X64).

Hmm, I'm nearly 100% sure I have tested that in the past, but it
certainly doesn't work with my GCC8 compiler.

> No functional changes.
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     build-tested only

Well, EFIAPI is either a no-op or required for proper functionality to
begin with, so...

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h        | 32 +++++++++++++++-----
>  EmbeddedPkg/GdbStub/GdbStubInternal.h                   |  9 ++++++
>  EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c     |  1 +
>  EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c             |  1 +
>  EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c |  8 +++++
>  EmbeddedPkg/MetronomeDxe/Metronome.c                    |  1 +
>  6 files changed, 44 insertions(+), 8 deletions(-)
> 
> diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
> index e3db0821c38f..20636574c271 100644
> --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
> +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SataSiI3132.h
> @@ -205,7 +205,9 @@ SataSiI3132DriverBindingStop (
>    IN EFI_HANDLE                  *ChildHandleBuffer
>    );
>  
> -EFI_STATUS SiI3132AtaPassThruCommand (
> +EFI_STATUS
> +EFIAPI
> +SiI3132AtaPassThruCommand (
>    IN     SATA_SI3132_INSTANCE             *pSataSiI3132Instance,
>    IN     SATA_SI3132_PORT                 *pSataPort,
>    IN     UINT16                           PortMultiplierPort,
> @@ -216,7 +218,9 @@ EFI_STATUS SiI3132AtaPassThruCommand (
>  /**
>   * EFI ATA Pass Thru Protocol
>   */
> -EFI_STATUS SiI3132AtaPassThru (
> +EFI_STATUS
> +EFIAPI
> +SiI3132AtaPassThru (
>    IN     EFI_ATA_PASS_THRU_PROTOCOL       *This,
>    IN     UINT16                           Port,
>    IN     UINT16                           PortMultiplierPort,
> @@ -224,37 +228,49 @@ EFI_STATUS SiI3132AtaPassThru (
>    IN     EFI_EVENT                        Event OPTIONAL
>    );
>  
> -EFI_STATUS SiI3132GetNextPort (
> +EFI_STATUS
> +EFIAPI
> +SiI3132GetNextPort (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN OUT UINT16                 *Port
>    );
>  
> -EFI_STATUS SiI3132GetNextDevice (
> +EFI_STATUS
> +EFIAPI
> +SiI3132GetNextDevice (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port,
>    IN OUT UINT16                 *PortMultiplierPort
>    );
>  
> -EFI_STATUS SiI3132BuildDevicePath (
> +EFI_STATUS
> +EFIAPI
> +SiI3132BuildDevicePath (
>    IN     EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN     UINT16                     Port,
>    IN     UINT16                     PortMultiplierPort,
>    IN OUT EFI_DEVICE_PATH_PROTOCOL   **DevicePath
>    );
>  
> -EFI_STATUS SiI3132GetDevice (
> +EFI_STATUS
> +EFIAPI
> +SiI3132GetDevice (
>    IN  EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN  EFI_DEVICE_PATH_PROTOCOL   *DevicePath,
>    OUT UINT16                     *Port,
>    OUT UINT16                     *PortMultiplierPort
>    );
>  
> -EFI_STATUS SiI3132ResetPort (
> +EFI_STATUS
> +EFIAPI
> +SiI3132ResetPort (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port
>    );
>  
> -EFI_STATUS SiI3132ResetDevice (
> +EFI_STATUS
> +EFIAPI
> +SiI3132ResetDevice (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port,
>    IN UINT16                     PortMultiplierPort
> diff --git a/EmbeddedPkg/GdbStub/GdbStubInternal.h b/EmbeddedPkg/GdbStub/GdbStubInternal.h
> index b8346d7a545f..b08159302cfa 100644
> --- a/EmbeddedPkg/GdbStub/GdbStubInternal.h
> +++ b/EmbeddedPkg/GdbStub/GdbStubInternal.h
> @@ -323,6 +323,7 @@ SendError (
>   Send 'OK' when the function is done executing successfully.
>   **/
>  VOID
> +EFIAPI
>  SendSuccess (
>    VOID
>    );
> @@ -332,6 +333,7 @@ SendSuccess (
>   Send empty packet to specify that particular command/functionality is not supported.
>   **/
>  VOID
> +EFIAPI
>  SendNotSupported (
>    VOID
>    );
> @@ -353,6 +355,7 @@ ReadNthRegister (
>   @param     SystemContext           Register content at time of the exception
>   **/
>  VOID
> +EFIAPI
>  ReadGeneralRegisters (
>    IN    EFI_SYSTEM_CONTEXT  SystemContext
>    );
> @@ -364,6 +367,7 @@ ReadGeneralRegisters (
>   @param     InBuffer            This is the input buffer received from gdb server
>   **/
>  VOID
> +EFIAPI
>  WriteNthRegister (
>    IN    EFI_SYSTEM_CONTEXT  SystemContext,
>    IN    CHAR8               *InBuffer
> @@ -377,6 +381,7 @@ WriteNthRegister (
>   **/
>  
>  VOID
> +EFIAPI
>  WriteGeneralRegisters (
>    IN    EFI_SYSTEM_CONTEXT  SystemContext,
>    IN    CHAR8               *InBuffer
> @@ -391,6 +396,7 @@ WriteGeneralRegisters (
>   @param  *PacketData  Pointer to Payload data for the packet
>   **/
>  VOID
> +EFIAPI
>  ReadFromMemory (
>    IN  CHAR8  *PacketData
>    );
> @@ -404,6 +410,7 @@ ReadFromMemory (
>   @param   PacketData     Pointer to Payload data for the packet
>   **/
>  VOID
> +EFIAPI
>  WriteToMemory (
>    IN CHAR8 *PacketData
>    );
> @@ -418,6 +425,7 @@ WriteToMemory (
>   **/
>  
>  VOID
> +EFIAPI
>  ContinueAtAddress (
>    IN  EFI_SYSTEM_CONTEXT   SystemContext,
>    IN  CHAR8                *PacketData
> @@ -432,6 +440,7 @@ ContinueAtAddress (
>   @param PacketData      Pointer to Payload data for the packet
>   **/
>  VOID
> +EFIAPI
>  SingleStep (
>    IN  EFI_SYSTEM_CONTEXT  SystemContext,
>    IN  CHAR8               *PacketData
> diff --git a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c
> index c250844eda74..08bba1bbf111 100644
> --- a/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c
> +++ b/EmbeddedPkg/Drivers/ConsolePrefDxe/ConsolePrefDxe.c
> @@ -174,6 +174,7 @@ RemoveSpcrTable (
>  
>  STATIC
>  VOID
> +EFIAPI
>  OnReadyToBoot (
>    IN EFI_EVENT  Event,
>    IN VOID       *Context
> diff --git a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
> index a0fca4d6a335..2138f7576bec 100644
> --- a/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
> +++ b/EmbeddedPkg/Drivers/Lan9118Dxe/Lan9118Dxe.c
> @@ -34,6 +34,7 @@ LAN9118_DEVICE_PATH Lan9118PathTemplate =  {
>  **
>  */
>  EFI_STATUS
> +EFIAPI
>  Lan9118DxeEntry (
>    IN EFI_HANDLE Handle,
>    IN EFI_SYSTEM_TABLE *SystemTable
> diff --git a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
> index f6a723adfb28..0e2905c1ebb0 100644
> --- a/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
> +++ b/EmbeddedPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c
> @@ -39,6 +39,7 @@ GetSataDevice (
>  }
>  
>  EFI_STATUS
> +EFIAPI
>  SiI3132AtaPassThruCommand (
>    IN     SATA_SI3132_INSTANCE             *SataSiI3132Instance,
>    IN     SATA_SI3132_PORT                 *SataPort,
> @@ -310,6 +311,7 @@ SiI3132AtaPassThruCommand (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132AtaPassThru (
>    IN     EFI_ATA_PASS_THRU_PROTOCOL       *This,
>    IN     UINT16                           Port,
> @@ -371,6 +373,7 @@ SiI3132AtaPassThru (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132GetNextPort (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN OUT UINT16                 *Port
> @@ -442,6 +445,7 @@ SiI3132GetNextPort (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132GetNextDevice (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port,
> @@ -523,6 +527,7 @@ SiI3132GetNextDevice (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132BuildDevicePath (
>    IN     EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN     UINT16                     Port,
> @@ -601,6 +606,7 @@ SiI3132BuildDevicePath (
>                                    port number does not exist.
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132GetDevice (
>    IN  EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN  EFI_DEVICE_PATH_PROTOCOL   *DevicePath,
> @@ -717,6 +723,7 @@ SiI3132HwResetPort (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132ResetPort (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port
> @@ -772,6 +779,7 @@ SiI3132ResetPort (
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  SiI3132ResetDevice (
>    IN EFI_ATA_PASS_THRU_PROTOCOL *This,
>    IN UINT16                     Port,
> diff --git a/EmbeddedPkg/MetronomeDxe/Metronome.c b/EmbeddedPkg/MetronomeDxe/Metronome.c
> index 579332169507..13db25168fac 100644
> --- a/EmbeddedPkg/MetronomeDxe/Metronome.c
> +++ b/EmbeddedPkg/MetronomeDxe/Metronome.c
> @@ -110,6 +110,7 @@ EFI_HANDLE  gMetronomeHandle = NULL;
>  
>  **/
>  EFI_STATUS
> +EFIAPI
>  MetronomeInitialize (
>    IN EFI_HANDLE         ImageHandle,
>    IN EFI_SYSTEM_TABLE   *SystemTable
> -- 
> 2.19.1.3.g30247aa5d201
> 
> 

  reply	other threads:[~2019-09-18 17:41 UTC|newest]

Thread overview: 155+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 19:49 [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs Laszlo Ersek
2019-09-17 19:49 ` [PATCH 01/35] DO NOT APPLY: edk2: turn standard handle types into pointers to non-VOID Laszlo Ersek
2019-09-17 20:06   ` [edk2-devel] " Ni, Ray
2019-09-17 20:22     ` Andrew Fish
2019-09-17 20:28       ` Ni, Ray
2019-09-17 21:07         ` Andrew Fish
2019-09-17 21:11           ` Michael D Kinney
2019-09-18  8:41       ` Laszlo Ersek
2019-09-18 15:16         ` Michael D Kinney
2019-09-18 17:41           ` Laszlo Ersek
2019-09-18 15:55         ` Andrew Fish
2019-09-18 16:16           ` Leif Lindholm
2019-09-18 17:45           ` Laszlo Ersek
2019-09-18  8:36     ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 02/35] EmbeddedPkg: add missing EFIAPI calling convention specifiers Laszlo Ersek
2019-09-18 17:41   ` Leif Lindholm [this message]
2019-09-17 19:49 ` [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call Laszlo Ersek
2019-09-24 10:47   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:12   ` Laszlo Ersek
2019-09-26 12:16   ` Ard Biesheuvel
2019-09-17 19:49 ` [PATCH 04/35] EmbeddedPkg/Universal/MmcDxe: "fix" CloseProtocol() call in BindingStop() Laszlo Ersek
2019-09-25 15:52   ` Ard Biesheuvel
2019-09-17 19:49 ` [PATCH 05/35] EmulatorPkg/DxeTimerLib: drop superfluous cast Laszlo Ersek
2019-09-17 20:02   ` Ni, Ray
2019-09-20 15:00   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 06/35] EmulatorPkg: stop abusing EFI_HANDLE for keystroke notify registration Laszlo Ersek
2019-09-17 20:01   ` Ni, Ray
2019-09-24 10:44   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 07/35] MdeModulePkg: fix cast in GetModuleInfoFromHandle() calls Laszlo Ersek
2019-09-19  1:46   ` Dandan Bi
2019-09-24 10:43   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 08/35] MdeModulePkg/UefiHiiLib: stop using EFI_HANDLE in place of EFI_HII_HANDLE Laszlo Ersek
2019-09-19  1:46   ` Dandan Bi
2019-09-24 10:49   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 09/35] MdeModulePkg: stop abusing EFI_EVENT for protocol notify registration Laszlo Ersek
2019-09-17 20:17   ` Ni, Ray
2019-09-25 16:02   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:10     ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 10/35] MdeModulePkg/PlatformVarCleanupLib: fix HiiConstructConfigHdr() call Laszlo Ersek
2019-09-23 11:45   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-24 17:28     ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 11/35] MdeModulePkg: document workaround for EFI_RUNTIME_EVENT_ENTRY PI spec bug Laszlo Ersek
2019-09-19  1:47   ` Dandan Bi
2019-09-17 19:49 ` [PATCH 12/35] MdeModulePkg: stop abusing EFI_HANDLE for keystroke notify registration Laszlo Ersek
2019-09-17 20:16   ` [edk2-devel] " Ni, Ray
2019-09-19  1:47   ` Dandan Bi
2019-09-24 10:54   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 13/35] MdeModulePkg: PEI Core: clean up "AprioriFile" handling in FindFileEx() Laszlo Ersek
2019-09-19  1:46   ` Dandan Bi
2019-09-24 15:40   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 14/35] MdeModulePkg: fix UninstallMultipleProtocolInterfaces() calls Laszlo Ersek
2019-09-17 20:16   ` Ni, Ray
2019-09-17 19:49 ` [PATCH 15/35] MdeModulePkg/PiSmmCore: make type punning consistent Laszlo Ersek
2019-09-18  2:38   ` Dong, Eric
2019-09-17 19:49 ` [PATCH 16/35] MdeModulePkg/S3SaveState: cast Position for S3BootScriptLib explicitly Laszlo Ersek
2019-09-19  1:47   ` [edk2-devel] " Dandan Bi
2019-09-17 19:49 ` [PATCH 17/35] MdePkg/DxeServicesLib: remove bogus cast Laszlo Ersek
2019-09-18  4:47   ` [edk2-devel] " Liming Gao
2019-09-24 15:38   ` Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress() Laszlo Ersek
2019-09-24 11:00   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-10-08  0:32     ` Siyuan, Fu
2019-10-08 23:36       ` Laszlo Ersek
2019-09-26 12:14   ` Laszlo Ersek
2019-10-03 11:05     ` Laszlo Ersek
2019-10-04 19:18       ` Laszlo Ersek
2019-10-07 18:15   ` Michael D Kinney
2019-09-17 19:49 ` [PATCH 19/35] NetworkPkg: fix CloseProtocol & UninstallMultipleProtocolInterfaces calls Laszlo Ersek
2019-09-26 12:14   ` [edk2-devel] " Laszlo Ersek
2019-09-26 12:42   ` Philippe Mathieu-Daudé
2019-09-30 20:16     ` Laszlo Ersek
2019-10-01  7:18       ` Philippe Mathieu-Daudé
2019-09-27  0:03   ` Siyuan, Fu
2019-09-17 19:49 ` [PATCH 20/35] NetworkPkg/Ip4Dxe: fix NetLibDestroyServiceChild() call Laszlo Ersek
2019-09-23 16:03   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-27  0:04     ` Siyuan, Fu
2019-09-26 12:14   ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 21/35] NetworkPkg/TcpDxe: fix SockFreeFoo() parameter list Laszlo Ersek
2019-09-23 15:09   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:14   ` Laszlo Ersek
2019-09-27  0:06   ` Siyuan, Fu
2019-09-17 19:49 ` [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call Laszlo Ersek
2019-09-18  9:32   ` Anthony PERARD
2019-09-18 10:30   ` Julien Grall
2019-09-23 15:03   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 23/35] OvmfPkg/VirtioNetDxe: fix SignalEvent() call Laszlo Ersek
2019-09-20 14:59   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:16   ` Laszlo Ersek
2019-09-26 12:17   ` Ard Biesheuvel
2019-09-17 19:49 ` [PATCH 24/35] OvmfPkg/PlatformDxe: fix EFI_HII_HANDLE parameters of internal functions Laszlo Ersek
2019-09-20 14:56   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-25 15:57   ` Ard Biesheuvel
2019-09-17 19:49 ` [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call Laszlo Ersek
2019-09-23 15:59   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:43     ` Laszlo Ersek
2019-10-04 20:01       ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls Laszlo Ersek
2019-09-23  9:55   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:45   ` Laszlo Ersek
2019-10-03 11:06     ` Laszlo Ersek
2019-10-04  0:05       ` Yao, Jiewen
2019-10-04 13:14       ` Zhang, Chao B
2019-10-04 18:15         ` Laszlo Ersek
2019-10-05 14:28       ` Zhang, Chao B
2019-10-07 18:14         ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration Laszlo Ersek
2019-09-23  9:56   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 12:46   ` Laszlo Ersek
2019-10-03 11:06     ` Laszlo Ersek
2019-10-04  0:05       ` Yao, Jiewen
2019-10-04 13:16       ` Zhang, Chao B
2019-10-05 14:28       ` Zhang, Chao B
2019-09-17 19:49 ` [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo Laszlo Ersek
2019-09-24 15:44   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26  2:46   ` Gao, Zhichao
2019-09-17 19:49 ` [PATCH 29/35] ShellPkg: stop using EFI_HANDLE in place of EFI_HII_HANDLE Laszlo Ersek
2019-09-25 18:04   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26 11:48     ` Laszlo Ersek
2019-09-26  2:43   ` Gao, Zhichao
2019-09-17 19:49 ` [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Laszlo Ersek
2019-09-23  9:58   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-26  2:53   ` Gao, Zhichao
2019-09-26 12:08     ` Laszlo Ersek
2019-09-26 14:43       ` Gao, Zhichao
2019-09-30 19:52         ` Laszlo Ersek
2019-09-17 19:49 ` [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Laszlo Ersek
2019-09-23 10:01   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-23 14:28     ` Carsey, Jaben
2019-09-24  1:18       ` Gao, Zhichao
2019-09-17 19:49 ` [PATCH 32/35] ShellPkg/UefiShellLib: clarify workaround for unfixable EdkShell bug Laszlo Ersek
2019-09-26 12:47   ` [edk2-devel] " Laszlo Ersek
2019-09-26 14:05     ` Gao, Zhichao
2019-09-26 14:58     ` Carsey, Jaben
2019-09-17 19:49 ` [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking Laszlo Ersek
2019-09-26 12:48   ` [edk2-devel] " Laszlo Ersek
2019-10-03 11:10     ` Laszlo Ersek
2019-10-03 11:17       ` Achin Gupta
2019-10-04  0:10       ` Yao, Jiewen
2019-10-04 14:53       ` Achin Gupta
2019-09-17 19:49 ` [PATCH 34/35] UefiPayloadPkg/BlSupportPei: fix MMCONFIG assignment from XSDT Laszlo Ersek
2019-09-23  2:30   ` Guo Dong
2019-09-26 13:17   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-17 19:49 ` [PATCH 35/35] UefiPayloadPkg/BlSupportDxe: fix ReserveResourceInGcd() calls Laszlo Ersek
2019-09-23  2:28   ` [edk2-devel] " Guo Dong
2019-09-23 15:08   ` Philippe Mathieu-Daudé
2019-09-23 16:02     ` Guo Dong
2019-09-23 16:04       ` Philippe Mathieu-Daudé
2019-09-24 17:29     ` Laszlo Ersek
2019-09-19  0:32 ` [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs Wu, Hao A
2019-09-23 16:27 ` Marvin Häuser
2019-09-24 20:26   ` Laszlo Ersek
2019-09-25  8:13     ` Marvin Häuser
2019-09-25 15:54       ` Laszlo Ersek
2019-10-08 23:49 ` Laszlo Ersek
2019-10-09  9:50   ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190918174138.GK28454@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox