public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Cheng, Ching JenX" <ching.jenx.cheng@intel.com>
To: devel@edk2.groups.io
Subject: [PATCH v3 0/2] *** Add VS2019 Support ***
Date: Thu, 19 Sep 2019 16:52:24 +0800	[thread overview]
Message-ID: <20190919085226.15500-1-ching.jenx.cheng@intel.com> (raw)

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182

In order to support VS2019 on EDK2, the following patches was modified def and batch files
1. Add VS2019 x86/64 definitions on tools_def.template
2. Add VS2019 support on toolsetup batches, and add version check with command vswhere
     Because VS2019 and VS2017 using the same vswhere to get the InstallationPath

v2: In 01/02, add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST
v3: In 02/02, In BaseTools\set_vsprefix_envs.bat,
    move WINSDK10_PREFIX setting into VCToolsInstallDir check condition.

Ching JenX Cheng (2):
  Add VS2019 Toolchain def
  Add VS2019 Support on ToolSetup Batches

 BaseTools/Conf/tools_def.template | 220 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
 BaseTools/get_vsvars.bat          |  37 ++++++++++++++++++++++++++++++-------
 BaseTools/set_vsprefix_envs.bat   |  86 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------
 BaseTools/toolsetup.bat           |  16 +++++++++++++---
 edksetup.bat                      |   6 ++++--
 5 files changed, 321 insertions(+), 44 deletions(-)

--
2.21.0.windows.1


             reply	other threads:[~2019-09-19  8:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  8:52 Cheng, Ching JenX [this message]
2019-09-19  8:52 ` [PATCH v3 1/2] Add VS2019 Toolchain def Cheng, Ching JenX
2019-09-19  8:52 ` [PATCH v3 2/2] Add VS2019 Support on ToolSetup Batches Cheng, Ching JenX
2019-09-24  0:44 ` [edk2-devel] [PATCH v3 0/2] *** Add VS2019 Support *** Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919085226.15500-1-ching.jenx.cheng@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox