public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "Gao, Zhichao" <zhichao.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	Andrew Fish <afish@apple.com>, Laszlo Ersek <lersek@redhat.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase
Date: Thu, 19 Sep 2019 10:17:53 +0100	[thread overview]
Message-ID: <20190919091753.GM28454@bivouac.eciton.net> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE60A@SHSMSX104.ccr.corp.intel.com>

I have no objection to this addition, but I do have two questions - and
really I realise this is a follow-on for 81a8a52a6bb21  ("ShellBinPkg:
Remove ShellBinPkg"):

1) Since ShellBinPkg no longer exists, what is the intent of listing
   this in the Maintainers.txt file? Generally, this is so that people
   know who to Cc: on patches - but there will not be any patches here.
2) If Zhichao is now responsible for this, should Jaben and Ray still
   be listed?

Best Regards,

Leif

On Thu, Sep 19, 2019 at 05:58:16AM +0000, Gao, Liming wrote:
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> >-----Original Message-----
> >From: Gao, Zhichao
> >Sent: Thursday, September 19, 2019 1:46 PM
> >To: devel@edk2.groups.io
> >Cc: Andrew Fish <afish@apple.com>; Laszlo Ersek <lersek@redhat.com>; Leif
> >Lindholm <leif.lindholm@linaro.org>; Kinney, Michael D
> ><michael.d.kinney@intel.com>; Ni, Ray <ray.ni@intel.com>; Ard Biesheuvel
> ><ard.biesheuvel@linaro.org>; Gao, Liming <liming.gao@intel.com>
> >Subject: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase
> >
> >Zhichao is responsible for the IA32 and X64 ARCH shell binary generation.
> >
> >Cc: Andrew Fish <afish@apple.com>
> >Cc: Laszlo Ersek <lersek@redhat.com>
> >Cc: Leif Lindholm <leif.lindholm@linaro.org>
> >Cc: Michael D Kinney <michael.d.kinney@intel.com>
> >Cc: Ray Ni <ray.ni@intel.com>
> >Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >Cc: Liming Gao <liming.gao@intel.com>
> >Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> >---
> > Maintainers.txt | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/Maintainers.txt b/Maintainers.txt
> >index dcf81c737a..a0121123ec 100644
> >--- a/Maintainers.txt
> >+++ b/Maintainers.txt
> >@@ -426,6 +426,7 @@ Maintainers for stable Shell binaries generation
> > when need to publish Shell binaries with edk2 release:
> > M: Jaben Carsey <jaben.carsey@intel.com>      (Ia32/X64)
> > M: Ray Ni <ray.ni@intel.com>                  (Ia32/X64)
> >+M: Zhichao Gao <zhichao.gao@intel.com>        (Ia32/X64)
> > M: Leif Lindholm <leif.lindholm@linaro.org>   (ARM/AArch64)
> > M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
> >
> >--
> >2.21.0.windows.1
> 

  reply	other threads:[~2019-09-19  9:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19  5:45 [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase Gao, Zhichao
2019-09-19  5:58 ` Liming Gao
2019-09-19  9:17   ` Leif Lindholm [this message]
2019-09-19 14:16     ` Liming Gao
2019-09-19 14:39       ` Leif Lindholm
2019-09-19 14:56         ` Liming Gao
2019-09-19 19:46           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190919091753.GM28454@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox