From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=nKWe9e3S; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Thu, 19 Sep 2019 02:44:54 -0700 Received: by mail-wr1-f66.google.com with SMTP id y19so2380380wrd.3 for ; Thu, 19 Sep 2019 02:44:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=di2EWtRwsUuFu7xQjRJCEPOD+nuzjhR9y5Z+bE2iXDY=; b=nKWe9e3Sfp9/PVb4ilkb6xCQJVlCB2hL05y1Xhkko4MnauByKYRDPrdO+twbb0QOtr wi0wURNM706qAlEdEcn4L8CBVInov+YtCq8tb2N3LLHia6zNbC9eUtkLoxM/TeiCuyV3 gjju8oGrGcf2nPc59IpQMcgLOVwYbt0szv51fzJSWStdp9soWnwEcBvGvmMfUB6Dq9nM Ce9aF6H0DVqeWt4NPsHzQqWCXgcuyzOACb/YmVoeKpqlU43qR6cn9LEwuujIbPaegsx8 dfifa2aDEDpAgGvd37rfnzPu0JwzgsF6Yuuv+hHBOU/fD9gEvEYS43KyduZJySS16kAC 3oAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=di2EWtRwsUuFu7xQjRJCEPOD+nuzjhR9y5Z+bE2iXDY=; b=qX946OOvYMX2otECc//VEZjQ2s05Y+T4cyCmWgUWn9OdsNbRBhC7wPB3EhEEE7DhYr 57z52poDJn3oVYrE+WZJgrOHwEdRUqjNQZIIIN12yypyWIZUB7U727JQrzS53jnkD8cR ss0GkwoHoMGKsxYTZkdjbM2zc9QAC4f3sEk8LANIZz/YSPmfc0E2vaQv4VBYTyjcJbjA zVXMbzNsh695m8L+hCagNeXsHWvbbsZXaUM6poMAlPNsFHOmKMf2KrTztHw2RgHYFJ/r /sdxWs55W2w5JgmfxxJLeGMGFGXFXaAk3Cv7YlNZYOP/OvjaoKTpqINWQ8zcvKE8dS7y Oegw== X-Gm-Message-State: APjAAAVUBwtKO267ZR8uZtalqfZDQCA10q0/s6v+GSfO889kZulPPWcf AXUW6MbFmo+jTaQNk19kKRvKMQ== X-Google-Smtp-Source: APXvYqwv2KLExCqCZRWU2coMTZrzf+VDoHP93IcLV3cpF61RTI0h/7p6b1dqCJdMqeqdGB92kR78pA== X-Received: by 2002:a5d:46c4:: with SMTP id g4mr5922485wrs.189.1568886292747; Thu, 19 Sep 2019 02:44:52 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id s19sm12703420wrb.14.2019.09.19.02.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 02:44:52 -0700 (PDT) Date: Thu, 19 Sep 2019 10:44:50 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: Baptiste Gerondeau , "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" , "Kinney, Michael D" , "Zhang, Shenglei" Subject: Re: [PATCH 0/3] Arm builds on Visual Studio Message-ID: <20190919094450.GN28454@bivouac.eciton.net> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE630@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE630@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Liming, On Thu, Sep 19, 2019 at 06:19:42AM +0000, Gao, Liming wrote: > I add my comments. > > >-----Original Message----- > >From: Baptiste Gerondeau [mailto:baptiste.gerondeau@linaro.org] > >Sent: Thursday, September 19, 2019 12:05 AM > >To: devel@edk2.groups.io > >Cc: ard.biesheuvel@linaro.org; leif.lindholm@linaro.org; Kinney, Michael D > >; Gao, Liming ; Zhang, > >Shenglei ; Baptiste Gerondeau > > > >Subject: [PATCH 0/3] Arm builds on Visual Studio > > > >EDIT: Resending the series since I mistakenly used the wrong email, > >sorry ! > > > >We are currently making an effort to make ARM (and AARCH64 eventually) > >builds using Microsoft's Visual Studio Compiler (aka MSVC/MSFT). > > > >These 3 patches correspond to an effort to make the assembler work with > >MSFT, which entails : > >- Feeding MSFT the RVCT .asm files, since they share syntax > > requirements. > > Please separate the patch. Each patch is for each package, can't cross packages. > If so, the package maintainer can easy review the change. I agree with this as a general rule, but for this (hopefully never to be repeated) operation, it makes sense to me to keep each change in this set as one patch. For the simple reason that the alternative leaves several unusable commits in sequence in the repository. There is simply no way to bisect through this change on a per-package basis. This is after all a horrible horrible hack that lets us keep using the .asm files provided for one toolchain family (RVCT) in a different toolchain family (MSFT), without having to delete and re-add, losing history in the process. Would you be OK with an exception for this extremely unusual situation? > >- Fixing some instructions syntax in those .asm files, in order to make > > them palatable for MSFT. > >- Fixing some minor formatting issue in INF files, while we're at it. > > > >This set enables the assembler, meanwhile the C also require changes, > >which will come in a set later. This set makes the RVCT toolchain family > >and profiles obsolete, unblocking : > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1750 > > With this change, can we continue to work on BZ 1750? Yes. / Leif > >As mentioned in the above bug, dropping RVCT would entail orphanating > >the .asm files that powered the RVCT build. Since Visual Studio uses the > >same file syntax, those can be reused to power the VS build. > > > >These patches have been tested on VS2019 (v15.9.11) and VS2017 (v16.0.1) > > Do you mean you verify this change with new VS2019 tool chain? > > Thanks > Liming > > > >Baptiste GERONDEAU (3): > > ArmPkg/MdePkg : Unify INF files format > > ARM/Assembler: Correct syntax from RVCT for MSFT > > ARM/Assembler: Reuse RVCT assembler for MSFT build > > > > ArmPkg/Drivers/ArmGic/ArmGicLib.inf | 2 +- > > ArmPkg/Library/ArmExceptionLib/Arm/ExceptionSupport.asm | 30 > >+++++++++++++++++------------- > > ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf | 2 +- > > ArmPkg/Library/ArmExceptionLib/ArmRelocateExceptionLib.inf | 2 +- > > ArmPkg/Library/ArmHvcLib/ArmHvcLib.inf | 2 +- > > ArmPkg/Library/ArmLib/Arm/ArmV7Support.asm | 6 ++++-- > > ArmPkg/Library/ArmLib/ArmBaseLib.inf | 8 ++++---- > > ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 ++-- > > ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf | 2 +- > > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf > >| 2 +- > > ArmPkg/Library/ArmSvcLib/ArmSvcLib.inf | 2 +- > > ArmPlatformPkg/Library/ArmPlatformLibNull/ArmPlatformLibNull.inf | 2 +- > > ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf | 2 > >+- > > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 6 +++--- > > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 6 +++--- > > ArmPlatformPkg/PrePi/PeiMPCore.inf | 2 +- > > ArmPlatformPkg/PrePi/PeiUniCore.inf | 2 +- > > MdePkg/Library/BaseIoLibIntrinsic/Arm/ArmVirtMmio.asm | 18 > >+++++++++--------- > > MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicArmVirt.inf | 2 +- > > MdePkg/Library/BaseMemoryLibOptDxe/BaseMemoryLibOptDxe.inf | > >20 ++++++++++---------- > > MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf | 2 +- > > 21 files changed, 65 insertions(+), 59 deletions(-) > > > >-- > >2.23.0 >