From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=wcO4+8gG; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 19 Sep 2019 03:37:22 -0700 Received: by mail-wr1-f68.google.com with SMTP id l11so2544593wrx.5 for ; Thu, 19 Sep 2019 03:37:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hBm4XEYMFTZVyrI1P/66bRaitZq5ABel9zpx+AsU1oc=; b=wcO4+8gGxcc0ZkvPzS+mRfovQhG5XBG5AQr2RHgap29ZesetH9yqmuMT9m+p0MRVhB LOLP1OYN/tg2fRx181t34mwKXZPHaymcQ9pGZliak761YtqBBkctZ+Ur4Oot2O2RFaPm XK15IC0aYxcLS9T/xWxZ/iYhUUMYr3m9/f6tLxLxpJp6FdmN3kn9YfJ5pFfFKErxM/lU WhuekLNbjVOGtuXleSeaiI3uJLzXErC3WmjSzRsTrrZrZXn91knQGC1sHYA4z+iL8WsV 6blpDnv3ae0UwjAUwbroFHpgGus9DMV5W3czjho6836pYc0KWzDPwnnsBtmkOSFhgNCW TY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hBm4XEYMFTZVyrI1P/66bRaitZq5ABel9zpx+AsU1oc=; b=DSiIroN78v9LykT8EgFgO/kmk8dP1Z3W1iW/2eWwVNg3w5M8z5DmDHFQNCws5dvdQY jKjTIMSoqMiciFD4/ENI9DIY8PPr++otklMlxNhX6Yp8eXCPx5KtMAChd6yy7feM/M4r cZ8b2lGteVAFzB3eQO2ZTQVdWFrEYW2USi+Rr0Vz2rJ6fm/zPE7+rECrCAAAekGhBW11 qNf172ZOXzDLGTRI7BW8+SVKpCdc25DDig06OC8Rv+uixtpYpc0R0UQMXDLODo6M/Ugl QS1ozvrGgop9SbV0eFYX1sJsaXk210sTyfxikyq2VrDzWxIHyGQVxfNuTId76u2h+T5n RVaA== X-Gm-Message-State: APjAAAV/7pfdXRsc1oj1tSCM9lcuRDV0IhPWq5CO8J2F7Eoke5EVak4c LzLj+WxZk1byX/zw/sYv4yfJHQ== X-Google-Smtp-Source: APXvYqwNFGDevukt1IuVW3hw7G+5neuZ9W1S4HO7hEkDVkqyfo1UQWa45UtXhFQDek03ocEfTLjHkA== X-Received: by 2002:adf:84c6:: with SMTP id 64mr6405107wrg.287.1568889440376; Thu, 19 Sep 2019 03:37:20 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id d28sm12581936wrb.95.2019.09.19.03.37.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 03:37:19 -0700 (PDT) Date: Thu, 19 Sep 2019 11:37:18 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Baptiste Gerondeau , edk2-devel-groups-io , "Kinney, Michael D" , "Gao, Liming" , "Zhang, Shenglei" , Baptiste GERONDEAU Subject: Re: [PATCH 2/3] ARM/Assembler: Correct syntax from RVCT for MSFT Message-ID: <20190919103718.GS28454@bivouac.eciton.net> References: <0d024d72b50b7f5a6d3d908d309810f350c5b1f5.1568808805.git.baptiste.gerondeau@linaro.org> <20190919094846.GO28454@bivouac.eciton.net> <20190919100921.GR28454@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 19, 2019 at 01:25:37PM +0300, Ard Biesheuvel wrote: > On Thu, 19 Sep 2019 at 13:09, Leif Lindholm wrote: > > > So is this simply the default of the compiler? I'd prefer it if we > > > could add a 'CODE 32' directive instead, that way, we may not need any > > > of the other changes to begin with. > > > > Some of them really weren't supported regardless (and the indentation > > change of directives was required). > > > > This one, possible - Baptiste? > > > > Oh, and the CODE 32 directive is not supported - it's ARM or THUMB :) > > https://docs.microsoft.com/en-us/cpp/assembler/arm/arm-assembler-directives?view=vs-2019 > > OK. > > In any case, I'd strongly prefer it if the .S and .asm files produced > identical object code, so please apply the same changes to the sibling > .S files as well, please (but only the ones that are really required > when building it in ARM mode) That _is_ a good point which I hadn't taken into consideration. But that does mean we should force all .asm files to ARM, doesn't it? Or do you mean that you're happy if the *disassembly* of the object files to produce the same syntax? / Leif