From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=zSV7q4KF; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Thu, 19 Sep 2019 03:47:14 -0700 Received: by mail-wm1-f68.google.com with SMTP id 5so3906462wmg.0 for ; Thu, 19 Sep 2019 03:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vHfotwsK4UlglqkYWuOPNwGAI1+4fsUT+M73HnVg9as=; b=zSV7q4KF8KlNBRE66eC5GOo/rjsFbHtVVHfw++bOcwGHswbPp5gFEwhurO5ktvK/QW L47/8BgxTHIegUHXouKvOdnK9a6QrHWVvbscocnws2jx4fl2WT2OdT/+giehfGiR2YQu UuAeYIAPz2ZgnRX7sUp7AYqz1Lja7zb2wMVhM7stTBPdZKyqKlpi5m+6FXXY7hGR2mif p3Z91PwEKtYL1NkMqcC87Yk6EuieqXPB6migN6SwZ1wCrrUqeoP6Ezc7L7tt2DCiElWB gzZBRB44KE3sCQd5KnE3kXZR7mW5JWJKshzlf5aGufDGrXxjPOD7JmLOe0S6TdtWZ1GU VvEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vHfotwsK4UlglqkYWuOPNwGAI1+4fsUT+M73HnVg9as=; b=WQpt4SkG8kME6L3kx8ALi96dJQjA1oazRRlu06RaoeQIIzAWdV8Dx3OyHPxLb+djrF FZlSoJyusvFBw/NHR7uCjsNFaoRTeWeZR3j+0CkGAQTZIVxnpi8U8xINb850dLzLsZcB ZLBaRy9U+cZR9PW79a44bbklumowvngGyUPrAb745FTM4aYrcG0nQpT1Qt0j+T/j0LQW qU98AffP8+HuqYtR/794EVjDd9+gBI2Wh0BNGBYd4lReqU+Mu0pfqF08HWT+aX9rXMxV h8h+Yvp4fsMmNl1Ocd6/BK7AVLA+WqhGOoimY7qdTbA7HkJxSPrnlPWM1nEgEhhwKTkk ZkYw== X-Gm-Message-State: APjAAAW+249YFhvhdeJmlZnqJqXrynYyQePif4C7UkuWFo/k7AM7DQRh CKJUn6Sdna53Yz11S8juSZlckQ== X-Google-Smtp-Source: APXvYqxqSAcMk+hy4j+FloIGgCiRuh96yhFpGGuAdw2YAXTwQJc7FzKcrC3VdSAhnZFjhzwd9w4ytw== X-Received: by 2002:a1c:1d8d:: with SMTP id d135mr2366329wmd.7.1568890033069; Thu, 19 Sep 2019 03:47:13 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n12sm3762678wmk.41.2019.09.19.03.47.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 03:47:12 -0700 (PDT) Date: Thu, 19 Sep 2019 11:47:11 +0100 From: "Leif Lindholm" To: Ard Biesheuvel Cc: Baptiste Gerondeau , edk2-devel-groups-io , "Kinney, Michael D" , "Gao, Liming" , "Zhang, Shenglei" , Baptiste GERONDEAU Subject: Re: [PATCH 2/3] ARM/Assembler: Correct syntax from RVCT for MSFT Message-ID: <20190919104711.GT28454@bivouac.eciton.net> References: <0d024d72b50b7f5a6d3d908d309810f350c5b1f5.1568808805.git.baptiste.gerondeau@linaro.org> <20190919094846.GO28454@bivouac.eciton.net> <20190919100921.GR28454@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 19, 2019 at 01:37:40PM +0300, Ard Biesheuvel wrote: > On Thu, 19 Sep 2019 at 13:34, Baptiste Gerondeau > wrote: > >> In any case, I'd strongly prefer it if the .S and .asm files produced > >> identical object code, so please apply the same changes to the sibling > >> .S files as well, please (but only the ones that are really required > >> when building it in ARM mode) > > > > > > ACK ! Will mirror changes to asm on S files (on separate commit, right ?) > > I'm only touching the files VS2019 as a problem with on the ARM > > build anyways (this is what you meant by "really required" right > > ?) > > I mean that I'd prefer to assemble the .asm files in ARM mode, > especially since I am not convinced that the startup code we have is > guaranteed to switch into the right mode after the CPU comes out of > reset in ARM mode. That could be resolved with a trivial branch at that point (or just forcing ARM for the whole entry file) though. But I'm OK with forcing ARM for all .asm files for now. / Leif