From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=EWXM00KV; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Thu, 19 Sep 2019 07:39:08 -0700 Received: by mail-wm1-f66.google.com with SMTP id 7so4888768wme.1 for ; Thu, 19 Sep 2019 07:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Avf9j22U+0tG9hpHTM/ctjgdGEDkMCz/7TNCVV26CMs=; b=EWXM00KVpAcY6hmn8bEHCy6+s//huiwTyKFpn6jYHgoSUaUi/RpJVtSHd002O1DmcC advYmMBdNfWVmJTp/v+fr7ZaDKvsgxvACGxbpP9B3IzQG8B8R0wTa7v8j+95uE82FmYu YQzu9kEgmpK+eHjMhqHEtyQgb4fKNQlfe519ScewdBcBsM5HgPgOyczrN5V7CfjJNI2Z cQbbbphsRvaNSeEaIK+Vt0fg86+3ruB/U3AZNF6YXfh1pbJEeHzuwayMwhxIrh1vpcG+ DgFMyl+ej3xST5+xRRWE9V9IblZrD3NoOpKtwrSSrkOpqYe2uMJ5PbjZ0b200j7MmjI3 +ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Avf9j22U+0tG9hpHTM/ctjgdGEDkMCz/7TNCVV26CMs=; b=jgdXGZSLhglZcggJ3sym3NxhHjlCJbeWqHGi1ySU90FbPmyBOu/OskY9fQLMpXlXUk jMivbvQ1HrY5esyA8Vmtq5q7ZRx8vVAnW34C+06sQvfmXrKSnOENo/Kb1F08/g70uNs3 dlDhxrzbEBuI3ECqHSKyaQZ5RjBujNN5cRAyztZpinLGZMMSkZ1E+88tt+YxkxGu2gWE /BV//bsuZ7vLN7DwejWEYGIqEDOlrbfAchDWnfTgRYa0jqjhWzZeh0m8IFfn/Q6U9agk kTat98fK6dWFU2Vn5M9GAXCiV6ebSrr8eQN7QkE8PtVGUghL4Dwcy/X69rzndzhTkFHE WAKA== X-Gm-Message-State: APjAAAVMUsquStF0E67n0VWvP5DPZu8ZEKjc8pP04PS4jGbQPBrFLL9r 7oi9eZ1nHBuz5cCijTjLl6d5cg== X-Google-Smtp-Source: APXvYqyys5pL/dADfBsAoifQMnLXWmHvZUpOTqF8iqtCgjTf39p50Qkr1Ag6D6gHpU8DDmkGtNTcRw== X-Received: by 2002:a1c:1f89:: with SMTP id f131mr3034001wmf.72.1568903946980; Thu, 19 Sep 2019 07:39:06 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y186sm11246280wmb.41.2019.09.19.07.39.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2019 07:39:06 -0700 (PDT) Date: Thu, 19 Sep 2019 15:39:04 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "Gao, Zhichao" , "devel@edk2.groups.io" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" , "Ni, Ray" , Ard Biesheuvel Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase Message-ID: <20190919143904.GY28454@bivouac.eciton.net> References: <20190919054531.8176-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FE60A@SHSMSX104.ccr.corp.intel.com> <20190919091753.GM28454@bivouac.eciton.net> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEA2C@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4FEA2C@SHSMSX104.ccr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Sep 19, 2019 at 02:16:44PM +0000, Gao, Liming wrote: > Leif: > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Thursday, September 19, 2019 5:18 PM > > To: Gao, Liming > > Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fish ; Laszlo Ersek ; > > Kinney, Michael D ; Ni, Ray ; Ard Biesheuvel > > Subject: Re: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase > > > > I have no objection to this addition, but I do have two questions - and > > really I realise this is a follow-on for 81a8a52a6bb21 ("ShellBinPkg: > > Remove ShellBinPkg"): > > > > 1) Since ShellBinPkg no longer exists, what is the intent of listing > > this in the Maintainers.txt file? Generally, this is so that people > > know who to Cc: on patches - but there will not be any patches here. > > Here is the info who can be contacted to generate the binary files > for the quarter stable tag. I agree this is important to keep somewhere. But I am unsure if Maintainers.txt is the location for that. Clearly it was when ShellBinPkg existed, but I am not sure now. And yes, this is something I should have realised when ShellBinPkg was removed - but I didn't at that point. So there is no need to hold back this patch. But I think it would make possibly more sense to add this information either into a ShellPkg/Readme.md or the wiki. If we keep the information in Maintainers.txt, I would suggest creating a new section below "EDK II Releases:" with a W: entry pointing somewhere. Best Regards, Leif > > 2) If Zhichao is now responsible for this, should Jaben and Ray still > > be listed? > > > I think Jaben and Ray can be removed. > > Thanks > Liming > > Best Regards, > > > > Leif > > > > On Thu, Sep 19, 2019 at 05:58:16AM +0000, Gao, Liming wrote: > > > Reviewed-by: Liming Gao > > > > > > >-----Original Message----- > > > >From: Gao, Zhichao > > > >Sent: Thursday, September 19, 2019 1:46 PM > > > >To: devel@edk2.groups.io > > > >Cc: Andrew Fish ; Laszlo Ersek ; Leif > > > >Lindholm ; Kinney, Michael D > > > >; Ni, Ray ; Ard Biesheuvel > > > >; Gao, Liming > > > >Subject: [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase > > > > > > > >Zhichao is responsible for the IA32 and X64 ARCH shell binary generation. > > > > > > > >Cc: Andrew Fish > > > >Cc: Laszlo Ersek > > > >Cc: Leif Lindholm > > > >Cc: Michael D Kinney > > > >Cc: Ray Ni > > > >Cc: Ard Biesheuvel > > > >Cc: Liming Gao > > > >Signed-off-by: Zhichao Gao > > > >--- > > > > Maintainers.txt | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > >diff --git a/Maintainers.txt b/Maintainers.txt > > > >index dcf81c737a..a0121123ec 100644 > > > >--- a/Maintainers.txt > > > >+++ b/Maintainers.txt > > > >@@ -426,6 +426,7 @@ Maintainers for stable Shell binaries generation > > > > when need to publish Shell binaries with edk2 release: > > > > M: Jaben Carsey (Ia32/X64) > > > > M: Ray Ni (Ia32/X64) > > > >+M: Zhichao Gao (Ia32/X64) > > > > M: Leif Lindholm (ARM/AArch64) > > > > M: Ard Biesheuvel (ARM/AArch64) > > > > > > > >-- > > > >2.21.0.windows.1 > > >