From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: devel@edk2.groups.io
Subject: Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace
Date: Fri, 20 Sep 2019 11:24:36 +0100 [thread overview]
Message-ID: <20190920102436.GD28454@bivouac.eciton.net> (raw)
In-Reply-To: <ecc922e0-9e38-0f23-533c-7e08017349a6@redhat.com>
On Fri, Sep 20, 2019 at 08:13:36AM +0200, Laszlo Ersek wrote:
> On 09/19/19 20:06, Leif Lindholm wrote:
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Anthony Perard <anthony.perard@citrix.com>
> > Cc: Julien Grall <julien.grall@arm.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++--
> > OvmfPkg/AcpiPlatformDxe/Xen.c | 8 ++++----
> > OvmfPkg/AcpiTables/Facs.aslc | 6 +++---
> > OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.Vfr | 18 +++++++++---------
> > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_32.h | 4 ++--
> > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen-x86_64.h | 4 ++--
> > OvmfPkg/Include/IndustryStandard/Xen/arch-x86/xen.h | 4 ++--
> > OvmfPkg/Include/IndustryStandard/Xen/hvm/params.h | 2 +-
> > OvmfPkg/Include/IndustryStandard/Xen/io/protocols.h | 2 +-
> > OvmfPkg/Include/IndustryStandard/Xen/io/ring.h | 34 +++++++++++++++++-----------------
> > OvmfPkg/Include/IndustryStandard/Xen/memory.h | 4 ++--
> > OvmfPkg/Include/IndustryStandard/Xen/xen-compat.h | 4 ++--
> > OvmfPkg/Include/IndustryStandard/Xen/xen.h | 10 +++++-----
> > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h | 2 +-
> > OvmfPkg/Library/DxePciLibI440FxQ35/PciLib.c | 12 ++++++------
> > OvmfPkg/Library/LockBoxLib/LockBoxDxe.c | 2 +-
> > OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 2 +-
> > OvmfPkg/Library/LockBoxLib/LockBoxLib.h | 2 +-
> > OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.c | 4 ++--
> > OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.c | 2 +-
> > OvmfPkg/Library/XenIoMmioLib/XenIoMmioLib.c | 2 +-
> > OvmfPkg/PlatformPei/Xen.c | 2 +-
> > OvmfPkg/SataControllerDxe/ComponentName.c | 6 +++---
> > OvmfPkg/SataControllerDxe/SataController.c | 214 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------------------------------------------------------------------------------------------
> > OvmfPkg/SataControllerDxe/SataController.h | 208 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------
>
> (did you forget --stat-graph-width=20?)
Hmm...
*scratches head*
First of all, I saw that before sending out and didn't even reflect on
it. Clearly past git-send-email-o-clock.
Secondly, I have
[diff]
statGraphWidth = 20
in .git/config from running SetupGit.py.
Oh, rubbish. From git-diff manpage:
---
The width of the graph part can be limited by using
--stat-graph-width=<width> (affects all commands generating a stat
graph) or by setting diff.statGraphWidth=<width> (does not affect git
format-patch).
---
I had missed that bit. So yeah, that setting in SetupGit.py is
completely meaningless.
(Why would you give those two different code paths?!?)
Which given we already can't set --stat ...
Do you think it might be a good idea to set up a few standard aliases?
> > OvmfPkg/SataControllerDxe/SataControllerDxe.inf | 6 +++---
> > OvmfPkg/Sec/SecMain.c | 34 +++++++++++++++++-----------------
> > 27 files changed, 301 insertions(+), 301 deletions(-)
>
> I've checked this patch with "git show -b" (--> nothing) and "git show
> --word-diff" (--> output consists purely of context).
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
/
Leif
next prev parent reply other threads:[~2019-09-20 10:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 18:06 [PATCH 0/7] Strip trailing whitespace Leif Lindholm
2019-09-19 18:06 ` [PATCH 1/7] ArmPkg: strip " Leif Lindholm
2019-09-23 9:46 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 2/7] ArmPlatformPkg: " Leif Lindholm
2019-09-23 9:46 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 3/7] BaseTools: " Leif Lindholm
2019-09-20 6:06 ` Liming Gao
2019-09-20 10:37 ` Leif Lindholm
2019-09-23 5:28 ` Liming Gao
2019-09-19 18:06 ` [PATCH 4/7] EmulatorPkg: " Leif Lindholm
2019-09-19 18:28 ` [edk2-devel] " Ni, Ray
2019-09-23 9:46 ` Philippe Mathieu-Daudé
2019-09-19 18:06 ` [PATCH 5/7] MdeModulePkg: " Leif Lindholm
2019-09-20 1:03 ` [edk2-devel] " Wu, Hao A
2019-09-19 18:06 ` [PATCH 6/7] OvmfPkg: " Leif Lindholm
2019-09-20 6:13 ` [edk2-devel] " Laszlo Ersek
2019-09-20 10:24 ` Leif Lindholm [this message]
2019-09-23 9:49 ` Philippe Mathieu-Daudé
2019-09-24 16:05 ` Laszlo Ersek
2019-09-19 18:06 ` [PATCH 7/7] UefiCpuPkg: " Leif Lindholm
2019-09-19 18:28 ` [edk2-devel] " Ni, Ray
2019-09-23 9:49 ` Philippe Mathieu-Daudé
2019-09-19 19:20 ` [PATCH 0/7] Strip " Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920102436.GD28454@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox